D7461: Add syntax highlighting for AppArmor Profiles.
aacid closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7461 To: nibags, #kate, #framework_syntax_highlighting, dhaumann Cc: dhaumann, cullmann, #framework_syntax_highlighting, #frameworks, vkrause
D7461: Add syntax highlighting for AppArmor Profiles.
nibags added a comment. It seems that I do not have access to commits. You better push it REPOSITORY R216 Syntax Highlighting BRANCH add-apparmor-syntax (branched from master) REVISION DETAIL https://phabricator.kde.org/D7461 To: nibags, #kate, #framework_syntax_highlighting, dhaumann Cc: dhaumann, cullmann, #framework_syntax_highlighting, #frameworks, vkrause
D7461: Add syntax highlighting for AppArmor Profiles.
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Thanks, I am fine with this now. Shall I push this for you, or do you have commit access as well? REPOSITORY R216 Syntax Highlighting BRANCH add-apparmor-syntax (branched from master) REVISION DETAIL https://phabricator.kde.org/D7461 To: nibags, #kate, #framework_syntax_highlighting, dhaumann Cc: dhaumann, cullmann, #framework_syntax_highlighting, #frameworks, vkrause
D7461: Add syntax highlighting for AppArmor Profiles.
nibags added a comment. Ready! I've updated the license. If you need me to change something else (or if there is something you don't like), let me know. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7461 To: nibags, #kate, #framework_syntax_highlighting, dhaumann Cc: dhaumann, cullmann, #framework_syntax_highlighting, #frameworks, vkrause
D7461: Add syntax highlighting for AppArmor Profiles.
nibags updated this revision to Diff 19578. nibags added a comment. - License is changed to MIT REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7461?vs=18983=19578 BRANCH add-apparmor-syntax (branched from master) REVISION DETAIL https://phabricator.kde.org/D7461 AFFECTED FILES autotests/folding/usr.bin.apparmor-profile-test.fold autotests/html/usr.bin.apparmor-profile-test.html autotests/input/usr.bin.apparmor-profile-test autotests/reference/usr.bin.apparmor-profile-test.ref data/syntax/apparmor.xml To: nibags, #kate, #framework_syntax_highlighting, dhaumann Cc: dhaumann, cullmann, #framework_syntax_highlighting, #frameworks, vkrause
D7461: Add syntax highlighting for AppArmor Profiles.
dhaumann added a comment. From what I can tell, the xml file looks quite good, although it contains many rules so it is hard to completely review this. With respect to MIT: We were discussing licensing last Akademy conference (this year), and the issue with LGPL is that we are not even sure whether many the syntax definitions can be licensed LGPL at all. Think of some vendor specific highlighting files (like ASP) or similar. So our goal is to make the xml files are free as possible, without claiming too much copyright here (since we most likely don't have it). MIT is the simplest and most liberal one that is compatible with LGPL. And more on that, LGPL is not even unique, do you mean LGPLv2 only? or v2+v3? or v2 and any later version? This currently is a mess, and we would like to avoid this as much as possible, therefore we kindly ask to agree with MIT license. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7461 To: nibags, #kate, #framework_syntax_highlighting, dhaumann Cc: dhaumann, cullmann, #framework_syntax_highlighting, #frameworks, vkrause
D7461: Add syntax highlighting for AppArmor Profiles.
nibags updated this revision to Diff 18983. nibags added a comment. - Updated AppArmor syntax highlighting file: 1. Updating https://phabricator.kde.org/D7461: Add syntax highlighting for AppArmor Profiles. # Updated AppArmor syntax highlighting file. Hi! Sorry for the delay, I've been very busy the last few days. I made the changes you requested: - Hard color is removed. New highlighting styles are used. - Sample AppArmor profile is added for testing (including .ref, .fold & .html files). In addition, some fixes are made to the file. In the case of the license, I prefer to use LGPL. I don't know if there is any special reason to use MIT instead. Now I have more free time, so if you need to make more changes to the file, I'll respond faster. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7461?vs=18531=18983 BRANCH add-apparmor-syntax (branched from master) REVISION DETAIL https://phabricator.kde.org/D7461 AFFECTED FILES autotests/folding/usr.bin.apparmor-profile-test.fold autotests/html/usr.bin.apparmor-profile-test.html autotests/input/usr.bin.apparmor-profile-test autotests/reference/usr.bin.apparmor-profile-test.ref data/syntax/apparmor.xml To: nibags, #kate, #framework_syntax_hightlighting, dhaumann Cc: dhaumann, cullmann, #framework_syntax_hightlighting, #frameworks, vkrause
D7461: Add syntax highlighting for AppArmor Profiles.
nibags added a comment. OK, I'll correct it. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7461 To: nibags, #kate, #framework_syntax_hightlighting, dhaumann Cc: dhaumann, cullmann, #framework_syntax_hightlighting, #frameworks, vkrause
D7461: Add syntax highlighting for AppArmor Profiles.
dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. See Christoph's comments. And indeed, please remove all hard-coded colors. Also, please provide a test file that is preferrably licensed under MIT. INLINE COMMENTS > apparmor.xml:46 > + > + profile > + hat Please remove all spaces around keywords. I.e. profile without the two spaces. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7461 To: nibags, #kate, #framework_syntax_hightlighting, dhaumann Cc: dhaumann, cullmann, #framework_syntax_hightlighting, #frameworks, vkrause
D7461: Add syntax highlighting for AppArmor Profiles.
cullmann added a comment. Three things I see ATM: 1. Please no hard coded colors, are they really necessary? 2. I think we want some test file for it with reference in the autotests directory 3. If possible please MIT license REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7461 To: nibags, #kate, #framework_syntax_hightlighting Cc: cullmann, #framework_syntax_hightlighting, #frameworks, vkrause, dhaumann
D7461: Add syntax highlighting for AppArmor Profiles.
nibags added a reviewer: Framework: Syntax Hightlighting. nibags added a project: Framework: Syntax Hightlighting. nibags added a subscriber: Framework: Syntax Hightlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7461 To: nibags, #kate, #framework_syntax_hightlighting Cc: #framework_syntax_hightlighting, #frameworks, cullmann, vkrause, dhaumann
D7461: Add syntax highlighting for AppArmor Profiles.
nibags created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY AppArmor is a Linux security module that provides mandatory access control on Linux. The AppArmor Profiles are plain text files that contain access rules for the applications monitored by AppArmor. These are located in: /etc/apparmor.d/ More information: - http://wiki.apparmor.net - http://manpages.ubuntu.com/manpages/zesty/man5/apparmor.d.5.html This syntax highlighting file has the characteristic that has a different context for each type of AppArmor rule, so as to avoid conflicts between keywords with different uses and to provide a specific highlighting in each rule. The highlighting file is made for the latest version of AppArmor: 2.11. Note that by the end of this year (at the latest), AppArmor 4.0 will be released, so, at that time, I will need to update this syntax file with the new features. TEST PLAN This file was created in late February 2017 for personal use and I have been using it to create/edit AppArmor profiles during this time. Therefore, I can assure you that the highlighting file has been tested enough. REPOSITORY R216 Syntax Highlighting BRANCH add-apparmor-syntax (branched from master) REVISION DETAIL https://phabricator.kde.org/D7461 AFFECTED FILES data/syntax/apparmor.xml To: nibags, #kate Cc: #frameworks
