D7487: Make KCMultiDialog scrollable
ngraham added a comment. Restricted Application added a subscriber: kde-frameworks-devel. This has caused some pain with a number of KCMs, most notably plasma-nm and kscreen, but also others too (languages, shortcuts, powerdevil, activities). See all the duplicates of https://bugs.kde.org/show_bug.cgi?id=389585 It's especially noticeable for plasma-nm because the plasmoid gives you a button that opens the full KCM in `kcmshell5`, where it gets the wrong size and the controls on the bottom are not visible without scrolling. KScreen actually does set a sizeHint, but it doesn't seem to get passed on to the scroll area. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D7487 To: valeriymalov, #frameworks, davidedmundson Cc: kde-frameworks-devel, ngraham, davidedmundson, wbauer, broulik, michaelh, bruns
D7487: Make KCMultiDialog scrollable
valeriymalov created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Put KCModuleProxy into a QScrollArea the same way SystemSettings does This should make kcmshell and other users of KCMultiDialog a bit more friendly to small screens However, this assumes that KCMs don't have their own scrollbars (at least sytsemsettings ones don't) and preferably have a size hint (only a few or none actually have; at least kscreen needs patching) BUG: 303830 Also, reorder headers of the unit TEST PLAN doesn't break systemsettings/kcmshell/kmail settings kcmshell kscreen takes some time initializing so it starts very small (patch ready) REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D7487 AFFECTED FILES src/kcmultidialog.cpp To: valeriymalov, #frameworks
D7487: Make KCMultiDialog scrollable
broulik added a comment. +1 but re-arrange the includes in a separate commit as it's not really related to this. System Settings has its own scroll bars anyway, so I think no KCM adds them on its own. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D7487 To: valeriymalov, #frameworks Cc: broulik
D7487: Make KCMultiDialog scrollable
valeriymalov updated this revision to Diff 18616. valeriymalov added a comment. Split commit in two (hopefully) REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7487?vs=18604&id=18616 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7487 AFFECTED FILES src/kcmultidialog.cpp To: valeriymalov, #frameworks Cc: broulik
D7487: Make KCMultiDialog scrollable
wbauer added a comment. The referenced bug number seems to be wrong. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D7487 To: valeriymalov, #frameworks Cc: wbauer, broulik
D7487: Make KCMultiDialog scrollable
valeriymalov updated this revision to Diff 18774. valeriymalov edited the summary of this revision. valeriymalov added a comment. Oops, should be fixed now REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7487?vs=18616&id=18774 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7487 AFFECTED FILES src/kcmultidialog.cpp To: valeriymalov, #frameworks Cc: wbauer, broulik
D7487: Make KCMultiDialog scrollable
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. For some reason "kcmshell5 kscreen" looks awful. It comes up tiny. Most the rest seem OK (I checked ~15) . There must be something very specific about that one. If you could take a look that would be great. As the next frameworks release is so soon, I'd like to see this wait until after 5.38 is tagged before merging, just to give us time to find if there are any other issues. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D7487 To: valeriymalov, #frameworks, davidedmundson Cc: davidedmundson, wbauer, broulik
D7487: Make KCMultiDialog scrollable
valeriymalov added a comment. In https://phabricator.kde.org/D7487#141996, @davidedmundson wrote: > For some reason "kcmshell5 kscreen" looks awful. It comes up tiny. This seems to be caused by the way KScreen's KCM is initialized, probably because of QML? Window content seems to load a split second after the window actually comes up. Setting sizeHint for KCMKScreen circumvents this, although I'm not sure if that's the correct way to fix this. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D7487 To: valeriymalov, #frameworks, davidedmundson Cc: davidedmundson, wbauer, broulik
D7487: Make KCMultiDialog scrollable
aacid closed this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D7487 To: valeriymalov, #frameworks, davidedmundson Cc: davidedmundson, wbauer, broulik
