D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData
bshah added a comment. In https://phabricator.kde.org/D7533#140680, @dfaure wrote: > Ah, phabricator is strange, I have indeed modified the commit log before doing `arc diff` but it didn't update it here. And it also did overwrite your change in actual commit message it seems *shrug* REVISION DETAIL https://phabricator.kde.org/D7533 To: dfaure, apol, davidedmundson, arichardson, bshah Cc: vandenoever, elvisangelaccio, bshah, #frameworks
D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData
dfaure closed this revision. REVISION DETAIL https://phabricator.kde.org/D7533 To: dfaure, apol, davidedmundson, arichardson, bshah Cc: vandenoever, elvisangelaccio, bshah, #frameworks
D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData
dfaure added a comment. Ah, phabricator is strange, I have indeed modified the commit log before doing `arc diff` but it didn't update it here. BRANCH master REVISION DETAIL https://phabricator.kde.org/D7533 To: dfaure, apol, davidedmundson, arichardson, bshah Cc: vandenoever, elvisangelaccio, bshah, #frameworks
D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData
bshah accepted this revision. bshah added a comment. This revision is now accepted and ready to land. Looks good to me. (Maybe modify the commit message to remove the priority int/string bits) BRANCH master REVISION DETAIL https://phabricator.kde.org/D7533 To: dfaure, apol, davidedmundson, arichardson, bshah Cc: vandenoever, elvisangelaccio, bshah, #frameworks
D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData
dfaure updated this revision to Diff 18829. dfaure added a comment. Provide servicetype file to the cmake macro so that the priority is stored as an int. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7533?vs=18731=18829 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7533 AFFECTED FILES src/urifilters/fixhost/CMakeLists.txt src/urifilters/fixhost/fixhosturifilter.cpp src/urifilters/fixhost/fixhosturifilter.desktop src/urifilters/fixhost/fixhosturifilter.h src/urifilters/fixhost/fixhosturifilter.json src/urifilters/ikws/CMakeLists.txt src/urifilters/ikws/kuriikwsfilter.cpp src/urifilters/ikws/kuriikwsfilter.desktop src/urifilters/ikws/kuriikwsfilter.json src/urifilters/ikws/kurisearchfilter.cpp src/urifilters/ikws/kurisearchfilter.desktop src/urifilters/ikws/kurisearchfilter.json src/urifilters/localdomain/CMakeLists.txt src/urifilters/localdomain/localdomainurifilter.cpp src/urifilters/localdomain/localdomainurifilter.desktop src/urifilters/localdomain/localdomainurifilter.json src/urifilters/shorturi/CMakeLists.txt src/urifilters/shorturi/kshorturifilter.cpp src/urifilters/shorturi/kshorturifilter.desktop src/urifilters/shorturi/kshorturifilter.json src/widgets/kurifilter.cpp src/widgets/kurifilterplugin.desktop To: dfaure, apol, davidedmundson, arichardson Cc: vandenoever, elvisangelaccio, bshah, #frameworks
D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData
vandenoever added a comment. > "X-KDE-InitialPreference": "5" is a string "X-KDE-InitialPreference": 5 is a number REVISION DETAIL https://phabricator.kde.org/D7533 To: dfaure, apol, davidedmundson, arichardson Cc: vandenoever, elvisangelaccio, bshah, #frameworks
D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData
elvisangelaccio added inline comments. INLINE COMMENTS > kurifilter.cpp:682-684 > // NOTE: Plugin priority is determined by the InitialPreference entry in > // the .desktop files, so the trader result is already sorted and should > // not be manually sorted. This comment looks outdated now, should probably be removed? REVISION DETAIL https://phabricator.kde.org/D7533 To: dfaure, apol, davidedmundson, arichardson Cc: elvisangelaccio, bshah, #frameworks
D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData
bshah added a comment. > One thing I don't understand is the need for toString().toInt(), > or in other words, why my json file with a numeric value gets turned > into a string value when using qtplugininfo to inspect the plugin: Maybe you need to add following in the `src/widgets/kurifilterplugin.desktop` [PropertyDef::X-KDE-InitialPreference] Type=int REVISION DETAIL https://phabricator.kde.org/D7533 To: dfaure, apol, davidedmundson, arichardson Cc: bshah, #frameworks
D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData
dfaure created this revision.
REVISION SUMMARY
This makes it possible to run the unittest without installing the
plugins first.
One thing I don't understand is the need for toString().toInt(),
or in other words, why my json file with a numeric value gets turned
into a string value when using qtplugininfo to inspect the plugin:
User Data: {
"X-KDE-InitialPreference": "5"
}
TEST PLAN
make uninstall; bin/jobtest
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7533
AFFECTED FILES
src/urifilters/fixhost/CMakeLists.txt
src/urifilters/fixhost/fixhosturifilter.cpp
src/urifilters/fixhost/fixhosturifilter.desktop
src/urifilters/fixhost/fixhosturifilter.h
src/urifilters/fixhost/fixhosturifilter.json
src/urifilters/ikws/CMakeLists.txt
src/urifilters/ikws/kuriikwsfilter.cpp
src/urifilters/ikws/kuriikwsfilter.desktop
src/urifilters/ikws/kuriikwsfilter.json
src/urifilters/ikws/kurisearchfilter.cpp
src/urifilters/ikws/kurisearchfilter.desktop
src/urifilters/ikws/kurisearchfilter.json
src/urifilters/localdomain/CMakeLists.txt
src/urifilters/localdomain/localdomainurifilter.cpp
src/urifilters/localdomain/localdomainurifilter.desktop
src/urifilters/localdomain/localdomainurifilter.json
src/urifilters/shorturi/CMakeLists.txt
src/urifilters/shorturi/kshorturifilter.cpp
src/urifilters/shorturi/kshorturifilter.desktop
src/urifilters/shorturi/kshorturifilter.json
src/widgets/kurifilter.cpp
To: dfaure, apol, davidedmundson, arichardson
Cc: #frameworks
