D7864: Basic support for PHP and Python fenced code blocks in Markdown

2018-02-25 Thread Volker Krause 
vkrause added a comment.


  In D7864#213006 , @dhaumann wrote:
  
  > @vkrause Do you already have something in mind, when you say this does not 
scale? ...
  
  
  No concrete ideas yet, but mainly two observations:
  
  - when nesting a language you need to implement detecting the end of that 
code manually each time
  - you need to explicitly list all languages you want to nest, one by one
  
  The latter is ok if there is a limited amount of languages that can be nested 
in this context, but in case of markdown it's in theory every language we have.
  So a rule like `` to do all the repeating work inside the engine might 
be interesting. We'd need to survey all current usages of nesting to see if 
that covers enough use-cases though, I haven't done that yet.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D7864

To: gszymaszek, #framework_syntax_highlighting, vkrause
Cc: cullmann, dhaumann, cfeck, kwrite-devel, #frameworks, michaelh, kmorwinski

D7864: Basic support for PHP and Python fenced code blocks in Markdown

2018-02-24 Thread Dominik Haumann 
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:4f7e020e332d: Basic support for PHP and Python fenced 
code blocks in Markdown (authored by dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7864?vs=19631=27961

REVISION DETAIL
  https://phabricator.kde.org/D7864

AFFECTED FILES
  autotests/folding/example.rmd.fold
  autotests/folding/test.markdown.fold
  autotests/html/test.markdown.html
  autotests/input/test.markdown
  autotests/reference/test.markdown.ref
  data/syntax/markdown.xml

To: gszymaszek, #framework_syntax_highlighting, vkrause
Cc: cullmann, dhaumann, cfeck, kwrite-devel, #frameworks, michaelh, kmorwinski

D7864: Basic support for PHP and Python fenced code blocks in Markdown

2018-02-24 Thread Dominik Haumann 
dhaumann added a comment.


  @vkrause Do you already have something in mind, when you say this does not 
scale? ...

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  markdown-code-blocks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D7864

To: gszymaszek, #framework_syntax_highlighting, vkrause
Cc: cullmann, dhaumann, cfeck, kwrite-devel, #frameworks, michaelh, kmorwinski

D7864: Basic support for PHP and Python fenced code blocks in Markdown

2018-02-06 Thread Volker Krause 
vkrause accepted this revision.
vkrause added a comment.
This revision is now accepted and ready to land.


  Fine with me. 
  The approach doesn't scale though, so maybe we need to look into  better 
support for this kind of syntax nesting if we want this for many more languages 
here (similar problems exist in other nest-able languages too).

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  markdown-code-blocks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D7864

To: gszymaszek, #framework_syntax_highlighting, vkrause
Cc: cullmann, dhaumann, cfeck, kwrite-devel, #frameworks, michaelh, ngraham

D7864: Basic support for PHP and Python fenced code blocks in Markdown

2018-02-05 Thread Dominik Haumann 
dhaumann added a comment.


  This fixes bug https://bugs.kde.org/show_bug.cgi?id=389307 at least 
partially. More languages such as Ruby etc can still be added.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D7864

To: gszymaszek, #framework_syntax_highlighting, vkrause
Cc: cullmann, dhaumann, cfeck, kwrite-devel, #frameworks, michaelh, ngraham

D7864: Basic support for PHP and Python fenced code blocks in Markdown

2018-02-05 Thread Christoph Cullmann 
cullmann edited reviewers, added: Framework: Syntax Highlighting, vkrause; 
removed: KTextEditor.
cullmann added a comment.


  +1, Volker, ok to go in?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D7864

To: gszymaszek, #framework_syntax_highlighting, vkrause
Cc: cullmann, dhaumann, cfeck, kwrite-devel, #frameworks, michaelh, ngraham

D7864: Basic support for PHP and Python fenced code blocks in Markdown

2017-09-18 Thread Grzegorz Szymaszek 
gszymaszek updated this revision to Diff 19631.
gszymaszek added a comment.


  - Removed JavaScript code blocks in Markdown support since it didn’t work
  - Added test cases for new code blocks in Markdown

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7864?vs=19622=19631

BRANCH
  markdown-code-blocks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D7864

AFFECTED FILES
  autotests/folding/example.rmd.fold
  autotests/folding/test.markdown.fold
  autotests/html/test.markdown.html
  autotests/input/test.markdown
  autotests/reference/test.markdown.ref
  data/syntax/markdown.xml

To: gszymaszek, #ktexteditor
Cc: dhaumann, cfeck, kwrite-devel, #frameworks

D7864: Basic support for PHP and Python fenced code blocks in Markdown

2017-09-18 Thread Dominik Haumann 
dhaumann added a comment.


  Could you also extend the test case in
  
https://github.com/KDE/syntax-highlighting/blob/master/autotests/input/test.markdown
  
  This way, we can automatically guarantee that we will not break this feature 
accidentally.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D7864

To: gszymaszek, #ktexteditor
Cc: dhaumann, cfeck, kwrite-devel, #frameworks

D7864: Basic support for PHP and Python fenced code blocks in Markdown

2017-09-17 Thread Grzegorz Szymaszek 
gszymaszek added a subscriber: cfeck.
gszymaszek added a comment.


  Not ready to land, but uploaded per @cfeck’s suggestion (bug 356974 
).

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D7864

To: gszymaszek, #ktexteditor
Cc: cfeck, kwrite-devel, #frameworks

D7864: Basic support for PHP and Python fenced code blocks in Markdown

2017-09-17 Thread Grzegorz Szymaszek 
gszymaszek created this revision.
gszymaszek added a reviewer: KTextEditor.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  This patch enables syntax highlighting of PHP and Python code blocks in 
Markdown code.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  markdown-code-blocks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D7864

AFFECTED FILES
  data/syntax/markdown.xml

To: gszymaszek, #ktexteditor
Cc: kwrite-devel, #frameworks