D7926: Remove pf.path() from container before the reference got screwed up by it.remove()

2017-09-23 Thread Christian Ehrlicher 
chehrlic closed this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D7926

To: chehrlic, broulik
Cc: #frameworks

D7926: Remove pf.path() from container before the reference got screwed up by it.remove()

2017-09-21 Thread Kai Uwe Broulik 
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  fix_crash_pendingfilequeue

REVISION DETAIL
  https://phabricator.kde.org/D7926

To: chehrlic, broulik
Cc: #frameworks

D7926: Remove pf.path() from container before the reference got screwed up by it.remove()

2017-09-21 Thread Christian Ehrlicher 
chehrlic created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  With 
https://phabricator.kde.org/R293:a75db7aedfcd356b027774e0dc156c334d4cb869 I 
introduced a crash when removing a watched
  directory. The Problem is that it.remove() invalidates the reference to 
PendingFile which
  leads to a crash... :(
  I found no bugreport about this on bugs.kde.org until now.

TEST PLAN
  Remove a directory, baloo should never crash when removing a watched directory

REPOSITORY
  R293 Baloo

BRANCH
  fix_crash_pendingfilequeue

REVISION DETAIL
  https://phabricator.kde.org/D7926

AFFECTED FILES
  src/file/pendingfilequeue.cpp

To: chehrlic
Cc: #frameworks