D7944: Pre-select navigation bar URL when clicking on it to enter edit mode
ngraham abandoned this revision. ngraham added a comment. Fair enough. Your points are stronger than mine, now that I think about it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7944 To: ngraham, #kde_applications, #frameworks, broulik, dfaure Cc: elvisangelaccio, #frameworks
D7944: Pre-select navigation bar URL when clicking on it to enter edit mode
elvisangelaccio added a comment. In https://phabricator.kde.org/D7944#148134, @ngraham wrote: > You're right that this improves one workflow and impairs another, but the way I see it, the patch simply brings consistency with the behavior you get if you hit ctrl-L/Replace Location. I don't know, it looks already consistent to me: - CTRL+L is the shortcut for the "Replace Location" action, so it makes sense to pre-select the URL in this case. - The tooltip of KUrlNavigator says: "Click to Edit Location", and "Edit" does not necessarily imply "Replace" REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7944 To: ngraham, #kde_applications, #frameworks, broulik, dfaure Cc: elvisangelaccio, #frameworks
D7944: Pre-select navigation bar URL when clicking on it to enter edit mode
ngraham added a comment. Opps, I've corrected the bug number. You're right that this improves one workflow and impairs another, but the way I see it, the patch simply brings consistency with the behavior you get if you hit ctrl-L/Replace Location. Though you're right that it also takes us out of sync with Firefox, in which ctrl-L selects the whole path, but clicking on the URL bar doesn't. Hmm. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7944 To: ngraham, #kde_applications, #frameworks, broulik, dfaure Cc: elvisangelaccio, #frameworks
D7944: Pre-select navigation bar URL when clicking on it to enter edit mode
ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7944 To: ngraham, #kde_applications, #frameworks, broulik, dfaure Cc: elvisangelaccio, #frameworks
D7944: Pre-select navigation bar URL when clicking on it to enter edit mode
elvisangelaccio added a comment. The linked bug looks wrong. I'm not sure I agree with this change. We save a click if we want to go from `/home/foo` to e.g. `/usr`, but we add an additional click if we just want to append something to `/home/foo`. I do this all the time (to go in the hidden folders in my home). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7944 To: ngraham, #kde_applications, #frameworks, broulik, dfaure Cc: elvisangelaccio, #frameworks
D7944: Pre-select navigation bar URL when clicking on it to enter edit mode
ngraham added reviewers: KDE Applications, Frameworks, broulik, dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7944 To: ngraham, #kde_applications, #frameworks, broulik, dfaure Cc: #frameworks
D7944: Pre-select navigation bar URL when clicking on it to enter edit mode
ngraham created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY BUG: 333219 When the user clicks on a non-editable navigation bar to enter edit mode, always pre-select the URL. We mimic the behavior of web browsers here, since this is the same UI element. TEST PLAN Tested in KDE Neon. Clicking on the URL bar in Dolphin and file picker dialogs pre-selects the text. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D7944 AFFECTED FILES src/filewidgets/kurlnavigator.cpp To: ngraham Cc: #frameworks
