D8064: Correct installation of start_kdeinit when DESTDIR and libcap are used together

2017-10-12 Thread Martin Flöser 
This revision was automatically updated to reflect the committed changes.
Closed by commit R303:b82ea5b8d7b3: Correct installation of start_kdeinit when 
DESTDIR and libcap are used together (authored by graesslin).

REPOSITORY
  R303 KInit

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8064?vs=20619&id=20654

REVISION DETAIL
  https://phabricator.kde.org/D8064

AFFECTED FILES
  src/start_kdeinit/CMakeLists.txt

To: awilcox, dfaure
Cc: graesslin, #frameworks

D8064: Correct installation of start_kdeinit when DESTDIR and libcap are used together

2017-10-11 Thread A . Wilcox 
awilcox updated this revision to Diff 20619.
awilcox added a comment.


  This diff was created with  `git diff`.

REPOSITORY
  R303 KInit

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8064?vs=20125&id=20619

REVISION DETAIL
  https://phabricator.kde.org/D8064

AFFECTED FILES
  src/start_kdeinit/CMakeLists.txt

To: awilcox, dfaure
Cc: graesslin, #frameworks

D8064: Correct installation of start_kdeinit when DESTDIR and libcap are used together

2017-10-10 Thread Martin Flöser 
graesslin added a comment.


  Do you have commit rights or should someone else push the patch? If the 
latter could you please upload a patch as a git formatted patch? I just tried 
to import this one and it fails due to no CMakeLists.txt.old in the repo.

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D8064

To: awilcox, dfaure
Cc: graesslin, #frameworks

D8064: Correct installation of start_kdeinit when DESTDIR and libcap are used together

2017-10-07 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Strange syntax... but since you tested it ;-)

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D8064

To: awilcox, dfaure
Cc: #frameworks

D8064: Correct installation of start_kdeinit when DESTDIR and libcap are used together

2017-09-30 Thread Elvis Angelaccio 
elvisangelaccio added a reviewer: dfaure.

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D8064

To: awilcox, dfaure
Cc: #frameworks

D8064: Correct installation of start_kdeinit when DESTDIR and libcap are used together

2017-09-29 Thread A . Wilcox 
awilcox created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  While packaging kinit 5.38.0 for Adélie, I ran in to the following error:
  
-- Installing: 
/usr/src/packages/user/kinit/pkg/kinit/usr/lib/libexec/kf5/start_kdeinit
Failed to set capabilities on file `/usr/lib/libexec/kf5/start_kdeinit' (No 
such file or directory)
usage: setcap [-q] [-v] (-r|-|)  [ ... (-r|-|) 
 ]

 Note  must be a regular (non-symlink) file.
  
  This was caused by a missing escape in the CMake instruction to run setcap.  
I have verified that this patch also applies cleanly to master.

TEST PLAN
  - Build with and without libcap, with and without `DESTDIR` set.

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D8064

AFFECTED FILES
  kinit-5.38.0/src/start_kdeinit/CMakeLists.txt

To: awilcox
Cc: #frameworks