D8296: Use Alt+, as the standard shortcut for "Configure "
ngraham edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks
D8296: Use Alt+, as the standard shortcut for "Configure "
ngraham added a comment. Just checked: It's already there in Standard Shortcuts, where it can be changed. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks
D8296: Use Alt+, as the standard shortcut for "Configure "
ngraham planned changes to this revision. ngraham added a comment. Oh, great idea. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks
D8296: Use Alt+, as the standard shortcut for "Configure "
abetts added a comment. Could this also be added to global shortcuts if it is not there already? That the user can define the keys to use for Preferences? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: abetts, elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks
D8296: Use Alt+, as the standard shortcut for "Configure "
ngraham added a comment. Thanks for your comments, @rkflx. I have no strong opinions on what the shortcut should be. Side note: if KMail and Kontact don't get this change automatically, that's a sign that they're not using `KStandardAction::Preferences()` and should be. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks
D8296: Use Alt+, as the standard shortcut for "Configure "
rkflx added a comment.
Since @ngraham added me as reviewer, here are my 2 cents. Trying the patch, I
made those observations:
- [Alt] often is released by the user only after the dialog is shown already,
resulting in the (normally hidden) accelerators ("_") of the dialog showing and
then dissappearing, which looks odd.
- Normally [Alt] is used either for accessing the menu itself or in
combination with the cursor/navigation keys, but not so much for shortcuts.
While there are exceptions, at least our shortcuts for executing standard
actions affecting all apps should IMHO stick to [Ctrl].
- Does not work in Kontact and KMail (but does work in KOrganizer and KMail's
"New Mail" window).
Note I don't oppose the idea to have a universal shortcut for opening the
preferences, but I feel that with the currently selected shortcut the net
effect to the overall user experience and consistency is slightly negative.
I won't block this patch, but instead let me add this ideas:
- The patch is not really urgent. Do we have the chance to gather some
telemetry data on the usage of shortcuts as well as on the preferences dialog?
That way we could better evaluate the usefulness and maybe even choose
non-conflicting shortcuts.
- Apply the change only via a shortcut theme package for Mac refugees (not
sure if can we have such a thing?)
- If we change it at all, this should get in very early in the cycle to judge
how much this conflicts with custom shortcuts users have.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik,
#frameworks
D8296: Use Alt+, as the standard shortcut for "Configure "
ngraham marked an inline comment as done. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks
D8296: Use Alt+, as the standard shortcut for "Configure "
ngraham updated this revision to Diff 21142. ngraham added a comment. Use syntax that's consistent with the rest of the file REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8296?vs=20839&id=21142 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8296 AFFECTED FILES src/gui/kstandardshortcut.cpp To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks
D8296: Use Alt+, as the standard shortcut for "Configure "
elvisangelaccio added inline comments.
INLINE COMMENTS
> kstandardshortcut.cpp:159
> { KeyBindings, "KeyBindings", QT_TRANSLATE_NOOP3("KStandardShortcut",
> "Key Bindings", "@action"), 0, 0, QList(), false },
> -{ Preferences, "Preferences", QT_TRANSLATE_NOOP3("KStandardShortcut",
> "Preferences", "@action"), 0, 0, QList(), false },
> +{ Preferences, "Preferences", QT_TRANSLATE_NOOP3("KStandardShortcut",
> "Preferences", "@action"), Qt::ALT + Qt::Key_Comma, 0, QList(),
> false },
> { ConfigureToolbars, "ConfigureToolbars",
> QT_TRANSLATE_NOOP3("KStandardShortcut", "Configure Toolbars", "@action"), 0,
> 0, QList(), false },
I'd use `ALT(Comma)` here, for consistency with the other shortcuts.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D8296
To: ngraham, #frameworks, #vdg, broulik, rkflx
Cc: elvisangelaccio, aacid, argonel, kfunk, marten, graesslin, broulik,
#frameworks
D8296: Use Alt+, as the standard shortcut for "Configure "
ngraham added reviewers: broulik, rkflx. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks
D8296: Use Alt+, as the standard shortcut for "Configure "
ngraham added a comment. If there are no objections, can someone grudgingly mark it as approved? ;-) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks
D8296: Use Alt+, as the standard shortcut for "Configure "
ngraham added a comment. Any objections to Alt+, ? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks
D8296: Use Alt+, as the standard shortcut for "Configure "
ngraham added a comment. Alt+, is definitely better, yeah. Also, now we are actually preserving recovering Mac users' muscle memory, since the Alt key on a PC keyboard is in the same place as the Command key on a Mac keyboard. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks
D8296: Use Alt+, as the standard shortcut for "Configure "
ngraham retitled this revision from "Use Ctrl+Alt+, as the standard shortcut for "Configure "" to "Use Alt+, as the standard shortcut for "Configure "". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks
