D8311: Require the same internal version as you're building

2017-12-18 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:e33d06f9857a: Require the same internal version as 
youre building (authored by leinir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8311?vs=20791=24076

REVISION DETAIL
  https://phabricator.kde.org/D8311

AFFECTED FILES
  KF5NewStuffConfig.cmake.in
  KF5NewStuffQuickConfig.cmake.in

To: leinir, #knewstuff, dfaure
Cc: dfaure, #frameworks, ZrenBot


D8311: Require the same internal version as you're building

2017-12-02 Thread David Faure
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Fun indeed.
  
  Hmm I see the same issue in at least kdelibs4support, I'll go fix it.
  
  Anyone wants to write a small script to check this? ;)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D8311

To: leinir, #knewstuff, dfaure
Cc: dfaure, #frameworks, ZrenBot


D8311: Require the same internal version as you're building

2017-10-15 Thread Dan Leinir Turthra Jensen
leinir created this revision.
leinir added a reviewer: KNewStuff.
leinir added a project: KNewStuff.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Previously the KNewStuff sub-frameworks would require the dependency 
frameworks version of itself, rather than the version being built, which caused 
fun little issues.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D8311

AFFECTED FILES
  KF5NewStuffConfig.cmake.in
  KF5NewStuffQuickConfig.cmake.in

To: leinir, #knewstuff
Cc: #frameworks, ZrenBot