D8437: KWidgetsAddons : more compact password dialog

2017-10-27 Thread René J . V . Bertin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:9afc2c3768e0: more compact password dialog (authored by 
rjvbb).

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8437?vs=21340=21445

REVISION DETAIL
  https://phabricator.kde.org/D8437

AFFECTED FILES
  src/kpassworddialog.ui

To: rjvbb, #frameworks, kfunk, ngraham
Cc: cfeck, ngraham

D8437: KWidgetsAddons : more compact password dialog

2017-10-27 Thread Nathaniel Graham 
ngraham added a comment.


  Go ahead and land this, @rjvbb! Nice work.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8437

To: rjvbb, #frameworks, kfunk, ngraham
Cc: cfeck, ngraham

D8437: KWidgetsAddons : more compact password dialog

2017-10-27 Thread Kevin Funk 
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.


  Looks like it :)

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8437

To: rjvbb, #frameworks, kfunk, ngraham
Cc: cfeck, ngraham

D8437: KWidgetsAddons : more compact password dialog

2017-10-26 Thread Nathaniel Graham 
ngraham added a comment.


  @kfunk, all good now?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8437

To: rjvbb, #frameworks, kfunk, ngraham
Cc: cfeck, ngraham

D8437: KWidgetsAddons : more compact password dialog

2017-10-25 Thread Nathaniel Graham 
ngraham accepted this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8437

To: rjvbb, #frameworks, kfunk, ngraham
Cc: cfeck, ngraham

D8437: KWidgetsAddons : more compact password dialog

2017-10-25 Thread René J . V . Bertin 
rjvbb edited the summary of this revision.
rjvbb edited the test plan for this revision.
rjvbb set the repository for this revision to R236 KWidgetsAddons.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8437

To: rjvbb, #frameworks, kfunk
Cc: cfeck, ngraham

D8437: KWidgetsAddons : more compact password dialog

2017-10-25 Thread René J . V . Bertin 
rjvbb updated this revision to Diff 21340.
rjvbb added a comment.


  patch cleaned up as requested.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8437?vs=21188=21340

REVISION DETAIL
  https://phabricator.kde.org/D8437

AFFECTED FILES
  src/kpassworddialog.ui

To: rjvbb, #frameworks, kfunk
Cc: cfeck, ngraham

D8437: KWidgetsAddons : more compact password dialog

2017-10-24 Thread Kevin Funk 
kfunk requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8437

To: rjvbb, #frameworks, kfunk
Cc: cfeck, ngraham

D8437: KWidgetsAddons : more compact password dialog

2017-10-24 Thread Nathaniel Graham 
ngraham added a comment.


  Couple more changes, if you please:
  
  - Add the before-and-after screenshots to the Test Plan section so everyone 
who comes here sees them
  - Add "BUG: 381231" on its own line in the Summary section, which will make 
that bug get automatically closed once this is landed.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8437

To: rjvbb, #frameworks
Cc: cfeck, ngraham

D8437: KWidgetsAddons : more compact password dialog

2017-10-24 Thread Nathaniel Graham 
ngraham added a comment.


  Yeah, could you remove that and any other uynnecessary lines, so we have the 
bare minimum set of changes necessary to improve this?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8437

To: rjvbb, #frameworks
Cc: cfeck, ngraham

D8437: KWidgetsAddons : more compact password dialog

2017-10-23 Thread René J . V . Bertin 
rjvbb added a comment.


  > Is this change intended?
  
  I doubt that (it's been a while). Probably something Designer added, and I 
can't imagine it would have an impact on packing. I'll check.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8437

To: rjvbb, #frameworks
Cc: cfeck, ngraham

D8437: KWidgetsAddons : more compact password dialog

2017-10-23 Thread Christoph Feck 
cfeck added inline comments.

INLINE COMMENTS

> kpassworddialog.ui:137
> +
> + true
> +

Is this change intended?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8437

To: rjvbb, #frameworks
Cc: cfeck, ngraham

D8437: KWidgetsAddons : more compact password dialog

2017-10-23 Thread Nathaniel Graham 
ngraham added a comment.


  Fantastic. Can you add the following onto its own line in the Summary section?
  
  "BUG: 381231"
  
  That will cause that bug to get automatically closed once this is merged.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8437

To: rjvbb, #frameworks
Cc: ngraham

D8437: KWidgetsAddons : more compact password dialog

2017-10-23 Thread René J . V . Bertin 
rjvbb added a comment.


  Screenshots attached to the bug report I filed about this 
(https://bugs.kde.org/show_bug.cgi?id=381231):
  
  Before:
  F5445829: kwallet-pw-dialog.png 
  
  After (packed):
  F5445832: kwallet-pw-dialog-packed.png 

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8437

To: rjvbb, #frameworks

D8437: KWidgetsAddons : more compact password dialog

2017-10-23 Thread René J . V . Bertin 
rjvbb created this revision.
rjvbb added a reviewer: Frameworks.
rjvbb added a project: Frameworks.

REVISION SUMMARY
  When kwalletd4 was replaced by kwalletd5 I quickly got annoyed by the so much 
and unnecessarily larger password dialog. This patch addresses that issues, 
maing the dialog comparably compact as it was under KDE4.

TEST PLAN
  I've been using this patch since before summer, on Mac and Linux. I never 
encountered a password dialog that became unusable or looked wrong.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8437

AFFECTED FILES
  src/kpassworddialog.ui

To: rjvbb, #frameworks