D8445: [PlasmaComponents Menu] Add ungrabMouseHack

2017-10-25 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:c52a6c574869: [PlasmaComponents Menu] Add ungrabMouseHack 
(authored by broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8445?vs=21232=21305

REVISION DETAIL
  https://phabricator.kde.org/D8445

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qmenu.cpp
  src/declarativeimports/plasmacomponents/qmenu.h

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8445: [PlasmaComponents Menu] Add ungrabMouseHack

2017-10-24 Thread David Edmundson 
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  I was under the impression this hack was only needed when used on a window 
that doesn't take focus. 
  
(https://bugreports.qt.io/browse/QTBUG-59044?focusedCommentId=354424=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-354424)
  
  The popup should, so it doesn't match my findings in the qtbug you're linking 
to.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D8445

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8445: [PlasmaComponents Menu] Add ungrabMouseHack

2017-10-24 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Ensures the PlasmaComponents.Menu doesn't confuse MouseArea states.

TEST PLAN
  Put a ContextMenu into NotificationPopup, opened it, selected an item, and 
the MouseArea knew it wasn't pressed anymore. Before it got confused.
  Also played around in Kickoff and Task Manager and didn't notice anything 
suspicious

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D8445

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qmenu.cpp
  src/declarativeimports/plasmacomponents/qmenu.h

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart