D8638: Remove DataModel::roleNameToId

2017-11-06 Thread Kai Uwe Broulik 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:d51456bdfcbd: Remove DataModel::roleNameToId (authored by 
broulik).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8638?vs=21831&id=21965

REVISION DETAIL
  https://phabricator.kde.org/D8638

AFFECTED FILES
  src/declarativeimports/core/datamodel.cpp
  src/declarativeimports/core/datamodel.h

To: broulik, #plasma, mwolff
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8638: Remove DataModel::roleNameToId

2017-11-03 Thread Milian Wolff 
mwolff accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D8638

To: broulik, #plasma, mwolff
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8638: Remove DataModel::roleNameToId

2017-11-03 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  It is unused and returned `-1` whereas `SortFilterModel` would return 
`Qt::DisplayRole`

TEST PLAN
  This class is not exported but only part of the corebindingsplugin so this 
method can be removed

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D8638

AFFECTED FILES
  src/declarativeimports/core/datamodel.cpp
  src/declarativeimports/core/datamodel.h

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart