D8710: Fix VI-Mode buffer commands

2017-11-12 Thread Christoph Roick 
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:62e4c17cbc79: Fix VI-Mode buffer commands (authored by 
croick).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8710?vs=22057=22239

REVISION DETAIL
  https://phabricator.kde.org/D8710

AFFECTED FILES
  src/vimode/appcommands.cpp
  src/vimode/appcommands.h
  src/vimode/emulatedcommandbar/commandmode.cpp

To: croick, #ktexteditor, cullmann
Cc: cullmann, #frameworks, kevinapavew, ngraham, demsking, sars, dhaumann

D8710: Fix VI-Mode buffer commands

2017-11-12 Thread Christoph Roick 
croick added a comment.


  In https://phabricator.kde.org/D8710#166793, @cullmann wrote:
  
  > The single shots are not that nice, but I understand that they are 
necessary to defer the action.
  
  
  At first I changed the invokeMethod arguments in utils/application.cpp to 
Qt::QueuedConnection. But then the return values would be meaningless and might 
actually cause more problems.

REPOSITORY
  R39 KTextEditor

BRANCH
  viedit

REVISION DETAIL
  https://phabricator.kde.org/D8710

To: croick, #ktexteditor, cullmann
Cc: cullmann, #frameworks, kevinapavew, ngraham, demsking, sars, dhaumann

D8710: Fix VI-Mode buffer commands

2017-11-12 Thread Christoph Cullmann 
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  The single shots are not that nice, but I understand that they are necessary 
to defer the action.
  Feel free to commit.

REPOSITORY
  R39 KTextEditor

BRANCH
  viedit

REVISION DETAIL
  https://phabricator.kde.org/D8710

To: croick, #ktexteditor, cullmann
Cc: cullmann, #frameworks, kevinapavew, ngraham, demsking, sars, dhaumann

D8710: Fix VI-Mode buffer commands

2017-11-07 Thread Christoph Roick 
croick created this revision.
croick added a reviewer: KTextEditor.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  - :tabclose currently makes kate crash.
  - Switching tabs with commands like :bp or :tabp only works once due to loss 
of focus. The user must click into the view to reactivate it.
  - Fix crash when switching documents with :b filename

TEST PLAN
  - use :tabclose to close a document
  - switch documents several times with :bp, :tabn, etc.
  - use :b filename to switch to corresponding tab

REPOSITORY
  R39 KTextEditor

BRANCH
  viedit

REVISION DETAIL
  https://phabricator.kde.org/D8710

AFFECTED FILES
  src/vimode/appcommands.cpp
  src/vimode/appcommands.h
  src/vimode/emulatedcommandbar/commandmode.cpp

To: croick, #ktexteditor
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann