D8809: Reduce spurious signal emissions
This revision was automatically updated to reflect the committed changes. Closed by commit R242:11c9206bf68f: Reduce spurious signal emissions (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8809?vs=22304&id=22465 REVISION DETAIL https://phabricator.kde.org/D8809 AFFECTED FILES src/declarativeimports/core/framesvgitem.cpp src/declarativeimports/core/framesvgitem.h src/plasma/framesvg.cpp To: apol, #plasma, davidedmundson Cc: broulik, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8809: Reduce spurious signal emissions
apol added inline comments. INLINE COMMENTS > davidedmundson wrote in framesvgitem.cpp:295 > If we always have 4 and can initialised them to 0 qreal[4] with a c style > array would be better. Would it? it's harder to compare then as you can't do a simple `!=` REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D8809 To: apol, #plasma, davidedmundson Cc: broulik, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8809: Reduce spurious signal emissions
davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > framesvgitem.cpp:295 > + > +const QVector m_oldMargins; > +FrameSvgItemMargins *const m_margins; If we always have 4 and can initialised them to 0 qreal[4] with a c style array would be better. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D8809 To: apol, #plasma, davidedmundson Cc: broulik, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8809: Reduce spurious signal emissions
apol added a comment. > If we're doing some caching in there now anyway, can we perhaps add individual signals for the margins or is it not worth it? No, we don't have any caching. Also they never seem to change, on my system it goes from 0 (default) to 6 for all of them (whatever is in my theme I guess) and it stays like that. I wouldn't worry about separate signals. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8809 To: apol, #plasma Cc: broulik, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8809: Reduce spurious signal emissions
broulik added a comment. Good idea with the RAII class. If we're doing some caching in there now anyway, can we perhaps add individual signals for the margins or is it not worth it? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8809 To: apol, #plasma Cc: broulik, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8809: Reduce spurious signal emissions
apol edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8809 To: apol, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8809: Reduce spurious signal emissions
davidedmundson added a comment. you can close https://bugs.kde.org/show_bug.cgi?id=382233 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8809 To: apol, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8809: Reduce spurious signal emissions
apol created this revision. apol added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY We were reporting that the margins were changing whenever anything changed in a FrameSvg, this patch makes sure we are only reporting the changes when it actually changes. This also fixes a binding loop in Desktop.qml from plasma-desktop REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D8809 AFFECTED FILES src/declarativeimports/core/framesvgitem.cpp src/declarativeimports/core/framesvgitem.h src/plasma/framesvg.cpp To: apol, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
