D8837: Fix testtrash with qtbase 5.10 beta 4
bcooksley added a comment. Following other feedback i've received the gears of motion for such a thing are in motion. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8837 To: elvisangelaccio, dfaure, thiago Cc: cgiboudeaux, bcooksley, #frameworks
D8837: Fix testtrash with qtbase 5.10 beta 4
elvisangelaccio added a comment. In https://phabricator.kde.org/D8837#168682, @bcooksley wrote: > The reason why I ask is - would it be worth setting up a parallel build against Qt 5.10 on the CI to see what else breaks test wise? Imho yes, better CI coverage is always a good thing :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8837 To: elvisangelaccio, dfaure, thiago Cc: cgiboudeaux, bcooksley, #frameworks
D8837: Fix testtrash with qtbase 5.10 beta 4
bcooksley added a comment. The reason why I ask is - would it be worth setting up a parallel build against Qt 5.10 on the CI to see what else breaks test wise? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8837 To: elvisangelaccio, dfaure, thiago Cc: cgiboudeaux, bcooksley, #frameworks
D8837: Fix testtrash with qtbase 5.10 beta 4
This revision was automatically updated to reflect the committed changes. Closed by commit R241:05938a167dd4: Fix testtrash with qtbase 5.10 beta 4 (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8837?vs=22431&id=22437 REVISION DETAIL https://phabricator.kde.org/D8837 AFFECTED FILES src/core/listjob.cpp To: elvisangelaccio, dfaure, thiago Cc: cgiboudeaux, bcooksley, #frameworks
D8837: Fix testtrash with qtbase 5.10 beta 4
cgiboudeaux added a comment. In https://phabricator.kde.org/D8837#168327, @bcooksley wrote: > Elvis, how many other issues like this do we expect to crop up due to Qt 5.10? https://bugs.kde.org/386420 ? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8837 To: elvisangelaccio, dfaure, thiago Cc: cgiboudeaux, bcooksley, #frameworks
D8837: Fix testtrash with qtbase 5.10 beta 4
elvisangelaccio added a comment. In https://phabricator.kde.org/D8837#168327, @bcooksley wrote: > Elvis, how many other issues like this do we expect to crop up due to Qt 5.10? I have two other failing tests in kio, which I'm fixing now. I guess this change will probably break something in some applications, but that's hard to tell. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8837 To: elvisangelaccio, dfaure, thiago Cc: bcooksley, #frameworks
D8837: Fix testtrash with qtbase 5.10 beta 4
bcooksley added a comment. Elvis, how many other issues like this do we expect to crop up due to Qt 5.10? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8837 To: elvisangelaccio, dfaure, thiago Cc: bcooksley, #frameworks
D8837: Fix testtrash with qtbase 5.10 beta 4
dfaure added a comment. More seriously, this could be a reason for adding QUrl::addPath(), like we had in KUrl. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8837 To: elvisangelaccio, dfaure, thiago Cc: #frameworks
D8837: Fix testtrash with qtbase 5.10 beta 4
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8837 To: elvisangelaccio, dfaure, thiago Cc: #frameworks
D8837: Fix testtrash with qtbase 5.10 beta 4
dfaure added a comment. Maybe we need a KUrl class :-) Just kidding. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8837 To: elvisangelaccio, dfaure, thiago Cc: #frameworks
D8837: Fix testtrash with qtbase 5.10 beta 4
elvisangelaccio created this revision. elvisangelaccio added reviewers: dfaure, thiago. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Same fix as in https://phabricator.kde.org/D8836, this time for testtrash. TEST PLAN Run testtrash. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8837 AFFECTED FILES src/core/listjob.cpp To: elvisangelaccio, dfaure, thiago Cc: #frameworks
