D9277: Remove cmake warning about generating moc file
This revision was automatically updated to reflect the committed changes. Closed by commit R237:962998ad27e9: Remove cmake warning about generating moc file (authored by mlaurent). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9277?vs=23882&id=23883 REVISION DETAIL https://phabricator.kde.org/D9277 AFFECTED FILES KF5ConfigMacros.cmake To: mlaurent, kfunk, dfaure Cc: mpyne, apol, aacid, #frameworks
D9277: Remove cmake warning about generating moc file
mlaurent updated this revision to Diff 23882. mlaurent added a comment. - Use set_source_files_properties REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9277?vs=23716&id=23882 BRANCH remove_cmake_warning REVISION DETAIL https://phabricator.kde.org/D9277 AFFECTED FILES KF5ConfigMacros.cmake To: mlaurent, kfunk, dfaure Cc: mpyne, apol, aacid, #frameworks
D9277: Remove cmake warning about generating moc file
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
Yes. Makes sense to me.
INLINE COMMENTS
> KF5ConfigMacros.cmake:98
>
> + set_property(SOURCE ${_header_FILE} PROPERTY SKIP_AUTOMOC TRUE) #
> don't run automoc on this file
> + set_property(SOURCE ${_src_FILE} PROPERTY SKIP_AUTOMOC TRUE) # don't
> run automoc on this file
Use `set_source_files_properties(...)` instead, cf.
https://phabricator.kde.org/R249:6e3b708435cc7747ea83a3afea4647c2d48b
REPOSITORY
R237 KConfig
BRANCH
remove_cmake_warning
REVISION DETAIL
https://phabricator.kde.org/D9277
To: mlaurent, kfunk, dfaure
Cc: mpyne, apol, aacid, #frameworks
D9277: Remove cmake warning about generating moc file
mlaurent added a comment. @kfunk what do you think about it ? :) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9277 To: mlaurent, kfunk, dfaure Cc: mpyne, apol, aacid, #frameworks
D9277: Remove cmake warning about generating moc file
mlaurent added a comment. @dfaure yep I rebuild all qt5.10 so yep :) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9277 To: mlaurent, kfunk, dfaure Cc: mpyne, apol, aacid, #frameworks
D9277: Remove cmake warning about generating moc file
dfaure added a comment. Do you have qtbase commit b71b7461b0 ? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9277 To: mlaurent, kfunk, dfaure Cc: mpyne, apol, aacid, #frameworks
D9277: Remove cmake warning about generating moc file
mlaurent added a comment. @apol do you have cmake >= 3.10 ? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9277 To: mlaurent, kfunk, dfaure Cc: mpyne, apol, aacid, #frameworks
D9277: Remove cmake warning about generating moc file
mlaurent added a comment. @apol do you have an example of class which generate signal/slot ? For me ARG_GENERATE_MOC seems to be the case and by default it skips AUTOMOC REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9277 To: mlaurent, kfunk, dfaure Cc: mpyne, apol, aacid, #frameworks
D9277: Remove cmake warning about generating moc file
mpyne added a comment.
@aacid you might be thinking of my KI18n fix for ui*.h files in
https://phabricator.kde.org/D9118, but I'm sure there's other examples.
I'll point out that Kevin looked at my patch as well and recommended
something like `set_source_files_properties(${_header} ...)` instead as a more
canonical way to accomplish this.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D9277
To: mlaurent, kfunk, dfaure
Cc: mpyne, apol, aacid, #frameworks
D9277: Remove cmake warning about generating moc file
apol added a comment. Can you confirm that it still compiles properly in the cases where the class generates signals/slots/properties? In fact, kmail compiling properly doesn't say much to me. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9277 To: mlaurent, kfunk, dfaure Cc: apol, aacid, #frameworks
D9277: Remove cmake warning about generating moc file
mlaurent added a comment. it's seems that it was not fixed as I updated my kde last friday afternoon. and this morning I was this problem. And if it's fixed we need to remove this 2 lines So it seems there is still a code to remove. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9277 To: mlaurent, kfunk, dfaure Cc: aacid, #frameworks
D9277: Remove cmake warning about generating moc file
aacid added a comment. Wasn't this fixed recently in ecm? Or does kconfig needs an extra fix in addition to the fix in ecm? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9277 To: mlaurent, kfunk, dfaure Cc: aacid, #frameworks
D9277: Remove cmake warning about generating moc file
mlaurent added reviewers: kfunk, dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9277 To: mlaurent, kfunk, dfaure Cc: #frameworks
D9277: Remove cmake warning about generating moc file
mlaurent created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN compile kmail without cmake warning REPOSITORY R237 KConfig BRANCH remove_cmake_warning REVISION DETAIL https://phabricator.kde.org/D9277 AFFECTED FILES KF5ConfigMacros.cmake To: mlaurent Cc: #frameworks
