D9987: Lessen log spam by not checking for existence of file with empty name

[Dominik Haumann]

dhaumann added a comment.


  FYI: This now landed with 88be459559448d9d30b33f33b3ffd31fc41327c7 
 
(cf. https://commits.kde.org/kinit/88be459559448d9d30b33f33b3ffd31fc41327c7)

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D9987

To: rkflx, #frameworks
Cc: dfaure, kde-frameworks-devel, dhaumann, michaelh, ngraham, bruns

D9987: Lessen log spam by not checking for existence of file with empty name

[Dominik Haumann]

dhaumann added a comment.


  @rkflx can you please reopen so we can accept this?

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D9987

To: rkflx, #frameworks
Cc: dfaure, kde-frameworks-devel, dhaumann, michaelh, ngraham, bruns

D9987: Lessen log spam by not checking for existence of file with empty name

[David Faure]

dfaure added a comment.


  +2

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D9987

To: rkflx, #frameworks
Cc: dfaure, kde-frameworks-devel, dhaumann, michaelh, ngraham, bruns

D9987: Lessen log spam by not checking for existence of file with empty name

[Dominik Haumann]

dhaumann added a subscriber: dfaure.
dhaumann added a comment.


  @rkflx I think this patch is definitely good enough to not let it go.
  
  @dfaure Can you give another +1?

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D9987

To: rkflx, #frameworks
Cc: dfaure, kde-frameworks-devel, dhaumann, michaelh, ngraham, bruns

D9987: Lessen log spam by not checking for existence of file with empty name

[Henrik Fehlauer]

rkflx abandoned this revision.
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D9987

To: rkflx, #frameworks
Cc: kde-frameworks-devel, dhaumann, michaelh, ngraham, bruns

D9987: Lessen log spam by not checking for existence of file with empty name

[Henrik Fehlauer]

rkflx updated this revision to Diff 25672.
rkflx added a comment.


  Spelling.

REPOSITORY
  R303 KInit

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9987?vs=25671=25672

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9987

AFFECTED FILES
  src/kdeinit/kinit.cpp

To: rkflx, #frameworks
Cc: dhaumann

D9987: Lessen log spam by not checking for existence of file with empty name

[Henrik Fehlauer]

rkflx updated this revision to Diff 25671.
rkflx added a comment.


  Add comment. Thanks for the tip, Dominik :)

REPOSITORY
  R303 KInit

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9987?vs=25670=25671

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9987

AFFECTED FILES
  src/kdeinit/kinit.cpp

To: rkflx, #frameworks
Cc: dhaumann

D9987: Lessen log spam by not checking for existence of file with empty name

[Dominik Haumann]

dhaumann added a comment.


  +1, but someone else must approve.
  
  You could even add this as comment: // check for empty string to avoid 
warning message in QFileExists.

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D9987

To: rkflx, #frameworks
Cc: dhaumann

D9987: Lessen log spam by not checking for existence of file with empty name

[Henrik Fehlauer]

rkflx created this revision.
rkflx added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
rkflx requested review of this revision.

REVISION SUMMARY
  Calls to `QFile::exists()` while starting a Plasma session
  resulted in `Empty filename passed to function` being logged
  since Qt 5.10 (0dee566e98f5 in qtbase).
  
  This can be avoided by skipping the check for empty filenames, which
  would have returned `false` in any case. Similarly to what was done in
  https://phabricator.kde.org/R241:549fc81e8e8a47afc5621d1383de5d440fc35f76, 
also port to the faster `QFileInfo::exists()`.
  
  Note this does not simply hide a deeper issue, i.e. the actual cause
  resulting in the empty variable, because `libpath.isEmpty()` will be
  handled explicitly later on. In the case under investigation
  `/usr/lib64/libexec/org_kde_powerdevil` did not match
  `/usr/lib64/libexec/kf5`, but even if it was in that subfolder there
  would have been no corresponding `libkdeinit5_` anyway.
  
  CCBUG: 388611

TEST PLAN
  Grep session log for "Empty filename passed to function" after
  restarting the Plasma session and compare before/after.

REPOSITORY
  R303 KInit

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9987

AFFECTED FILES
  src/kdeinit/kinit.cpp

To: rkflx, #frameworks