Re: EcmQt4To5Porting
On Friday 04 October 2013 10:51:07 Martin Klapetek wrote: > On Fri, Oct 4, 2013 at 9:22 AM, David Faure wrote: > > On Wednesday 02 October 2013 14:07:31 Martin Klapetek wrote: > > > There were 2 files recently removed from ECM which broke attica's build, > > > this puts the removed files as local cmake modules. > > > > > > > > > Diffs > > > - > > > > > > CMakeLists.txt e0efb9b > > > cmake/modules/ECMQt4To5Porting.cmake PRE-CREATION > > > cmake/modules/FindQt5Transitional.cmake PRE-CREATION > > > > I'm confused. Why have they been removed from ECM? > > (and where was this explained/announced). > > I only found out because Attica failed to build for me, so I investigated > and notified Stephen, he suggested to either copy the files over or "do it > properly" as explained in his following email. Being unfamiliar with Attica > completely, I chose the easier way. It's not just libattica which failed, but also for example libdbusmenu-qt: CMake Error at CMakeLists.txt:53 (find_package): By not providing "FindQt5Transitional.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by "Qt5Transitional", but CMake did not find one. Could not find a package configuration file provided by "Qt5Transitional" with any of the following names: Qt5TransitionalConfig.cmake qt5transitional-config.cmake Add the installation prefix of "Qt5Transitional" to CMAKE_PREFIX_PATH or set "Qt5Transitional_DIR" to a directory containing one of the above files. If "Qt5Transitional" provides a separate development package or SDK, be sure it has been installed. > > I too, however, would appreciate these breaking changes to be at least > announced on this list. +1000, I think we can do much better to prevent that developers struggle to get their build fixed again. Cheers Martin signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: EcmQt4To5Porting
On Fri, Oct 4, 2013 at 9:22 AM, David Faure wrote: > On Wednesday 02 October 2013 14:07:31 Martin Klapetek wrote: > > There were 2 files recently removed from ECM which broke attica's build, > > this puts the removed files as local cmake modules. > > > > > > Diffs > > - > > > > CMakeLists.txt e0efb9b > > cmake/modules/ECMQt4To5Porting.cmake PRE-CREATION > > cmake/modules/FindQt5Transitional.cmake PRE-CREATION > > I'm confused. Why have they been removed from ECM? > (and where was this explained/announced). > I only found out because Attica failed to build for me, so I investigated and notified Stephen, he suggested to either copy the files over or "do it properly" as explained in his following email. Being unfamiliar with Attica completely, I chose the easier way. I too, however, would appreciate these breaking changes to be at least announced on this list. Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: EcmQt4To5Porting
David Faure wrote: > On Wednesday 02 October 2013 14:07:31 Martin Klapetek wrote: >> There were 2 files recently removed from ECM which broke attica's build, >> this puts the removed files as local cmake modules. >> >> >> Diffs >> - >> >> CMakeLists.txt e0efb9b >> cmake/modules/ECMQt4To5Porting.cmake PRE-CREATION >> cmake/modules/FindQt5Transitional.cmake PRE-CREATION > > I'm confused. Why have they been removed from ECM? > (and where was this explained/announced). > > Attica surely isn't the only module which is going to want to build with > both Qt4 and Qt5, right? Right. I copied them into the kdelibs repo, so anything using that can make use of them. They're not a long term solution because they're so catch-all. QT_QTCORE_LIBRARIES contains the QtConcurrent library also, etc. They're only a temporary solution so that you don't have to change eg qt4_wrap_ui to qt5_wrap_ui before trying to build your c++ code. I don't think they should be maintained/supported long-term. I was considering adding EcmQt4To5Porting to Qt as a documentation page, which doesn't need to maintain compatibility. > Or if there's a better way to do this, shouldn't attica be ported to the > better way, before other modules copy these files too? The better way is: * Start with a Qt4 based repo * Add the files * Make whatever changes needed to port the c++ code to Qt 5 * Port away from the files (eg s/qt4_wrap_ui/qt5_wrap_ui/ ) * Remove the files Thanks, Steve. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
EcmQt4To5Porting
On Wednesday 02 October 2013 14:07:31 Martin Klapetek wrote: > There were 2 files recently removed from ECM which broke attica's build, > this puts the removed files as local cmake modules. > > > Diffs > - > > CMakeLists.txt e0efb9b > cmake/modules/ECMQt4To5Porting.cmake PRE-CREATION > cmake/modules/FindQt5Transitional.cmake PRE-CREATION I'm confused. Why have they been removed from ECM? (and where was this explained/announced). Attica surely isn't the only module which is going to want to build with both Qt4 and Qt5, right? Or if there's a better way to do this, shouldn't attica be ported to the better way, before other modules copy these files too? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
