Re: KIdleTime Quick Review

2014-03-04 Thread Kevin Ottens
On Tuesday 04 March 2014 19:35:10 John Layt wrote:
> Hi,
> 
> Nice simple one this, one public class, looks OK.
> 
> Has QWidget, Windows, Mac, and X11 (XScreensaver/XSync) backends, will need
> Wayland or systemd support eventually?
> 
> Does have one TODO, but that's an implementation detail:
> 
> "widgetbasedpoller.cpp # TODO: make optional, to avoid always depending on
> QtWidgets? Or port to QtGui?"
> 
> One small point, the idle time is an int value, perhaps a uint would be
> better?  Also uses an int for a unique timeout identifier, perhaps a QUuid
> might be better?
> 
> If you're looking for a maintainer, Dario Freddi wrote all the code... Just
> sayin ;-)

Yes, but he's pretty much inactive these days unfortunately...

Cheers.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com



signature.asc
Description: This is a digitally signed message part.
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


KIdleTime Quick Review

2014-03-04 Thread John Layt
Hi,

Nice simple one this, one public class, looks OK.

Has QWidget, Windows, Mac, and X11 (XScreensaver/XSync) backends, will need 
Wayland or systemd support eventually?

Does have one TODO, but that's an implementation detail:

"widgetbasedpoller.cpp # TODO: make optional, to avoid always depending on 
QtWidgets? Or port to QtGui?"

One small point, the idle time is an int value, perhaps a uint would be 
better?  Also uses an int for a unique timeout identifier, perhaps a QUuid 
might be better?

If you're looking for a maintainer, Dario Freddi wrote all the code... Just 
sayin ;-)

John.

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel