Re: Macro naming
On Mon, Dec 23, 2013 at 12:28 PM, Martin Graesslin wrote: > On Monday 23 December 2013 10:36:22 Alex Merry wrote: > > Oh, and the versioning that we get from a kf5 prefix could prove to be > > useful when we transition to KF6. > or means additional porting effort (though that can be sed'ed) > We'll have to change all of the "KF5" already...if properly scripted, no additional porting would occur...actually less porting effort would occur ;) Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Macro naming
On Monday 23 December 2013 10:36:22 Alex Merry wrote: > On 23/12/13 01:42, Alex Merry wrote: > > On 23/12/13 01:27, Aleix Pol wrote: > >> On Mon, Dec 23, 2013 at 1:17 AM, Alex Merry >> > >> <mailto:k...@randomguy3.me.uk>> wrote: > >> Currently, we are not consistent about CMake macro naming in the > >> frameworks. KAuth, for example, has kauth_install_actions, while > >> kdesignerplugin has kf5designerplugin_add_widget_files. > >> > >> How do we want our macros prefixed? > >> > >> I would say that we want _. It's what we have in > >> most places I'd say. I don't think it's a good idea using kf5* since it > >> doesn't explain where it comes from. > > > > The counterargument is that after doing > > find_package(KF5DesignerPlugin) > > you would generally expect any macros it provides to be prefixed with > > kf5designerplugin or some prefix or simple variant of it (like kf5 or > > kf5_designer_plugin). > > Oh, and the versioning that we get from a kf5 prefix could prove to be > useful when we transition to KF6. or means additional porting effort (though that can be sed'ed) signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Macro naming
On 23/12/13 01:42, Alex Merry wrote: > On 23/12/13 01:27, Aleix Pol wrote: >> On Mon, Dec 23, 2013 at 1:17 AM, Alex Merry > <mailto:k...@randomguy3.me.uk>> wrote: >> >> Currently, we are not consistent about CMake macro naming in the >> frameworks. KAuth, for example, has kauth_install_actions, while >> kdesignerplugin has kf5designerplugin_add_widget_files. >> >> How do we want our macros prefixed? >> >> I would say that we want _. It's what we have in >> most places I'd say. I don't think it's a good idea using kf5* since it >> doesn't explain where it comes from. > > The counterargument is that after doing > find_package(KF5DesignerPlugin) > you would generally expect any macros it provides to be prefixed with > kf5designerplugin or some prefix or simple variant of it (like kf5 or > kf5_designer_plugin). Oh, and the versioning that we get from a kf5 prefix could prove to be useful when we transition to KF6. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Macro naming
On 23/12/13 01:27, Aleix Pol wrote: > On Mon, Dec 23, 2013 at 1:17 AM, Alex Merry <mailto:k...@randomguy3.me.uk>> wrote: > > Currently, we are not consistent about CMake macro naming in the > frameworks. KAuth, for example, has kauth_install_actions, while > kdesignerplugin has kf5designerplugin_add_widget_files. > > How do we want our macros prefixed? > > I would say that we want _. It's what we have in > most places I'd say. I don't think it's a good idea using kf5* since it > doesn't explain where it comes from. The counterargument is that after doing find_package(KF5DesignerPlugin) you would generally expect any macros it provides to be prefixed with kf5designerplugin or some prefix or simple variant of it (like kf5 or kf5_designer_plugin). Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Macro naming
On Mon, Dec 23, 2013 at 1:17 AM, Alex Merry wrote: > Currently, we are not consistent about CMake macro naming in the > frameworks. KAuth, for example, has kauth_install_actions, while > kdesignerplugin has kf5designerplugin_add_widget_files. > > How do we want our macros prefixed? > > Alex > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel > I would say that we want _. It's what we have in most places I'd say. I don't think it's a good idea using kf5* since it doesn't explain where it comes from. Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Macro naming
Currently, we are not consistent about CMake macro naming in the frameworks. KAuth, for example, has kauth_install_actions, while kdesignerplugin has kf5designerplugin_add_widget_files. How do we want our macros prefixed? Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
