OSX/CI: kde-baseapps fails to build on branch frameworks
Dolphin is currently broken on OSX: --- [ 49%] Building CXX object konqueror/src/CMakeFiles/kdeinit_konqueror.dir/konqviewmanager.cpp.o /Users/marko/WC/KDECI-builds/kde-baseapps/dolphin/src/views/dolphinview.cpp:571:25: error: use of undeclared identifier 'KFormat' KFormat().formatByteSize(totalFileSize)); ^ /Users/marko/WC/KDECI-builds/kde-baseapps/dolphin/src/views/dolphinview.cpp:575:25: error: use of undeclared identifier 'KFormat' KFormat().formatByteSize(totalFileSize)); ^ ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
OSX/CI: kde-baseapps fails to build on branch frameworks
/Users/marko/WC/KDECI-builds/kde-baseapps/dolphin/src/tests/kfileitemlistviewtest.cpp:91:16: error: no matching constructor for initialization of 'QSignalSpy' QSignalSpy itemsRemovedSpy(m_model, &KFileItemModel::itemsRemoved); ^ ~~ /opt/kde/install/darwin/mavericks/clang/kf5-qt5/qt5/inst/include/QtTest/qsignalspy.h:61:14: note: candidate constructor not viable: no known conversion from 'void (KItemModelBase::*)(const KItemRangeList &)' to 'const char *' for 2nd argument explicit QSignalSpy(const QObject *obj, const char *aSignal) ^ /opt/kde/install/darwin/mavericks/clang/kf5-qt5/qt5/inst/include/QtTest/qsignalspy.h:58:7: note: candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 2 were provided class QSignalSpy: public QObject, public QList > ^ Building CXX object dolphin/src/CMakeFiles/kcm_dolphinviewmodes.dir/settings/viewmodes/viewsettingstab.cpp.o 2 errors generated. [ 50%] make[2]: *** [dolphin/src/tests/CMakeFiles/kfileitemlistviewtest.dir/kfileitemlistviewtest.cpp.o] Error 1 make[1]: *** [dolphin/src/tests/CMakeFiles/kfileitemlistviewtest.dir/all] Error 2 kde-baseapps.log.gz Description: GNU Zip compressed data ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
OSX/CI: kde-baseapps fails to build on branch frameworks
CMake Error at keditbookmarks/kbookmarkmodel/CMakeLists.txt:23 (install): install TARGETS given unknown argument "BUNDLE". CMake Error at keditbookmarks/CMakeLists.txt:48 (install): install TARGETS given unknown argument "BUNDLE”. CMake Error at keditbookmarks/CMakeLists.txt:82 (install): install TARGETS given unknown argument "BUNDLE". CMake Error at keditbookmarks/CMakeLists.txt:83 (install): install TARGETS given unknown argument "BUNDLE". ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
OSX/CI: kde-baseapps fails to build on branch frameworks
To make kde-baseapps build again on OSX/CI I have removed poppler from its dependencies in config/base/kf5-qt5: --- +# KDE/Applications +kde/applications/kde-baseapps: -kde/kdelibs/baloo +kde/applications/kde-baseapps: -kde/kdelibs/baloo-widgets +kde/applications/kde-baseapps: -general/poppler --- Yet, I am running in an unrelated problem, as it seems: --- [ 75%] Building CXX object dolphin/src/CMakeFiles/kcm_dolphinviewmodes.dir/kcm_dolphinviewmodes_automoc.cpp.o /Users/marko/WC/KDECI-builds/kf5-qt5/kde-baseapps/dolphin/src/main.cpp:108:68: error: no member named 'AssumeLocalFile' in 'QUrl' const QUrl url = QUrl::fromUserInput(str, QString(), QUrl::AssumeLocalFile); ~~^ Scanning dependencies of target kitemlistselectionmanagertest 1 error generated. make[2]: *** [dolphin/src/CMakeFiles/kdeinit_dolphin.dir/main.cpp.o] Error 1 make[1]: *** [dolphin/src/CMakeFiles/kdeinit_dolphin.dir/all] Error 2 --- Greets, Marko ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kde-baseapps fails to build on branch frameworks
Hello On Wed, Oct 8, 2014 at 12:04 PM, Marko Käning wrote: > Dolphin is currently broken on OSX: > #ifdef HAVE_BALOO #include -#include #endif +#include Can you try this? ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kde-baseapps fails to build on branch frameworks
Hi Bhushan, On 08 Oct 2014, at 08:44 , Bhushan Shah wrote: > #ifdef HAVE_BALOO >#include > -#include > #endif > +#include > > Can you try this? that fixed some stuff, but not all: --- [ 91%] [ 91%] Building CXX object dolphin/src/tests/CMakeFiles/viewpropertiestest.dir/testdir.cpp.o Building CXX object dolphin/src/CMakeFiles/kdeinit_dolphin.dir/settings/general/generalsettingspage.cpp.o /Users/marko/WC/KDECI-builds/kde-baseapps/dolphin/src/search/dolphinsearchbox.cpp:355:28: error: use of undeclared identifier 'QFontDatabase' m_searchInput->setFont(QFontDatabase::systemFont(QFontDatabase::GeneralFont)); ^ /Users/marko/WC/KDECI-builds/kde-baseapps/dolphin/src/search/dolphinsearchbox.cpp:355:54: error: use of undeclared identifier 'QFontDatabase' m_searchInput->setFont(QFontDatabase::systemFont(QFontDatabase::GeneralFont)); ^ /Users/marko/WC/KDECI-builds/kde-baseapps/dolphin/src/search/dolphinsearchbox.cpp:492:55: warning: unused parameter 'url' [-Wunused-parameter] void DolphinSearchBox::fromBalooSearchUrl(const KUrl& url) ^ 1 warning and 2 errors generated. make[2]: *** [dolphin/src/CMakeFiles/kdeinit_dolphin.dir/search/dolphinsearchbox.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs --- Thanks for taking care of this! Greets, Marko ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kde-baseapps fails to build on branch frameworks
What about this? #ifdef HAVE_BALOO #include #include #include #include #include -#include #endif +#include On Wed, Oct 8, 2014 at 12:27 PM, Marko Käning wrote: > Hi Bhushan, > > On 08 Oct 2014, at 08:44 , Bhushan Shah wrote: >> #ifdef HAVE_BALOO >>#include >> -#include >> #endif >> +#include >> >> Can you try this? > > that fixed some stuff, but not all: > --- > [ 91%] [ 91%] Building CXX object > dolphin/src/tests/CMakeFiles/viewpropertiestest.dir/testdir.cpp.o > Building CXX object > dolphin/src/CMakeFiles/kdeinit_dolphin.dir/settings/general/generalsettingspage.cpp.o > /Users/marko/WC/KDECI-builds/kde-baseapps/dolphin/src/search/dolphinsearchbox.cpp:355:28: > error: use of undeclared identifier 'QFontDatabase' > > m_searchInput->setFont(QFontDatabase::systemFont(QFontDatabase::GeneralFont)); >^ > /Users/marko/WC/KDECI-builds/kde-baseapps/dolphin/src/search/dolphinsearchbox.cpp:355:54: > error: use of undeclared identifier 'QFontDatabase' > > m_searchInput->setFont(QFontDatabase::systemFont(QFontDatabase::GeneralFont)); > ^ > /Users/marko/WC/KDECI-builds/kde-baseapps/dolphin/src/search/dolphinsearchbox.cpp:492:55: > warning: unused parameter 'url' [-Wunused-parameter] > void DolphinSearchBox::fromBalooSearchUrl(const KUrl& url) > ^ > 1 warning and 2 errors generated. > make[2]: *** > [dolphin/src/CMakeFiles/kdeinit_dolphin.dir/search/dolphinsearchbox.cpp.o] > Error 1 > make[2]: *** Waiting for unfinished jobs > --- > > Thanks for taking care of this! > > Greets, > Marko > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kde-baseapps fails to build on branch frameworks
Hi Bhushan, thanks, it worked eventually! Committed here: http://commits.kde.org/kde-baseapps/e2691b93cc078366261302f92821ba0672401099 What a luck that I do not have baloo installed, otherwise this would have went unnoticed even by Jenkins master, which does not test for a baloo-free setup. =) Greets, Marko ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kde-baseapps fails to build on branch frameworks
On Thursday 18 December 2014 22:20:54 Marko Käning wrote: > /Users/marko/WC/KDECI-builds/kde-baseapps/dolphin/src/tests/kfileitemlistvie > wtest.cpp:91:16: error: no matching constructor for initialization of > 'QSignalSpy' QSignalSpy itemsRemovedSpy(m_model, > &KFileItemModel::itemsRemoved); ^ > ~~ Note: That needs Qt 5.4 -- QSignalSpy can take a PMF only since that. > /opt/kde/install/darwin/mavericks/clang/kf5-qt5/qt5/inst/include/QtTest/qsi > gnalspy.h:61:14: note: candidate constructor not viable: no known conversion > from 'void (KItemModelBase::*)(const KItemRangeList &)' to 'const char *' > for 2nd argument explicit QSignalSpy(const QObject *obj, const char > *aSignal) > ^ > /opt/kde/install/darwin/mavericks/clang/kf5-qt5/qt5/inst/include/QtTest/qsig > nalspy.h:58:7: note: candidate constructor (the implicit copy constructor) > not viable: requires 1 argument, but 2 were provided class QSignalSpy: > public QObject, public QList > > ^ > Building CXX object > dolphin/src/CMakeFiles/kcm_dolphinviewmodes.dir/settings/viewmodes/viewsett > ingstab.cpp.o 2 errors generated. > [ 50%] make[2]: *** > [dolphin/src/tests/CMakeFiles/kfileitemlistviewtest.dir/kfileitemlistviewte > st.cpp.o] Error 1 make[1]: *** > [dolphin/src/tests/CMakeFiles/kfileitemlistviewtest.dir/all] Error 2 -- Kevin Funk | kf...@kde.org | http://kfunk.org ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kde-baseapps fails to build on branch frameworks
Hi Kevin, > Note: That needs Qt 5.4 -- QSignalSpy can take a PMF only since that. I guess that test's code should then be guarded appropriately, so that it builds also on KDE CI's still being used Qt 5.3.2, right? Greets, Marko ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kde-baseapps fails to build on branch frameworks
On Saturday 20 December 2014 15:17:52 Marko Käning wrote: > Hi Kevin, > > > Note: That needs Qt 5.4 -- QSignalSpy can take a PMF only since that. > > I guess that test's code should then be guarded appropriately, so that it > builds also on KDE CI's still being used Qt 5.3.2, right? Fixed. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kde-baseapps fails to build on branch frameworks
Seems that's from Qt 5.4 "This enum was introduced or modified in Qt 5.4." in the QUrl::UserInputResolutionOptions documentation. On Tue, Feb 10, 2015 at 3:07 PM, Marko Käning wrote: > To make kde-baseapps build again on OSX/CI I have removed poppler from its > dependencies in config/base/kf5-qt5: > --- > +# KDE/Applications > +kde/applications/kde-baseapps: -kde/kdelibs/baloo > +kde/applications/kde-baseapps: -kde/kdelibs/baloo-widgets > +kde/applications/kde-baseapps: -general/poppler > --- > > > Yet, I am running in an unrelated problem, as it seems: > --- > [ 75%] Building CXX object > dolphin/src/CMakeFiles/kcm_dolphinviewmodes.dir/kcm_dolphinviewmodes_automoc.cpp.o > /Users/marko/WC/KDECI-builds/kf5-qt5/kde-baseapps/dolphin/src/main.cpp:108:68: > error: no member named 'AssumeLocalFile' in 'QUrl' > const QUrl url = QUrl::fromUserInput(str, QString(), > QUrl::AssumeLocalFile); > ~~^ > Scanning dependencies of target kitemlistselectionmanagertest > 1 error generated. > make[2]: *** [dolphin/src/CMakeFiles/kdeinit_dolphin.dir/main.cpp.o] Error > 1 > make[1]: *** [dolphin/src/CMakeFiles/kdeinit_dolphin.dir/all] Error 2 > --- > > Greets, > Marko > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kde-baseapps fails to build on branch frameworks
Hi Jeremy, On 10 Feb 2015, at 23:10 , Jeremy Whiting wrote: > Seems that's from Qt 5.4 "This enum was introduced or modified in Qt 5.4." in > the QUrl::UserInputResolutionOptions documentation. Shouldn’t the project then require Qt 5.4, which I’d like to see avoided for now… Greets, Marko___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kde-baseapps fails to build on branch frameworks
Exactly, whoever added that code either needs to find a Qt 5.3 way to do the same, or bump the requirement. On Tue, Feb 10, 2015 at 3:15 PM, Marko Käning wrote: > Hi Jeremy, > > On 10 Feb 2015, at 23:10 , Jeremy Whiting wrote: > > Seems that's from Qt 5.4 "This enum was introduced or modified in Qt > 5.4." in the QUrl::UserInputResolutionOptions documentation. > > > Shouldn’t the project then require Qt 5.4, which I’d like to see avoided > for now… > > Greets, > Marko > > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kde-baseapps fails to build on branch frameworks
Hi Albert, On 10 Feb 2015, at 23:17 , Jeremy Whiting wrote: > Exactly, whoever added that code either needs to find a Qt 5.3 way to do the > same, or bump the requirement. who is in charge of kde-baseapps? I’d like to get this going on OSX with Qt 5.3.2 again, or at least see the project set its requirements correctly… Greets, Marko___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kde-baseapps fails to build on branch frameworks
The offending commit was from Arjun AK, I've e-mailed him and cc'ed kde-core-devel to either bump kde-baseapps Qt requirement or revert/workaround that use of the enumeration that is new in Qt 5.4. On Wed, Feb 11, 2015 at 12:00 PM, Marko Käning wrote: > Hi Albert, > > On 10 Feb 2015, at 23:17 , Jeremy Whiting wrote: > > Exactly, whoever added that code either needs to find a Qt 5.3 way to do > the same, or bump the requirement. > > > who is in charge of kde-baseapps? > > I’d like to get this going on OSX with Qt 5.3.2 again, or at least see the > project set its requirements correctly… > > Greets, > Marko > > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kde-baseapps fails to build on branch frameworks
El Dimecres, 11 de febrer de 2015, a les 20:00:38, Marko Käning va escriure: > Hi Albert, > > On 10 Feb 2015, at 23:17 , Jeremy Whiting wrote: > > Exactly, whoever added that code either needs to find a Qt 5.3 way to do > > the same, or bump the requirement. > who is in charge of kde-baseapps? > > I’d like to get this going on OSX with Qt 5.3.2 again, or at least see the > project set its requirements correctly… You have a commiter account, you can commit, you can fix it yourself :) Cheers, Albert > > Greets, > Marko ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
