Re: Increasing KF5 cmake requirement to 3.6?
On Sat, Nov 17, 2018 at 8:04 PM Wolfgang Bauer wrote: > > > -Original Message- > > I'm going to suggest it to increase it to 3.6, it would still most > probably be a lie > > since i don't think any of use uses such an old (2 years version) either > > We currently do still build the latest KDE Frameworks, Plasma, and > Applications on/for openSUSE Leap 42.3 (plus latest Qt5) with cmake 3.5.2. > > Only problem so far: discover started to use a new feature of cmake 3.6 in > the latest (bugfix) version, namely the IMPORTED_TARGET option to > pkg_checkmodule(), so the flatpak and fwupd backends are not built anymore > with cmake 3.5.2. (cmake says "No package 'IMPORTED_TARGET' found") > https://cgit.kde.org/discover.git/commit/?h=Plasma/5.14=d9ccf1d41fc3265ae > e9e01eebbc090b163fefe07 > https://cgit.kde.org/discover.git/commit/?h=Plasma/5.14=2fe3d58fc652fc995 > 7f063cbbd0722dc1cf45730 > (we couldn't build the fwupd backend anyway though because fwupd is too old) Note Plasma is different to KF5 when it comes to dependencies. +1 to using cmake 3.6 overall. Aleix
Re: Increasing KF5 cmake requirement to 3.6?
On samedi 17 novembre 2018 18:10:33 CET Albert Astals Cid wrote: > The KF5 minimum cmake requirement sits at 3.0 > > I doubt anyone is using that to build KF5 so it's a bit of a "lie". > > I'm going to suggest it to increase it to 3.6, it would still most probably > be a lie since i don't think any of use uses such an old (2 years version) > either, but it'll be a smaller lie, and if we look at the cross section of > distros that ship Qt 5.9[1] (current minimum requirement) and their cmake > versions[2], Scientific Linux is the one shipping an oldest cmake and it's > 3.6.3. > > What do you think? Good idea, I'm OK with a 3.6 requirement. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
RE: Increasing KF5 cmake requirement to 3.6?
> -Original Message- > I'm going to suggest it to increase it to 3.6, it would still most probably be a lie > since i don't think any of use uses such an old (2 years version) either We currently do still build the latest KDE Frameworks, Plasma, and Applications on/for openSUSE Leap 42.3 (plus latest Qt5) with cmake 3.5.2. Only problem so far: discover started to use a new feature of cmake 3.6 in the latest (bugfix) version, namely the IMPORTED_TARGET option to pkg_checkmodule(), so the flatpak and fwupd backends are not built anymore with cmake 3.5.2. (cmake says "No package 'IMPORTED_TARGET' found") https://cgit.kde.org/discover.git/commit/?h=Plasma/5.14=d9ccf1d41fc3265ae e9e01eebbc090b163fefe07 https://cgit.kde.org/discover.git/commit/?h=Plasma/5.14=2fe3d58fc652fc995 7f063cbbd0722dc1cf45730 (we couldn't build the fwupd backend anyway though because fwupd is too old) Kind Regards, Wolfgang