Re: Finding contributor email is imposible - was - Re: Phabricator: All repositories registered - upcoming workflow changes
On Wed, Feb 8, 2017 at 4:03 AM, Fredrik Höglundwrote: > On Monday 06 February 2017, Albert Astals Cid wrote: >> El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va >> escriure: >> > Hi everyone, >> > >> > From this point forward, communities should be moving away from >> > Reviewboard to Phabricator for conducting code review. Sysadmin will >> > be announcing a timeline for the shutdown of Reviewboard in the near >> > future. >> >> Today i wanted to commit https://phabricator.kde.org/D4432 since the person >> that opened it does not have a developer account. >> >> Easy peasy, it's just a line, i download the patch and then >> >> git commit --author ... >> >> and what, it says "Authored by rikmills" that's probably not the guys name, >> but i can click on the name and on https://phabricator.kde.org/p/rikmills/ i >> learn he is Rik Mills, good. >> >> $ git commit --author=="Rik Mills" >> fatal: --author 'Rik Mills' is not 'Name ' and matches no existing >> author >> >> ouch, so i need his email, where do i get it? >> >> Nowhere it seems. >> >> I resorted to searching for it in identity.kde.org but i think that i can >> only >> do that because i have some special power over there that allows me to see >> everyone's email, and even if everyone can, it's very cumbsersome, and >> probably what i would end up doing is asking in Differential, the author >> would >> have to answer, potentially either him or me forgetting about it. >> >> On reviewboard it was as simple as going to >> https://git.reviewboard.kde.org/users/rikmills/ (that i just realized i could >> have used instead of identity :D but it's going away so it's not a solution >> either). > > This is the wrong solution. Phabricator should provide the patch in a format > that you can apply to the repository with git am -s , and get the > original commit message, date and author. > > You should never have to enter the author or commit message yourself > when you are committing something for someone else. Phabricator also supports Subversion and Mercurial repositories, along with reviews for which a repository is not set. It's also debatable which fields from the review should end up in the commit message. > > Fredrik > Regards, Ben
Re: Finding contributor email is imposible - was - Re: Phabricator: All repositories registered - upcoming workflow changes
On Tue, Feb 7, 2017 at 3:30 PM, Michael Pynewrote: > On Mon, Feb 06, 2017 at 11:35:15PM +0100, Albert Astals Cid wrote: >> El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va >> escriure: >> > Hi everyone, >> > >> > From this point forward, communities should be moving away from >> > Reviewboard to Phabricator for conducting code review. Sysadmin will >> > be announcing a timeline for the shutdown of Reviewboard in the near >> > future. >> >> Today i wanted to commit https://phabricator.kde.org/D4432 since the person >> that opened it does not have a developer account. >> >> >> ouch, so i need his email, where do i get it? >> >> Nowhere it seems. >> >> I resorted to searching for it in identity.kde.org but i think that i can >> only >> do that because i have some special power over there that allows me to see >> everyone's email, and even if everyone can, it's very cumbsersome, and >> probably what i would end up doing is asking in Differential, the author >> would >> have to answer, potentially either him or me forgetting about it. Hi all, In relation to this issue please continue this at https://phabricator.kde.org/T5242 If we could keep the discussion in a single place that would be appreciated. > > In fairness to Phabricator there's been times where I've needed > developer contact info *without* having a RR available. In the "good > old days" we'd just use the kde-common/accounts file to lookup the > developer's id and corresponding email address, and that worked fine. The kde-common/accounts file is still being maintained, however Sysadmin does intend to disconnect Subversion usernames from everything else, to avoid the arguments over usernames we have with some people. > > So I think Identity (and in general whatever our KDE organizational > directory solution happens to be) is the proper solution -- although it > shouldn't need superpowers to actually see those identities. And of > course, there's no reason not to also show the email in Phabricator, > which would be more helpful and developer-friendly. We'll probably only be able to address this when the replacement to Identity is built, as existing users accepted a privacy policy which stated we wouldn't publish their details. We'll have to be careful how this is done however, knowing the privacy activists we have lurking around. Sysadmin has received many requests in the past to have Bugzilla accounts removed because "you're exposing my email address" even though the site says in a massive font that your email address will be made public when your register. > > Regards, > - Michael Pyne Regards, Ben
Re: Finding contributor email is imposible - was - Re: Phabricator: All repositories registered - upcoming workflow changes
On Monday 06 February 2017, Albert Astals Cid wrote: > El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va escriure: > > Hi everyone, > > > > From this point forward, communities should be moving away from > > Reviewboard to Phabricator for conducting code review. Sysadmin will > > be announcing a timeline for the shutdown of Reviewboard in the near > > future. > > Today i wanted to commit https://phabricator.kde.org/D4432 since the person > that opened it does not have a developer account. > > Easy peasy, it's just a line, i download the patch and then > > git commit --author ... > > and what, it says "Authored by rikmills" that's probably not the guys name, > but i can click on the name and on https://phabricator.kde.org/p/rikmills/ i > learn he is Rik Mills, good. > > $ git commit --author=="Rik Mills" > fatal: --author 'Rik Mills' is not 'Name ' and matches no existing > author > > ouch, so i need his email, where do i get it? > > Nowhere it seems. > > I resorted to searching for it in identity.kde.org but i think that i can > only > do that because i have some special power over there that allows me to see > everyone's email, and even if everyone can, it's very cumbsersome, and > probably what i would end up doing is asking in Differential, the author > would > have to answer, potentially either him or me forgetting about it. > > On reviewboard it was as simple as going to > https://git.reviewboard.kde.org/users/rikmills/ (that i just realized i could > have used instead of identity :D but it's going away so it's not a solution > either). This is the wrong solution. Phabricator should provide the patch in a format that you can apply to the repository with git am -s , and get the original commit message, date and author. You should never have to enter the author or commit message yourself when you are committing something for someone else. Fredrik
Re: Finding contributor email is imposible - was - Re: Phabricator: All repositories registered - upcoming workflow changes
On Mon, Feb 06, 2017 at 11:35:15PM +0100, Albert Astals Cid wrote: > El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va escriure: > > Hi everyone, > > > > From this point forward, communities should be moving away from > > Reviewboard to Phabricator for conducting code review. Sysadmin will > > be announcing a timeline for the shutdown of Reviewboard in the near > > future. > > Today i wanted to commit https://phabricator.kde.org/D4432 since the person > that opened it does not have a developer account. > > > ouch, so i need his email, where do i get it? > > Nowhere it seems. > > I resorted to searching for it in identity.kde.org but i think that i can > only > do that because i have some special power over there that allows me to see > everyone's email, and even if everyone can, it's very cumbsersome, and > probably what i would end up doing is asking in Differential, the author > would > have to answer, potentially either him or me forgetting about it. In fairness to Phabricator there's been times where I've needed developer contact info *without* having a RR available. In the "good old days" we'd just use the kde-common/accounts file to lookup the developer's id and corresponding email address, and that worked fine. So I think Identity (and in general whatever our KDE organizational directory solution happens to be) is the proper solution -- although it shouldn't need superpowers to actually see those identities. And of course, there's no reason not to also show the email in Phabricator, which would be more helpful and developer-friendly. Regards, - Michael Pyne