Re: linking to kde4support (Re: KF5 Update Meeting Minutes 2013-w27)

2013-07-11 Thread Alexander Neundorf
Hi,

if you update plasma-frameworks, make sure you also update kdelibs.

To use the kde4support library now, do

find_package(KDE4Support NO_MODULE) # if outside kdelibs

...
target_link_libraries(hello ${KDE4Support_LIBRARIES} )


as for any other package.

One thing: befor find_package(KDE4Support), you have to do 
find_package(KDELibs4). If you don't do that, you'll get a hopefully 
descriptive error message at cmake time.



Details: I said this stuff will be a mess as long as we still have not cleaned 
the dependencies inside kdelibs, and this is indeed so.

The kde4support library links e.g. against kdecore and kdeui.
Some other libraries in kdelibs, e.g. something in khtml, link against 
kde4support.
So when trying to export the kde4support library target into a separate 
KDE4SupportConfig.cmake (i.e. KDE4SupportTargets.cmake respectively) things 
break. KDELibs4 can't be found successfully, since the required target 
kde4support is missing, when searching KDE4Support first, this can't be found, 
since several required targets from kdelibs are missing.

So, internally, the kde4support library is still exported as 
KDE4__kde4support into the KDELibs4 export set.
But you can, and should, use find_package(KDE4Support) to find it, and this 
will provide the expected ${KDE4Support_LIBRARIES} variable, which you can 
use.
As said above, to satisfy the dependencies, KDELibs4 has to be searched (and 
found) before.


Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: linking to kde4support (Re: KF5 Update Meeting Minutes 2013-w27)

2013-07-09 Thread Alexander Neundorf
On Monday 08 July 2013, Alexander Neundorf wrote:
 On Friday 05 July 2013, Alex Merry wrote:
  On 04/07/13 22:44, David Faure wrote:
   diff --git a/src/plasmapkg/CMakeLists.txt
   b/src/plasmapkg/CMakeLists.txt index d2f2427..919dd64 100644
   --- a/src/plasmapkg/CMakeLists.txt
   +++ b/src/plasmapkg/CMakeLists.txt
   @@ -5,7 +5,7 @@ add_executable(plasmapkg
   
plasmapkg.cpp

)
   
   -target_link_libraries(plasmapkg kdeqt5staging plasma)
   +target_link_libraries(plasmapkg kdeqt5staging plasma kde4support)
   
message(INSTALL_TARGETS_DEFAULT_ARGS
${INSTALL_TARGETS_DEFAULT_ARGS})
   
   ... gives the error 
   
   ld: cannot find -lkde4support
  
  So... most of the FooConfig.cmake files appear to call out to an
  equivalent FooTarget.cmake file, which in turn loads something like
  FooTarget-debug.cmake, which appears to set target properties telling
  cmake where to find the libraries in question.
  
  kde4supportConfig.cmake does not do this.  In fact, it even has an
  include line for a targets file commented out.
  
  I guess this could be the reason?
 
 Yes.
 I'll have a look tomorrow how to do it properly, whether fix
 kde4supportConfig.cmake or whether to put the kde4support target into
 KDELibs4Config.cmake, depending on the dependencies.

kde4support still links e.g. against kdeui and kio.
So I think I'll make it part of KDELibs4 for now. 
So no
find_package(KDE4Support)
for now,
but find_package(KDELibs4)
and after that you'll be able to use the kde4support imported target 
directly or somne LIBRARY variable.

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: linking to kde4support (Re: KF5 Update Meeting Minutes 2013-w27)

2013-07-05 Thread Alex Merry
On 04/07/13 22:44, David Faure wrote:
 diff --git a/src/plasmapkg/CMakeLists.txt b/src/plasmapkg/CMakeLists.txt
 index d2f2427..919dd64 100644
 --- a/src/plasmapkg/CMakeLists.txt
 +++ b/src/plasmapkg/CMakeLists.txt
 @@ -5,7 +5,7 @@ add_executable(plasmapkg
  plasmapkg.cpp
  )
  
 -target_link_libraries(plasmapkg kdeqt5staging plasma)
 +target_link_libraries(plasmapkg kdeqt5staging plasma kde4support)
  
  message(INSTALL_TARGETS_DEFAULT_ARGS ${INSTALL_TARGETS_DEFAULT_ARGS})
 
 ... gives the error 
 
 ld: cannot find -lkde4support

So... most of the FooConfig.cmake files appear to call out to an
equivalent FooTarget.cmake file, which in turn loads something like
FooTarget-debug.cmake, which appears to set target properties telling
cmake where to find the libraries in question.

kde4supportConfig.cmake does not do this.  In fact, it even has an
include line for a targets file commented out.

I guess this could be the reason?

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


linking to kde4support (Re: KF5 Update Meeting Minutes 2013-w27)

2013-07-04 Thread David Faure
Le mercredi 3 juillet 2013 21:55:29 Alexander Neundorf a écrit :
 On Tuesday 02 July 2013, Alexander Neundorf wrote:
  On Tuesday 02 July 2013, Kevin Ottens wrote:
* [steveire] investigate why kde4support isn't usable from outside
kdelibs (issue with the cmake file)
  
  what's the issue here ?
  Without looking in detail, this will be a mess while we have the mixture
  of already-split and still-monolithic libraries.
 
 So, what you try to do actually ?
 Use kde4support separately from KDELibs4 ?

I tried to link one of the plasma-framework apps to kde4support, and it gave 
an error about not finding it.
(I ported the code away from kde4support instead, which is why we're not 
hitting this issue yet).

More details:

Even though 
find_package(kde4support REQUIRED NO_MODULE)
is in the toplevel CMakeLists.txt and finds it, this patch:

diff --git a/src/plasmapkg/CMakeLists.txt b/src/plasmapkg/CMakeLists.txt
index d2f2427..919dd64 100644
--- a/src/plasmapkg/CMakeLists.txt
+++ b/src/plasmapkg/CMakeLists.txt
@@ -5,7 +5,7 @@ add_executable(plasmapkg
 plasmapkg.cpp
 )
 
-target_link_libraries(plasmapkg kdeqt5staging plasma)
+target_link_libraries(plasmapkg kdeqt5staging plasma kde4support)
 
 message(INSTALL_TARGETS_DEFAULT_ARGS ${INSTALL_TARGETS_DEFAULT_ARGS})

... gives the error 

ld: cannot find -lkde4support

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: KF5 Update Meeting Minutes 2013-w27

2013-07-03 Thread Sune Vuorela
On 2013-07-02, Alexander Neundorf neund...@kde.org wrote:
 E.g. kplotting and kwidgets have the same dependencies. I wouldn't mind 
 having 
 kplotting as part of kwidgets.

I do think that consideratiotns like these are very important, but I
also think we should wait with looking at merging them just a bit until
we are a bit further in the splitting.

And I do agree that if kplotting and kwidgets have the same dependencies
and none of them are absurdely large, they should probably be merged.

/Sune

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: KF5 Update Meeting Minutes 2013-w27

2013-07-03 Thread Alexander Neundorf
On Tuesday 02 July 2013, Alexander Neundorf wrote:
 On Tuesday 02 July 2013, Kevin Ottens wrote:
  Hello everyone,
  
  This is the minutes of the Week 27 KF5 meeting. As usual it has been held
  on #kde-devel at 4pm Paris time.
  
  Were present: apol, ben2367, dfaure, R_Rios, sandsmark, scarpino, sebas,
  wojtask9 and myself.
 
 ...
 
   * [steveire] investigate why kde4support isn't usable from outside
   kdelibs
   
 (issue with the cmake file)
 
 what's the issue here ?
 Without looking in detail, this will be a mess while we have the mixture of
 already-split and still-monolithic libraries.

So, what you try to do actually ?
Use kde4support separately from KDELibs4 ?

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: KF5 Update Meeting Minutes 2013-w27

2013-07-02 Thread Alexander Neundorf
On Tuesday 02 July 2013, Kevin Ottens wrote:
 Hello everyone,
 
 This is the minutes of the Week 27 KF5 meeting. As usual it has been held
 on #kde-devel at 4pm Paris time.
 
 Were present: apol, ben2367, dfaure, R_Rios, sandsmark, scarpino, sebas,
 wojtask9 and myself.
...
  * [steveire] investigate why kde4support isn't usable from outside kdelibs
(issue with the cmake file)

what's the issue here ?
Without looking in detail, this will be a mess while we have the mixture of 
already-split and still-monolithic libraries.

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel