Re: KFileAudioPreview
On Monday 12 May 2014 19:18:17 Nicolás Alvarez wrote: 2014-05-12 18:46 GMT-03:00 Alex Merry alex.me...@kde.org: Perhaps it's too late to change this, but it seems to me that this plugin should either be in KIO or kio-extras. The reason it isn't in KIO is that it depends on Phonon. KIO already depends indirectly on KNotifications which depends on Phonon. But maybe one day we'll have a notification framework in Qt, and then KIO won't depend on Phonon anymore :-) Let's put KFileAudioPreview in kio-extras. KIO works perfectly well without it, it's not a mandatory runtime dependency. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KFileAudioPreview
On 14/05/14 08:52, David Faure wrote: On Monday 12 May 2014 19:18:17 Nicolás Alvarez wrote: 2014-05-12 18:46 GMT-03:00 Alex Merry alex.me...@kde.org: Perhaps it's too late to change this, but it seems to me that this plugin should either be in KIO or kio-extras. The reason it isn't in KIO is that it depends on Phonon. KIO already depends indirectly on KNotifications which depends on Phonon. But maybe one day we'll have a notification framework in Qt, and then KIO won't depend on Phonon anymore :-) Let's put KFileAudioPreview in kio-extras. KIO works perfectly well without it, it's not a mandatory runtime dependency. Done, and I've filed a ticket to remove the kfileaudiopreview repository. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KFileAudioPreview
2014-05-12 18:46 GMT-03:00 Alex Merry alex.me...@kde.org: Perhaps it's too late to change this, but it seems to me that this plugin should either be in KIO or kio-extras. The reason it isn't in KIO is that it depends on Phonon. KIO already depends indirectly on KNotifications which depends on Phonon. -- Nicolás ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KFileAudioPreview
On 12/05/14 23:18, Nicolás Alvarez wrote: 2014-05-12 18:46 GMT-03:00 Alex Merry alex.me...@kde.org: Perhaps it's too late to change this, but it seems to me that this plugin should either be in KIO or kio-extras. The reason it isn't in KIO is that it depends on Phonon. KIO already depends indirectly on KNotifications which depends on Phonon. In which case, putting it in KIO is also an option. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KFileAudioPreview
On Monday 12 May 2014 22:46:08 Alex Merry wrote: KFileAudioPreview is currently a framework that just provides a plugin. This plugin is specifically looked for by the KFileMetaPreview class in KIO. Perhaps it's too late to change this, but it seems to me that this plugin should either be in KIO or kio-extras. The reason it isn't in KIO is that it depends on Phonon. So: should we put it in kio-extras, now that that is an option? I'm OK with both solutions. Make sure to run them through David first, and don't wait, we'd rather have this move very soon now. Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
