Re: KPeople/ECM/KConfig build regression

2020-02-07 Thread Ben Cooksley
On Sat, Feb 8, 2020 at 10:20 AM David Faure  wrote:
>
> On vendredi 7 février 2020 19:03:35 CET Ben Cooksley wrote:
> > Hi all,
> >
> > Recently i've observed that a dependency build has started to fail
> > (along with some other Binary Factory builds) due to the following
> > message:
> >
> > CMake Error at
> > /usr/home/jenkins/install-prefix/share/ECM/modules/ECMGeneratePriFile.cmake
> > :183 (get_target_property):
> > get_target_property() called with non-existent target "KF5ConfigCore".
> >   Call Stack (most recent call first):
> > src/widgets/CMakeLists.txt:75 (ecm_generate_pri_file)
> >
> > At the moment it seems not all Frameworks are affected, but KPeople
> > definitely is.
>
> There were copy/paste errors in those CMakeLists.txt.
> Nicolas Fella just fixed it.
>
> commit 94a255a820015a25179d35713995503dbb9bcf61 (HEAD -> master, origin/
> master, origin/HEAD)
> Author: Nicolas Fella 
> Date:   Fri Feb 7 19:11:00 2020 +0100
>
> fix pri file generation
>

Awesome, thanks for sorting this Nicolas!

> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
>
>

Cheers,
Ben


Re: KPeople/ECM/KConfig build regression

2020-02-07 Thread David Faure
On vendredi 7 février 2020 19:03:35 CET Ben Cooksley wrote:
> Hi all,
> 
> Recently i've observed that a dependency build has started to fail
> (along with some other Binary Factory builds) due to the following
> message:
> 
> CMake Error at
> /usr/home/jenkins/install-prefix/share/ECM/modules/ECMGeneratePriFile.cmake
> :183 (get_target_property):
> get_target_property() called with non-existent target "KF5ConfigCore".
>   Call Stack (most recent call first):
> src/widgets/CMakeLists.txt:75 (ecm_generate_pri_file)
> 
> At the moment it seems not all Frameworks are affected, but KPeople
> definitely is.

There were copy/paste errors in those CMakeLists.txt.
Nicolas Fella just fixed it.

commit 94a255a820015a25179d35713995503dbb9bcf61 (HEAD -> master, origin/
master, origin/HEAD)
Author: Nicolas Fella 
Date:   Fri Feb 7 19:11:00 2020 +0100

fix pri file generation

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5