Re: Porting the NETWM classes to xcb

2012-06-26 Thread David Faure
On Wednesday 04 April 2012 00:27:34 Fredrik Höglund wrote:
 It's apparently also an issue that some Linux distributions are shipping
 old versions of xcb that are missing some of the libraries the cmake
 test checks for. 

I tried compiling your netwm-xcb changes (merged onto kdelibs-4.9), but it 
fails to find xcb_util.h (and the associated pkgconfig module).

(The all-in-one PKG_CHECK_MODULES makes diagnosing this a bit difficult btw.
Removing QUIET helps, though:
 package 'xcb-util' not found
 package 'xcb-ewmh' not found
)

 Right now the only library kdelibs is using is the core
 xcb library. This will change over time though, so I'm not sure what the
 best way is to deal with this.

Quick fix: comment out everything else ;)

Longer term fix: ask kde-buildsystem for the proper way to do this. Probably 
something related to the user of FindXCB.cmake asking for the modules that it 
needs. There's obviously support for that in cmake, but I don't know the exact 
details. Something with FIND_PACKAGE(XCB COMPONENTS ). See 
FindSoprano.cmake for an example. The list could get quite long, but most code 
won't need all modules, right?

CC'ing kde-buildsystem for help.
Just in case the example I found is outdated :)

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Porting the NETWM classes to xcb

2012-03-25 Thread Christoph Feck
On Sunday 25 March 2012 19:49:29 Fredrik Höglund wrote:
 I've pushed a branch to my kdelibs clone which ports all the Xlib
 code in the NETWM classes to xcb. [...]

Nice, thanks :)

 The branch is available at:
 git://anongit.kde.org/clones/kdelibs/fredrik/kdelibs.git netwm-xcb
 [...]
 kdeui/windowmanagement/netwm.h   |4 +

Is it really required to expose xcb headers to applications, that wish 
to use the netwm header file? If not, please move to netwm_p.h file.

Christoph Feck (kdepepo)
KDE Quality Team
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Porting the NETWM classes to xcb

2012-03-25 Thread Fredrik Höglund
On Sunday 25 March 2012, Christoph Feck wrote:
 Is it really required to expose xcb headers to applications, that wish 
 to use the netwm header file? If not, please move to netwm_p.h file.

The idea is to eventually replace the Xlib types used in the parameters
to the constructors and methods in these classes with their equivalent
xcb types, and then stop including the Xlib headers.  Unlike the Xlib
headers, the xcb headers don't pollute the global namespace.

But you have a point in that nothing in the public headers depends
on the xcb headers yet, so at the moment there's no need to include
them there.

Fredrik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel