Re: Review Request 112797: Bring back KStringHandler::naturalCompare()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review41449 --- Ship it! Ship It! - Kevin Ottens On Oct. 4, 2013, 5:26 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112797/ > --- > > (Updated Oct. 4, 2013, 5:26 p.m.) > > > Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser. > > > Repository: kdelibs > > > Description > --- > > Apparently there's people who still want to have it. Leave it in KCoreAddons > for the moment, until we decide that it can be replaced for good by QCollator. > > > Diffs > - > > KDE5PORTING.html 88700b0 > staging/kde4support/autotests/CMakeLists.txt 473bdba > staging/kde4support/autotests/naturalcomparetest.cpp PRE-CREATION > staging/kde4support/src/CMakeLists.txt 51519a3 > staging/kde4support/src/kdecore/kstringhandler_deprecated.h PRE-CREATION > staging/kde4support/src/kdecore/kstringhandler_deprecated.cpp PRE-CREATION > tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 > tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a > tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 > > Diff: http://git.reviewboard.kde.org/r/112797/diff/ > > > Testing > --- > > Builds, tests pass. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112797: Bring back KStringHandler::naturalCompare()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review41463 --- This review has been submitted with commit 7bfff9a0e10a71adf9aaa92ddac85f05a6a86bad by Aleix Pol to branch frameworks. - Commit Hook On Oct. 4, 2013, 5:26 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112797/ > --- > > (Updated Oct. 4, 2013, 5:26 p.m.) > > > Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser. > > > Repository: kdelibs > > > Description > --- > > Apparently there's people who still want to have it. Leave it in KCoreAddons > for the moment, until we decide that it can be replaced for good by QCollator. > > > Diffs > - > > KDE5PORTING.html 88700b0 > staging/kde4support/autotests/CMakeLists.txt 473bdba > staging/kde4support/autotests/naturalcomparetest.cpp PRE-CREATION > staging/kde4support/src/CMakeLists.txt 51519a3 > staging/kde4support/src/kdecore/kstringhandler_deprecated.h PRE-CREATION > staging/kde4support/src/kdecore/kstringhandler_deprecated.cpp PRE-CREATION > tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 > tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a > tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 > > Diff: http://git.reviewboard.kde.org/r/112797/diff/ > > > Testing > --- > > Builds, tests pass. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112797: Bring back KStringHandler::naturalCompare()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/ --- (Updated Oct. 9, 2013, 6:07 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser. Repository: kdelibs Description --- Apparently there's people who still want to have it. Leave it in KCoreAddons for the moment, until we decide that it can be replaced for good by QCollator. Diffs - KDE5PORTING.html 88700b0 staging/kde4support/autotests/CMakeLists.txt 473bdba staging/kde4support/autotests/naturalcomparetest.cpp PRE-CREATION staging/kde4support/src/CMakeLists.txt 51519a3 staging/kde4support/src/kdecore/kstringhandler_deprecated.h PRE-CREATION staging/kde4support/src/kdecore/kstringhandler_deprecated.cpp PRE-CREATION tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 Diff: http://git.reviewboard.kde.org/r/112797/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112797: Bring back KStringHandler::naturalCompare()
> On Sept. 18, 2013, 5:23 p.m., Mark Gaiser wrote: > > Posting the same here as i just said in your other review request. (I > > didn't see this one) > > Idea: restore naturalCompare as it was and add a "collatorNaturalCompare" > > that is taking the QCollator route. That way it's easily testable as well. > > > > I think we can all agree on that, right? ** posting again as well... ** I don't think creating such function would be a good thing because it means using QCollator the wrong way. I much rather prefer working on tools to properly use QCollator, for example by making it possible to sort things with the sort key instead of QCollator::compare which will be the place where we can actually test performance. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review40289 --- On Sept. 18, 2013, 4:55 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112797/ > --- > > (Updated Sept. 18, 2013, 4:55 p.m.) > > > Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser. > > > Description > --- > > Apparently there's people who still want to have it. Leave it in KCoreAddons > for the moment, until we decide that it can be replaced for good by QCollator. > > > Diffs > - > > tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 > tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a > tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 > > Diff: http://git.reviewboard.kde.org/r/112797/diff/ > > > Testing > --- > > Builds, tests pass. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112797: Bring back KStringHandler::naturalCompare()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review40289 --- Posting the same here as i just said in your other review request. (I didn't see this one) Idea: restore naturalCompare as it was and add a "collatorNaturalCompare" that is taking the QCollator route. That way it's easily testable as well. I think we can all agree on that, right? - Mark Gaiser On Sept. 18, 2013, 4:55 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112797/ > --- > > (Updated Sept. 18, 2013, 4:55 p.m.) > > > Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser. > > > Description > --- > > Apparently there's people who still want to have it. Leave it in KCoreAddons > for the moment, until we decide that it can be replaced for good by QCollator. > > > Diffs > - > > tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 > tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a > tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 > > Diff: http://git.reviewboard.kde.org/r/112797/diff/ > > > Testing > --- > > Builds, tests pass. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112797: Bring back KStringHandler::naturalCompare()
> On Sept. 18, 2013, 5:23 p.m., Mark Gaiser wrote: > > Posting the same here as i just said in your other review request. (I > > didn't see this one) > > Idea: restore naturalCompare as it was and add a "collatorNaturalCompare" > > that is taking the QCollator route. That way it's easily testable as well. > > > > I think we can all agree on that, right? > > Aleix Pol Gonzalez wrote: > ** posting again as well... ** > > I don't think creating such function would be a good thing because it > means using QCollator the wrong way. I much rather prefer working on tools to > properly use QCollator, for example by making it possible to sort things with > the sort key instead of QCollator::compare which will be the place where we > can actually test performance. True, but then it can't be used as a 1 on 1 replacement. Since QCollatorSortKey would first have to be generated for every string and stored in the list that is to be sorted (That would be the ItemData struct http://quickgit.kde.org/?p=kde-baseapps.git&a=blob&h=841016138c4a67691177ae9d759eae6399adc762&hb=7dde35ccb97ac2958e45fe6b0759901e02d5e5e3&f=dolphin%2Fsrc%2Fkitemviews%2Fkfileitemmodel.h from line 299). But yeah, that does seem like a very nice idea and close to an idea that was floating the kfm-devel list ~1 year ago which also involved adding some "precompiled" sort data in that very same structure to speed up sorting. Anyway, +1 from me but someone else must give a ship it. - Mark --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review40289 --- On Sept. 18, 2013, 4:55 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112797/ > --- > > (Updated Sept. 18, 2013, 4:55 p.m.) > > > Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser. > > > Description > --- > > Apparently there's people who still want to have it. Leave it in KCoreAddons > for the moment, until we decide that it can be replaced for good by QCollator. > > > Diffs > - > > tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 > tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a > tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 > > Diff: http://git.reviewboard.kde.org/r/112797/diff/ > > > Testing > --- > > Builds, tests pass. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112797: Bring back KStringHandler::naturalCompare()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review40341 --- Ship it! Now that i think of it again, why shouldn't i give a ship it? You only bring back code that was there a day ago :) - Mark Gaiser On Sept. 18, 2013, 4:55 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112797/ > --- > > (Updated Sept. 18, 2013, 4:55 p.m.) > > > Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser. > > > Description > --- > > Apparently there's people who still want to have it. Leave it in KCoreAddons > for the moment, until we decide that it can be replaced for good by QCollator. > > > Diffs > - > > tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 > tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a > tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 > > Diff: http://git.reviewboard.kde.org/r/112797/diff/ > > > Testing > --- > > Builds, tests pass. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112797: Bring back KStringHandler::naturalCompare()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review40520 --- Hmmm, why not bring it back in kde4support? We're talking about just reviving it temporarily for a couple of users who will ditch it as QCollator matures, right? - Kevin Ottens On Sept. 18, 2013, 4:55 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112797/ > --- > > (Updated Sept. 18, 2013, 4:55 p.m.) > > > Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser. > > > Description > --- > > Apparently there's people who still want to have it. Leave it in KCoreAddons > for the moment, until we decide that it can be replaced for good by QCollator. > > > Diffs > - > > tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 > tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a > tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 > > Diff: http://git.reviewboard.kde.org/r/112797/diff/ > > > Testing > --- > > Builds, tests pass. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112797: Bring back KStringHandler::naturalCompare()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/ --- (Updated Sept. 23, 2013, 1:45 p.m.) Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser. Changes --- Moves naturalCompare to kde4support/kdecore. The naturalCompare test goes together with it. Description --- Apparently there's people who still want to have it. Leave it in KCoreAddons for the moment, until we decide that it can be replaced for good by QCollator. Diffs (updated) - staging/kde4support/autotests/CMakeLists.txt 473bdba staging/kde4support/autotests/naturalcomparetest.cpp PRE-CREATION staging/kde4support/src/CMakeLists.txt 5dc206d staging/kde4support/src/kdecore/kstringhandler_deprecated.h PRE-CREATION staging/kde4support/src/kdecore/kstringhandler_deprecated.cpp PRE-CREATION tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 Diff: http://git.reviewboard.kde.org/r/112797/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112797: Bring back KStringHandler::naturalCompare()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review40632 --- Probably needs some porting notes in KDE5PORTING to point to QCollator. - Kevin Ottens On Sept. 23, 2013, 1:45 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112797/ > --- > > (Updated Sept. 23, 2013, 1:45 p.m.) > > > Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser. > > > Description > --- > > Apparently there's people who still want to have it. Leave it in KCoreAddons > for the moment, until we decide that it can be replaced for good by QCollator. > > > Diffs > - > > staging/kde4support/autotests/CMakeLists.txt 473bdba > staging/kde4support/autotests/naturalcomparetest.cpp PRE-CREATION > staging/kde4support/src/CMakeLists.txt 5dc206d > staging/kde4support/src/kdecore/kstringhandler_deprecated.h PRE-CREATION > staging/kde4support/src/kdecore/kstringhandler_deprecated.cpp PRE-CREATION > tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 > tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a > tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 > > Diff: http://git.reviewboard.kde.org/r/112797/diff/ > > > Testing > --- > > Builds, tests pass. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112797: Bring back KStringHandler::naturalCompare()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/ --- (Updated Sept. 24, 2013, 6:08 p.m.) Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser. Changes --- Add deprecation note in the API documentation. Description --- Apparently there's people who still want to have it. Leave it in KCoreAddons for the moment, until we decide that it can be replaced for good by QCollator. Diffs (updated) - staging/kde4support/autotests/CMakeLists.txt 473bdba staging/kde4support/autotests/naturalcomparetest.cpp PRE-CREATION staging/kde4support/src/CMakeLists.txt 5dc206d staging/kde4support/src/kdecore/kstringhandler_deprecated.h PRE-CREATION staging/kde4support/src/kdecore/kstringhandler_deprecated.cpp PRE-CREATION tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 Diff: http://git.reviewboard.kde.org/r/112797/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112797: Bring back KStringHandler::naturalCompare()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review41022 --- ping? - Aleix Pol Gonzalez On Sept. 24, 2013, 6:08 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112797/ > --- > > (Updated Sept. 24, 2013, 6:08 p.m.) > > > Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser. > > > Repository: kdelibs > > > Description > --- > > Apparently there's people who still want to have it. Leave it in KCoreAddons > for the moment, until we decide that it can be replaced for good by QCollator. > > > Diffs > - > > staging/kde4support/autotests/CMakeLists.txt 473bdba > staging/kde4support/autotests/naturalcomparetest.cpp PRE-CREATION > staging/kde4support/src/CMakeLists.txt 5dc206d > staging/kde4support/src/kdecore/kstringhandler_deprecated.h PRE-CREATION > staging/kde4support/src/kdecore/kstringhandler_deprecated.cpp PRE-CREATION > tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 > tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a > tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 > > Diff: http://git.reviewboard.kde.org/r/112797/diff/ > > > Testing > --- > > Builds, tests pass. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112797: Bring back KStringHandler::naturalCompare()
> On Sept. 30, 2013, 11:23 a.m., Aleix Pol Gonzalez wrote: > > ping? As before, i'm ok with it, but am not going to give another ship it :) That really is up to someone with in deep knowledge about kde4support to see if it makes sense where you placed it. - Mark --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review41022 --- On Sept. 24, 2013, 6:08 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112797/ > --- > > (Updated Sept. 24, 2013, 6:08 p.m.) > > > Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser. > > > Repository: kdelibs > > > Description > --- > > Apparently there's people who still want to have it. Leave it in KCoreAddons > for the moment, until we decide that it can be replaced for good by QCollator. > > > Diffs > - > > staging/kde4support/autotests/CMakeLists.txt 473bdba > staging/kde4support/autotests/naturalcomparetest.cpp PRE-CREATION > staging/kde4support/src/CMakeLists.txt 5dc206d > staging/kde4support/src/kdecore/kstringhandler_deprecated.h PRE-CREATION > staging/kde4support/src/kdecore/kstringhandler_deprecated.cpp PRE-CREATION > tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 > tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a > tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 > > Diff: http://git.reviewboard.kde.org/r/112797/diff/ > > > Testing > --- > > Builds, tests pass. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112797: Bring back KStringHandler::naturalCompare()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/#review41190 --- People porting code won't find the new header name. This needs to be documented in KDE5PORTING.html and in the real kstringhandler.h. - David Faure On Sept. 24, 2013, 6:08 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112797/ > --- > > (Updated Sept. 24, 2013, 6:08 p.m.) > > > Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser. > > > Repository: kdelibs > > > Description > --- > > Apparently there's people who still want to have it. Leave it in KCoreAddons > for the moment, until we decide that it can be replaced for good by QCollator. > > > Diffs > - > > staging/kde4support/autotests/CMakeLists.txt 473bdba > staging/kde4support/autotests/naturalcomparetest.cpp PRE-CREATION > staging/kde4support/src/CMakeLists.txt 5dc206d > staging/kde4support/src/kdecore/kstringhandler_deprecated.h PRE-CREATION > staging/kde4support/src/kdecore/kstringhandler_deprecated.cpp PRE-CREATION > tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 > tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a > tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 > > Diff: http://git.reviewboard.kde.org/r/112797/diff/ > > > Testing > --- > > Builds, tests pass. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112797: Bring back KStringHandler::naturalCompare()
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/ --- (Updated Oct. 4, 2013, 5:26 p.m.) Review request for KDE Frameworks, Frank Reininghaus and Mark Gaiser. Changes --- Add documentation in KDE5Porting.html Repository: kdelibs Description --- Apparently there's people who still want to have it. Leave it in KCoreAddons for the moment, until we decide that it can be replaced for good by QCollator. Diffs (updated) - KDE5PORTING.html 88700b0 staging/kde4support/autotests/CMakeLists.txt 473bdba staging/kde4support/autotests/naturalcomparetest.cpp PRE-CREATION staging/kde4support/src/CMakeLists.txt 51519a3 staging/kde4support/src/kdecore/kstringhandler_deprecated.h PRE-CREATION staging/kde4support/src/kdecore/kstringhandler_deprecated.cpp PRE-CREATION tier1/kcoreaddons/autotests/kstringhandlertest.cpp 93da351 tier1/kcoreaddons/src/lib/text/kstringhandler.h 442b97a tier1/kcoreaddons/src/lib/text/kstringhandler.cpp ea3bbf5 Diff: http://git.reviewboard.kde.org/r/112797/diff/ Testing --- Builds, tests pass. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
