Re: Review Request 112902: Start cleanup for kdewebkit

2013-09-23 Thread Kevin Ottens 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112902/#review40642
---



staging/kde4support/CMakeLists.txt


How is it related to the rest of the patch?



staging/kio/src/widgets/renamedialog.h


How is it related to the rest of the patch?


- Kevin Ottens


On Sept. 23, 2013, 5:27 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112902/
> ---
> 
> (Updated Sept. 23, 2013, 5:27 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Start to figure out the port of the cmake to KF5 standards.
> 
> 
> Diffs
> -
> 
>   kdewebkit/CMakeLists.txt cdc5835 
>   kdewebkit/kwebpage.cpp 73dd5a7 
>   staging/kde4support/CMakeLists.txt 24ee457 
>   staging/kio/src/widgets/renamedialog.h 9a14451 
> 
> Diff: http://git.reviewboard.kde.org/r/112902/diff/
> 
> 
> Testing
> ---
> 
> Builds, there are no tests.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112902: Start cleanup for kdewebkit

2013-09-24 Thread Aleix Pol Gonzalez 


> On Sept. 24, 2013, 6:58 a.m., Kevin Ottens wrote:
> > staging/kio/src/widgets/renamedialog.h, line 25
> > 
> >
> > How is it related to the rest of the patch?

KSqueezedTextLabel is in KWidgetsAddons which is not a public dependency of 
KIOWidgets, so it was not being found when building.

It's either that or make KWidgetsAddons public.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112902/#review40642
---


On Sept. 23, 2013, 5:27 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112902/
> ---
> 
> (Updated Sept. 23, 2013, 5:27 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Start to figure out the port of the cmake to KF5 standards.
> 
> 
> Diffs
> -
> 
>   kdewebkit/CMakeLists.txt cdc5835 
>   kdewebkit/kwebpage.cpp 73dd5a7 
>   staging/kde4support/CMakeLists.txt 24ee457 
>   staging/kio/src/widgets/renamedialog.h 9a14451 
> 
> Diff: http://git.reviewboard.kde.org/r/112902/diff/
> 
> 
> Testing
> ---
> 
> Builds, there are no tests.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112902: Start cleanup for kdewebkit

2013-09-24 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112902/
---

(Updated Sept. 24, 2013, 11:19 a.m.)


Review request for KDE Frameworks.


Changes
---

remove build fix, that is not part of the patch.


Description
---

Start to figure out the port of the cmake to KF5 standards.


Diffs (updated)
-

  staging/kio/src/widgets/renamedialog.h 9a14451 
  kdewebkit/kwebpage.cpp 73dd5a7 
  kdewebkit/CMakeLists.txt cdc5835 

Diff: http://git.reviewboard.kde.org/r/112902/diff/


Testing
---

Builds, there are no tests.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112902: Start cleanup for kdewebkit

2013-09-25 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112902/#review40742
---



kdewebkit/CMakeLists.txt


again this is not KUNITCONVERSION


- David Edmundson


On Sept. 24, 2013, 11:19 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112902/
> ---
> 
> (Updated Sept. 24, 2013, 11:19 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Start to figure out the port of the cmake to KF5 standards.
> 
> 
> Diffs
> -
> 
>   staging/kio/src/widgets/renamedialog.h 9a14451 
>   kdewebkit/kwebpage.cpp 73dd5a7 
>   kdewebkit/CMakeLists.txt cdc5835 
> 
> Diff: http://git.reviewboard.kde.org/r/112902/diff/
> 
> 
> Testing
> ---
> 
> Builds, there are no tests.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112902: Start cleanup for kdewebkit

2013-09-25 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112902/#review40743
---

Ship it!


Ship It!

- David Edmundson


On Sept. 24, 2013, 11:19 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112902/
> ---
> 
> (Updated Sept. 24, 2013, 11:19 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Start to figure out the port of the cmake to KF5 standards.
> 
> 
> Diffs
> -
> 
>   staging/kio/src/widgets/renamedialog.h 9a14451 
>   kdewebkit/kwebpage.cpp 73dd5a7 
>   kdewebkit/CMakeLists.txt cdc5835 
> 
> Diff: http://git.reviewboard.kde.org/r/112902/diff/
> 
> 
> Testing
> ---
> 
> Builds, there are no tests.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112902: Start cleanup for kdewebkit

2013-09-25 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112902/#review40770
---


This review has been submitted with commit 
0b8576352e9a8f161efff08faa39ccb830a0a774 by Aleix Pol to branch frameworks.

- Commit Hook


On Sept. 24, 2013, 11:19 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112902/
> ---
> 
> (Updated Sept. 24, 2013, 11:19 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Start to figure out the port of the cmake to KF5 standards.
> 
> 
> Diffs
> -
> 
>   staging/kio/src/widgets/renamedialog.h 9a14451 
>   kdewebkit/kwebpage.cpp 73dd5a7 
>   kdewebkit/CMakeLists.txt cdc5835 
> 
> Diff: http://git.reviewboard.kde.org/r/112902/diff/
> 
> 
> Testing
> ---
> 
> Builds, there are no tests.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112902: Start cleanup for kdewebkit

2013-09-25 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112902/#review40771
---


This review has been submitted with commit 
034d9987b24f858f3b63b34c28855bd2957cd0b3 by Aleix Pol to branch frameworks.

- Commit Hook


On Sept. 25, 2013, 3:31 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112902/
> ---
> 
> (Updated Sept. 25, 2013, 3:31 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> ---
> 
> Start to figure out the port of the cmake to KF5 standards.
> 
> 
> Diffs
> -
> 
>   staging/kio/src/widgets/renamedialog.h 9a14451 
>   kdewebkit/kwebpage.cpp 73dd5a7 
>   kdewebkit/CMakeLists.txt cdc5835 
> 
> Diff: http://git.reviewboard.kde.org/r/112902/diff/
> 
> 
> Testing
> ---
> 
> Builds, there are no tests.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112902: Start cleanup for kdewebkit

2013-09-25 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112902/
---

(Updated Sept. 25, 2013, 3:31 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Description
---

Start to figure out the port of the cmake to KF5 standards.


Diffs
-

  staging/kio/src/widgets/renamedialog.h 9a14451 
  kdewebkit/kwebpage.cpp 73dd5a7 
  kdewebkit/CMakeLists.txt cdc5835 

Diff: http://git.reviewboard.kde.org/r/112902/diff/


Testing
---

Builds, there are no tests.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel