Re: Review Request 115028: Inline deprecated KUser::fullName() method

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115028/
---

(Updated Feb. 6, 2014, 5:20 p.m.)


Review request for KDE Frameworks.


Changes
---

Remove option to disable deprecated symbols; inlined the one deprecated method.


Summary (updated)
-

Inline deprecated KUser::fullName() method


Repository: kcoreaddons


Description (updated)
---

Inline deprecated KUser::fullName() method


Use KCOREADDONS_NO_DEPRECATED instead of KDE_NO_DEPRECATED

KCOREADDONS_NO_DEPRECATED is the macro controlled by
generate_export_header; KDE_NO_DEPRECATED is left over from kdelibs.

Disable deprecation macro when building the library itself

This prevents spurious compiler warnings (particularly when slots are
deprecated).


Diffs (updated)
-

  src/lib/util/kuser.h 2b6e6ed92bc1465945f36f2fde821f36fa51585f 
  src/lib/util/kuser_unix.cpp 8a3a39d379ca863b4906bb01228c5e01a5b955b0 
  src/lib/util/kuser_win.cpp 6a6cbb1751bd569d8684f8e11add1ef304c0a94d 
  src/lib/CMakeLists.txt e48904dabe7b2790599c34673832b6ce38eab0e3 

Diff: https://git.reviewboard.kde.org/r/115028/diff/


Testing (updated)
---

configures, compiles, tests pass (well, except KDirWatch-FAM, which has never 
passed for me).


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115028: Inline deprecated KUser::fullName() method

[Kevin Ottens]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115028/#review50343
---



src/lib/CMakeLists.txt


Not sure about that... I don't think we want the library itself to use 
deprecated methods. So knowing about that through warnings would make sense.


- Kevin Ottens


On Feb. 6, 2014, 5:20 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115028/
> ---
> 
> (Updated Feb. 6, 2014, 5:20 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Inline deprecated KUser::fullName() method
> 
> 
> Use KCOREADDONS_NO_DEPRECATED instead of KDE_NO_DEPRECATED
> 
> KCOREADDONS_NO_DEPRECATED is the macro controlled by
> generate_export_header; KDE_NO_DEPRECATED is left over from kdelibs.
> 
> Disable deprecation macro when building the library itself
> 
> This prevents spurious compiler warnings (particularly when slots are
> deprecated).
> 
> 
> Diffs
> -
> 
>   src/lib/util/kuser.h 2b6e6ed92bc1465945f36f2fde821f36fa51585f 
>   src/lib/util/kuser_unix.cpp 8a3a39d379ca863b4906bb01228c5e01a5b955b0 
>   src/lib/util/kuser_win.cpp 6a6cbb1751bd569d8684f8e11add1ef304c0a94d 
>   src/lib/CMakeLists.txt e48904dabe7b2790599c34673832b6ce38eab0e3 
> 
> Diff: https://git.reviewboard.kde.org/r/115028/diff/
> 
> 
> Testing
> ---
> 
> configures, compiles, tests pass (well, except KDirWatch-FAM, which has never 
> passed for me).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115028: Inline deprecated KUser::fullName() method

[Alex Merry]

> On Feb. 20, 2014, 12:16 p.m., Kevin Ottens wrote:
> > src/lib/CMakeLists.txt, line 86
> > 
> >
> > Not sure about that... I don't think we want the library itself to use 
> > deprecated methods. So knowing about that through warnings would make sense.

This actually ends up making no difference for KCoreAddons.  Other frameworks 
have annoying false positives where there are deprecated slots, as these are 
used from the moc-generated code.  And also tests for deprecated methods.

Note that this would not silence warnings about using deprecated code from 
other libraries.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115028/#review50343
---


On Feb. 6, 2014, 5:20 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115028/
> ---
> 
> (Updated Feb. 6, 2014, 5:20 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Inline deprecated KUser::fullName() method
> 
> 
> Use KCOREADDONS_NO_DEPRECATED instead of KDE_NO_DEPRECATED
> 
> KCOREADDONS_NO_DEPRECATED is the macro controlled by
> generate_export_header; KDE_NO_DEPRECATED is left over from kdelibs.
> 
> Disable deprecation macro when building the library itself
> 
> This prevents spurious compiler warnings (particularly when slots are
> deprecated).
> 
> 
> Diffs
> -
> 
>   src/lib/util/kuser.h 2b6e6ed92bc1465945f36f2fde821f36fa51585f 
>   src/lib/util/kuser_unix.cpp 8a3a39d379ca863b4906bb01228c5e01a5b955b0 
>   src/lib/util/kuser_win.cpp 6a6cbb1751bd569d8684f8e11add1ef304c0a94d 
>   src/lib/CMakeLists.txt e48904dabe7b2790599c34673832b6ce38eab0e3 
> 
> Diff: https://git.reviewboard.kde.org/r/115028/diff/
> 
> 
> Testing
> ---
> 
> configures, compiles, tests pass (well, except KDirWatch-FAM, which has never 
> passed for me).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115028: Inline deprecated KUser::fullName() method

[David Faure]

> On Feb. 20, 2014, 12:16 p.m., Kevin Ottens wrote:
> > src/lib/CMakeLists.txt, line 86
> > 
> >
> > Not sure about that... I don't think we want the library itself to use 
> > deprecated methods. So knowing about that through warnings would make sense.
> 
> Alex Merry wrote:
> This actually ends up making no difference for KCoreAddons.  Other 
> frameworks have annoying false positives where there are deprecated slots, as 
> these are used from the moc-generated code.  And also tests for deprecated 
> methods.
> 
> Note that this would not silence warnings about using deprecated code 
> from other libraries.

If it makes no difference for kcoreaddons, let's leave deprecation warnings 
enabled (in case we deprecate something else later).
But indeed in the frameworks where it's not fixable (deprecated slots), we 
could add such a line, with a comment about why.
False positives are annoying and can make people ignore real issues.

Unittest for deprecated code... maybe we can add the definition (to disable 
warnings) *just* for these tests, after splitting them out...


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115028/#review50343
---


On Feb. 6, 2014, 5:20 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115028/
> ---
> 
> (Updated Feb. 6, 2014, 5:20 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Inline deprecated KUser::fullName() method
> 
> 
> Use KCOREADDONS_NO_DEPRECATED instead of KDE_NO_DEPRECATED
> 
> KCOREADDONS_NO_DEPRECATED is the macro controlled by
> generate_export_header; KDE_NO_DEPRECATED is left over from kdelibs.
> 
> Disable deprecation macro when building the library itself
> 
> This prevents spurious compiler warnings (particularly when slots are
> deprecated).
> 
> 
> Diffs
> -
> 
>   src/lib/util/kuser.h 2b6e6ed92bc1465945f36f2fde821f36fa51585f 
>   src/lib/util/kuser_unix.cpp 8a3a39d379ca863b4906bb01228c5e01a5b955b0 
>   src/lib/util/kuser_win.cpp 6a6cbb1751bd569d8684f8e11add1ef304c0a94d 
>   src/lib/CMakeLists.txt e48904dabe7b2790599c34673832b6ce38eab0e3 
> 
> Diff: https://git.reviewboard.kde.org/r/115028/diff/
> 
> 
> Testing
> ---
> 
> configures, compiles, tests pass (well, except KDirWatch-FAM, which has never 
> passed for me).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115028: Inline deprecated KUser::fullName() method

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115028/
---

(Updated Feb. 22, 2014, 5:28 p.m.)


Review request for KDE Frameworks.


Changes
---

Do not disable internal deprecated warnings.


Repository: kcoreaddons


Description (updated)
---

Inline deprecated KUser::fullName() method


Use KCOREADDONS_NO_DEPRECATED instead of KDE_NO_DEPRECATED

KCOREADDONS_NO_DEPRECATED is the macro controlled by
generate_export_header; KDE_NO_DEPRECATED is left over from kdelibs.


Diffs (updated)
-

  src/lib/util/kuser.h 2b6e6ed92bc1465945f36f2fde821f36fa51585f 
  src/lib/util/kuser_unix.cpp 8a3a39d379ca863b4906bb01228c5e01a5b955b0 
  src/lib/util/kuser_win.cpp 6a6cbb1751bd569d8684f8e11add1ef304c0a94d 

Diff: https://git.reviewboard.kde.org/r/115028/diff/


Testing
---

configures, compiles, tests pass (well, except KDirWatch-FAM, which has never 
passed for me).


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115028: Inline deprecated KUser::fullName() method

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115028/#review50554
---

Ship it!


Ship It!

- David Faure


On Feb. 22, 2014, 5:28 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115028/
> ---
> 
> (Updated Feb. 22, 2014, 5:28 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Inline deprecated KUser::fullName() method
> 
> 
> Use KCOREADDONS_NO_DEPRECATED instead of KDE_NO_DEPRECATED
> 
> KCOREADDONS_NO_DEPRECATED is the macro controlled by
> generate_export_header; KDE_NO_DEPRECATED is left over from kdelibs.
> 
> 
> Diffs
> -
> 
>   src/lib/util/kuser.h 2b6e6ed92bc1465945f36f2fde821f36fa51585f 
>   src/lib/util/kuser_unix.cpp 8a3a39d379ca863b4906bb01228c5e01a5b955b0 
>   src/lib/util/kuser_win.cpp 6a6cbb1751bd569d8684f8e11add1ef304c0a94d 
> 
> Diff: https://git.reviewboard.kde.org/r/115028/diff/
> 
> 
> Testing
> ---
> 
> configures, compiles, tests pass (well, except KDirWatch-FAM, which has never 
> passed for me).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115028: Inline deprecated KUser::fullName() method

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115028/#review50577
---


This review has been submitted with commit 
88a0d9828aa5b7e108ac259e1d60f38061c93027 by Alex Merry to branch master.

- Commit Hook


On Feb. 22, 2014, 5:28 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115028/
> ---
> 
> (Updated Feb. 22, 2014, 5:28 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Inline deprecated KUser::fullName() method
> 
> 
> Use KCOREADDONS_NO_DEPRECATED instead of KDE_NO_DEPRECATED
> 
> KCOREADDONS_NO_DEPRECATED is the macro controlled by
> generate_export_header; KDE_NO_DEPRECATED is left over from kdelibs.
> 
> 
> Diffs
> -
> 
>   src/lib/util/kuser.h 2b6e6ed92bc1465945f36f2fde821f36fa51585f 
>   src/lib/util/kuser_unix.cpp 8a3a39d379ca863b4906bb01228c5e01a5b955b0 
>   src/lib/util/kuser_win.cpp 6a6cbb1751bd569d8684f8e11add1ef304c0a94d 
> 
> Diff: https://git.reviewboard.kde.org/r/115028/diff/
> 
> 
> Testing
> ---
> 
> configures, compiles, tests pass (well, except KDirWatch-FAM, which has never 
> passed for me).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115028: Inline deprecated KUser::fullName() method

[Commit Hook]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115028/#review50576
---


This review has been submitted with commit 
fa5a6e77b6f0d70fc7dbe781c9d15a377d35e786 by Alex Merry to branch master.

- Commit Hook


On Feb. 22, 2014, 5:28 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115028/
> ---
> 
> (Updated Feb. 22, 2014, 5:28 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Inline deprecated KUser::fullName() method
> 
> 
> Use KCOREADDONS_NO_DEPRECATED instead of KDE_NO_DEPRECATED
> 
> KCOREADDONS_NO_DEPRECATED is the macro controlled by
> generate_export_header; KDE_NO_DEPRECATED is left over from kdelibs.
> 
> 
> Diffs
> -
> 
>   src/lib/util/kuser.h 2b6e6ed92bc1465945f36f2fde821f36fa51585f 
>   src/lib/util/kuser_unix.cpp 8a3a39d379ca863b4906bb01228c5e01a5b955b0 
>   src/lib/util/kuser_win.cpp 6a6cbb1751bd569d8684f8e11add1ef304c0a94d 
> 
> Diff: https://git.reviewboard.kde.org/r/115028/diff/
> 
> 
> Testing
> ---
> 
> configures, compiles, tests pass (well, except KDirWatch-FAM, which has never 
> passed for me).
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115028: Inline deprecated KUser::fullName() method

[Alex Merry]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115028/
---

(Updated Feb. 23, 2014, 11:53 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kcoreaddons


Description
---

Inline deprecated KUser::fullName() method


Use KCOREADDONS_NO_DEPRECATED instead of KDE_NO_DEPRECATED

KCOREADDONS_NO_DEPRECATED is the macro controlled by
generate_export_header; KDE_NO_DEPRECATED is left over from kdelibs.


Diffs
-

  src/lib/util/kuser.h 2b6e6ed92bc1465945f36f2fde821f36fa51585f 
  src/lib/util/kuser_unix.cpp 8a3a39d379ca863b4906bb01228c5e01a5b955b0 
  src/lib/util/kuser_win.cpp 6a6cbb1751bd569d8684f8e11add1ef304c0a94d 

Diff: https://git.reviewboard.kde.org/r/115028/diff/


Testing
---

configures, compiles, tests pass (well, except KDirWatch-FAM, which has never 
passed for me).


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel