Re: Review Request 115394: Split KCompletionBase from kcompletion.h
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115394/#review48605 --- Looks good. Minor nitpicks: - I would use `#include ` instead of `#include "kcompletionbase.h"` for consistency - I would group the includes with the other kcompletion includes, except for kcompletionbase.cpp where it makes sense to include kcompletionbase.h first, to ensure kcompletionbase.h is self-contained. - Aurélien Gâteau On Jan. 30, 2014, 12:16 a.m., David Gil Oliva wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115394/ > --- > > (Updated Jan. 30, 2014, 12:16 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kcompletion > > > Description > --- > > To make kcompletion.h smaller, split KCompletionBase class from it into its > own header file. > > > Diffs > - > > src/klineedit.h f1107e2 > src/kcompletionbase.cpp 252b613 > src/kcompletion.h fa0731e > src/kcompletionbase.h PRE-CREATION > src/CMakeLists.txt 05452ab > src/kcombobox.h f34d259 > > Diff: https://git.reviewboard.kde.org/r/115394/diff/ > > > Testing > --- > > It builds. Tests pass. > > > Thanks, > > David Gil Oliva > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115394: Split KCompletionBase from kcompletion.h
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115394/ --- (Updated Jan. 30, 2014, 10:59 p.m.) Review request for KDE Frameworks. Changes --- Fix issues noted by Aurélien Gâteau Repository: kcompletion Description --- To make kcompletion.h smaller, split KCompletionBase class from it into its own header file. Diffs (updated) - src/klineedit.h f1107e2 src/kcompletionbase.h PRE-CREATION src/kcompletionbase.cpp 252b613 src/kcompletion.h fa0731e src/kcombobox.h f34d259 src/CMakeLists.txt 05452ab Diff: https://git.reviewboard.kde.org/r/115394/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115394: Split KCompletionBase from kcompletion.h
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115394/#review48678 --- Ship it! Had to redo the changes in kcompletion.h because of a conflict, but it works fine. - Aurélien Gâteau On Jan. 30, 2014, 11:59 p.m., David Gil Oliva wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115394/ > --- > > (Updated Jan. 30, 2014, 11:59 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcompletion > > > Description > --- > > To make kcompletion.h smaller, split KCompletionBase class from it into its > own header file. > > > Diffs > - > > src/klineedit.h f1107e2 > src/kcompletionbase.h PRE-CREATION > src/kcompletionbase.cpp 252b613 > src/kcompletion.h fa0731e > src/kcombobox.h f34d259 > src/CMakeLists.txt 05452ab > > Diff: https://git.reviewboard.kde.org/r/115394/diff/ > > > Testing > --- > > It builds. Tests pass. > > > Thanks, > > David Gil Oliva > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115394: Split KCompletionBase from kcompletion.h
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115394/ --- (Updated Jan. 31, 2014, 10:53 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kcompletion Description --- To make kcompletion.h smaller, split KCompletionBase class from it into its own header file. Diffs - src/klineedit.h f1107e2 src/kcompletionbase.h PRE-CREATION src/kcompletionbase.cpp 252b613 src/kcompletion.h fa0731e src/kcombobox.h f34d259 src/CMakeLists.txt 05452ab Diff: https://git.reviewboard.kde.org/r/115394/diff/ Testing --- It builds. Tests pass. Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115394: Split KCompletionBase from kcompletion.h
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115394/#review48729 --- This review has been submitted with commit 8d09dc6b245f83650c75db397fd3c2c180639ff2 by David Gil to branch master. - Commit Hook On Jan. 30, 2014, 10:59 p.m., David Gil Oliva wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115394/ > --- > > (Updated Jan. 30, 2014, 10:59 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcompletion > > > Description > --- > > To make kcompletion.h smaller, split KCompletionBase class from it into its > own header file. > > > Diffs > - > > src/klineedit.h f1107e2 > src/kcompletionbase.h PRE-CREATION > src/kcompletionbase.cpp 252b613 > src/kcompletion.h fa0731e > src/kcombobox.h f34d259 > src/CMakeLists.txt 05452ab > > Diff: https://git.reviewboard.kde.org/r/115394/diff/ > > > Testing > --- > > It builds. Tests pass. > > > Thanks, > > David Gil Oliva > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
