Re: Review Request 116699: No longer use pid_t or Q_PID
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116699/#review53314 --- This review has been submitted with commit d1b2b0de8bf138c486be1540cd054e30889215af by Alex Richardson to branch master. - Commit Hook On March 12, 2014, 7:36 a.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116699/ --- (Updated March 12, 2014, 7:36 a.m.) Review request for KDE Frameworks, David Faure and Oswald Buddenhagen. Repository: kio Description --- No longer use pid_t or Q_PID Instead use a new typedef KIO::ProcessId. This is needed for Windows where pid_t doesn't exist and Q_PID is actually a pointer to a structure Diffs - src/core/global.h 7814a52c9656719d301ebd012434a53491ffe159 src/core/idleslave.h d3e7add4460d38212858666afa22deb3e5ef8687 src/core/idleslave.cpp 31d145e5d5e0c4205eb7deec6de7677061bb8a25 src/core/scheduler.h 593174e770d24c6ef813d91dfb6d6ed716bba4f9 src/core/scheduler.cpp 5a4ad310e34587249e0b50c67e011d516858e130 src/core/slave.h e4a443d191faefa535072d3821bb84cb6ab55909 src/core/slave.cpp 404a0c20f57e7c2badd7ac9c1294224d59960f7c src/core/slavebase.cpp a32c6b6ad2b803e24c1db75321aefb916678c03d src/core/slaveinterface.h 1ee7c1aebbf29271da605f33a5587974a4e71a5b src/core/slaveinterface.cpp f8d7d52864ab6dd11316a1252fbd1e372f7f9ee2 src/widgets/krun.cpp 34708cc5a4b4cf3627deb750020104dd3593ef92 src/widgets/krun_p.h cf44e327e6d5bac0fa69b989bd6036380fc5180c Diff: https://git.reviewboard.kde.org/r/116699/diff/ Testing --- tests still pass Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116699: No longer use pid_t or Q_PID
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116699/ --- (Updated March 18, 2014, 12:19 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, David Faure and Oswald Buddenhagen. Repository: kio Description --- No longer use pid_t or Q_PID Instead use a new typedef KIO::ProcessId. This is needed for Windows where pid_t doesn't exist and Q_PID is actually a pointer to a structure Diffs - src/core/global.h 7814a52c9656719d301ebd012434a53491ffe159 src/core/idleslave.h d3e7add4460d38212858666afa22deb3e5ef8687 src/core/idleslave.cpp 31d145e5d5e0c4205eb7deec6de7677061bb8a25 src/core/scheduler.h 593174e770d24c6ef813d91dfb6d6ed716bba4f9 src/core/scheduler.cpp 5a4ad310e34587249e0b50c67e011d516858e130 src/core/slave.h e4a443d191faefa535072d3821bb84cb6ab55909 src/core/slave.cpp 404a0c20f57e7c2badd7ac9c1294224d59960f7c src/core/slavebase.cpp a32c6b6ad2b803e24c1db75321aefb916678c03d src/core/slaveinterface.h 1ee7c1aebbf29271da605f33a5587974a4e71a5b src/core/slaveinterface.cpp f8d7d52864ab6dd11316a1252fbd1e372f7f9ee2 src/widgets/krun.cpp 34708cc5a4b4cf3627deb750020104dd3593ef92 src/widgets/krun_p.h cf44e327e6d5bac0fa69b989bd6036380fc5180c Diff: https://git.reviewboard.kde.org/r/116699/diff/ Testing --- tests still pass Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116699: No longer use pid_t or Q_PID
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116699/#review53185 --- Anything blocking here? - Kevin Ottens On March 12, 2014, 7:36 a.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116699/ --- (Updated March 12, 2014, 7:36 a.m.) Review request for KDE Frameworks, David Faure and Oswald Buddenhagen. Repository: kio Description --- No longer use pid_t or Q_PID Instead use a new typedef KIO::ProcessId. This is needed for Windows where pid_t doesn't exist and Q_PID is actually a pointer to a structure Diffs - src/core/global.h 7814a52c9656719d301ebd012434a53491ffe159 src/core/idleslave.h d3e7add4460d38212858666afa22deb3e5ef8687 src/core/idleslave.cpp 31d145e5d5e0c4205eb7deec6de7677061bb8a25 src/core/scheduler.h 593174e770d24c6ef813d91dfb6d6ed716bba4f9 src/core/scheduler.cpp 5a4ad310e34587249e0b50c67e011d516858e130 src/core/slave.h e4a443d191faefa535072d3821bb84cb6ab55909 src/core/slave.cpp 404a0c20f57e7c2badd7ac9c1294224d59960f7c src/core/slavebase.cpp a32c6b6ad2b803e24c1db75321aefb916678c03d src/core/slaveinterface.h 1ee7c1aebbf29271da605f33a5587974a4e71a5b src/core/slaveinterface.cpp f8d7d52864ab6dd11316a1252fbd1e372f7f9ee2 src/widgets/krun.cpp 34708cc5a4b4cf3627deb750020104dd3593ef92 src/widgets/krun_p.h cf44e327e6d5bac0fa69b989bd6036380fc5180c Diff: https://git.reviewboard.kde.org/r/116699/diff/ Testing --- tests still pass Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116699: No longer use pid_t or Q_PID
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116699/#review52731 --- there is QProcess::processId() since 5.3 (replacing KProcess::pid()). it simply returns a somewhat wasteful qint64. you may want to follow the same practice. windows does of course not have a native getpid() function, but it is easy enough to replicate. - Oswald Buddenhagen On March 12, 2014, 7:36 a.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116699/ --- (Updated March 12, 2014, 7:36 a.m.) Review request for KDE Frameworks, David Faure and Oswald Buddenhagen. Repository: kio Description --- No longer use pid_t or Q_PID Instead use a new typedef KIO::ProcessId. This is needed for Windows where pid_t doesn't exist and Q_PID is actually a pointer to a structure Diffs - src/core/global.h 7814a52c9656719d301ebd012434a53491ffe159 src/core/idleslave.h d3e7add4460d38212858666afa22deb3e5ef8687 src/core/idleslave.cpp 31d145e5d5e0c4205eb7deec6de7677061bb8a25 src/core/scheduler.h 593174e770d24c6ef813d91dfb6d6ed716bba4f9 src/core/scheduler.cpp 5a4ad310e34587249e0b50c67e011d516858e130 src/core/slave.h e4a443d191faefa535072d3821bb84cb6ab55909 src/core/slave.cpp 404a0c20f57e7c2badd7ac9c1294224d59960f7c src/core/slavebase.cpp a32c6b6ad2b803e24c1db75321aefb916678c03d src/core/slaveinterface.h 1ee7c1aebbf29271da605f33a5587974a4e71a5b src/core/slaveinterface.cpp f8d7d52864ab6dd11316a1252fbd1e372f7f9ee2 src/widgets/krun.cpp 34708cc5a4b4cf3627deb750020104dd3593ef92 src/widgets/krun_p.h cf44e327e6d5bac0fa69b989bd6036380fc5180c Diff: https://git.reviewboard.kde.org/r/116699/diff/ Testing --- tests still pass Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116699: No longer use pid_t or Q_PID
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116699/ --- (Updated March 10, 2014, 5:51 p.m.) Review request for KDE Frameworks and David Faure. Changes --- Looks fine to me, but I'd rather see David have a say in it. Repository: kio Description --- No longer use pid_t or Q_PID Instead use a new typedef KIO::ProcessId. This is needed for Windows where pid_t doesn't exist and Q_PID is actually a pointer to a structure Diffs - src/core/global.h 7814a52c9656719d301ebd012434a53491ffe159 src/core/idleslave.h d3e7add4460d38212858666afa22deb3e5ef8687 src/core/idleslave.cpp 31d145e5d5e0c4205eb7deec6de7677061bb8a25 src/core/scheduler.h 593174e770d24c6ef813d91dfb6d6ed716bba4f9 src/core/scheduler.cpp 5a4ad310e34587249e0b50c67e011d516858e130 src/core/slave.h e4a443d191faefa535072d3821bb84cb6ab55909 src/core/slave.cpp 404a0c20f57e7c2badd7ac9c1294224d59960f7c src/core/slavebase.cpp a32c6b6ad2b803e24c1db75321aefb916678c03d src/core/slaveinterface.h 1ee7c1aebbf29271da605f33a5587974a4e71a5b src/core/slaveinterface.cpp f8d7d52864ab6dd11316a1252fbd1e372f7f9ee2 src/widgets/krun.cpp 34708cc5a4b4cf3627deb750020104dd3593ef92 src/widgets/krun_p.h cf44e327e6d5bac0fa69b989bd6036380fc5180c Diff: https://git.reviewboard.kde.org/r/116699/diff/ Testing --- tests still pass Thanks, Alexander Richardson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
