Re: Review Request 116781: List catalog from all install dirs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116781/#review52886 --- Ship it! Thank you; I can't test now but it looks sane; as a suggestion, I would explicitly mention that this is for "environments where each module is installed using a different prefix" as I wrote in the related commit (for https://git.reviewboard.kde.org/r/116670/). - Luigi Toscano On March 13, 2014, 12:59 p.m., Aurélien Gâteau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116781/ > --- > > (Updated March 13, 2014, 12:59 p.m.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Repository: kdoctools > > > Description > --- > > This makes sure that if XDG_DATA_DIRS contains kde4support install prefix and > then kdoctools install prefix, then kdoctools catalogs are listed > nevertheless. > > Should fix build of kde-workspace and kate on build.kde.org. > > > Diffs > - > > src/xslt.cpp 6d5819e > > Diff: https://git.reviewboard.kde.org/r/116781/diff/ > > > Testing > --- > > Rebuilt kde-runtime (was failing there), kate and kde-workspace. No build > failures. > > > Thanks, > > Aurélien Gâteau > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116781: List catalog from all install dirs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116781/ --- (Updated March 13, 2014, 1:47 p.m.) Review request for Documentation, KDE Frameworks and Luigi Toscano. Changes --- Improve comment. Repository: kdoctools Description --- This makes sure that if XDG_DATA_DIRS contains kde4support install prefix and then kdoctools install prefix, then kdoctools catalogs are listed nevertheless. Should fix build of kde-workspace and kate on build.kde.org. Diffs (updated) - src/xslt.cpp 6d5819e Diff: https://git.reviewboard.kde.org/r/116781/diff/ Testing --- Rebuilt kde-runtime (was failing there), kate and kde-workspace. No build failures. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116781: List catalog from all install dirs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116781/#review52890 --- This review has been submitted with commit 02478b34df416862c50da8186742491bd29012e8 by Aurélien Gâteau to branch master. - Commit Hook On March 13, 2014, 12:47 p.m., Aurélien Gâteau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116781/ > --- > > (Updated March 13, 2014, 12:47 p.m.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Repository: kdoctools > > > Description > --- > > This makes sure that if XDG_DATA_DIRS contains kde4support install prefix and > then kdoctools install prefix, then kdoctools catalogs are listed > nevertheless. > > Should fix build of kde-workspace and kate on build.kde.org. > > > Diffs > - > > src/xslt.cpp 6d5819e > > Diff: https://git.reviewboard.kde.org/r/116781/diff/ > > > Testing > --- > > Rebuilt kde-runtime (was failing there), kate and kde-workspace. No build > failures. > > > Thanks, > > Aurélien Gâteau > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116781: List catalog from all install dirs
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116781/ --- (Updated March 13, 2014, 1:01 p.m.) Status -- This change has been marked as submitted. Review request for Documentation, KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- This makes sure that if XDG_DATA_DIRS contains kde4support install prefix and then kdoctools install prefix, then kdoctools catalogs are listed nevertheless. Should fix build of kde-workspace and kate on build.kde.org. Diffs - src/xslt.cpp 6d5819e Diff: https://git.reviewboard.kde.org/r/116781/diff/ Testing --- Rebuilt kde-runtime (was failing there), kate and kde-workspace. No build failures. Thanks, Aurélien Gâteau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
