Re: Review Request 117040: Remove FIXME in KCompletion
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117040/#review54195 --- Ship it! Yeah, I don't see what the TODO is complaining about, really. - Alex Merry On March 24, 2014, 11:23 p.m., David Gil Oliva wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117040/ > --- > > (Updated March 24, 2014, 11:23 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcompletion > > > Description > --- > > Remove FIXME in KCompletion. > > I have revised the API and I think it makes sense as it is. > > > Diffs > - > > src/kcompletion.h 3b3b0a6 > > Diff: https://git.reviewboard.kde.org/r/117040/diff/ > > > Testing > --- > > > Thanks, > > David Gil Oliva > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117040: Remove FIXME in KCompletion
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117040/ --- (Updated March 26, 2014, 10:06 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kcompletion Description --- Remove FIXME in KCompletion. I have revised the API and I think it makes sense as it is. Diffs - src/kcompletion.h 3b3b0a6 Diff: https://git.reviewboard.kde.org/r/117040/diff/ Testing --- Thanks, David Gil Oliva ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 117040: Remove FIXME in KCompletion
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117040/#review54246 --- This review has been submitted with commit 2f6964af8763c9fed2f03fd5f833e76fffc5769d by David Gil to branch master. - Commit Hook On March 24, 2014, 11:23 p.m., David Gil Oliva wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117040/ > --- > > (Updated March 24, 2014, 11:23 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcompletion > > > Description > --- > > Remove FIXME in KCompletion. > > I have revised the API and I think it makes sense as it is. > > > Diffs > - > > src/kcompletion.h 3b3b0a6 > > Diff: https://git.reviewboard.kde.org/r/117040/diff/ > > > Testing > --- > > > Thanks, > > David Gil Oliva > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
