Re: Review Request 118486: Put transcript plugin in kf5 subdir and simplify search logic
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118486/#review59127 --- Ship it! Ship It! - David Faure On June 2, 2014, 10:03 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118486/ --- (Updated June 2, 2014, 10:03 p.m.) Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n Description --- Put transcript plugin in kf5 subdir and simplify search logic Putting the plugin in a versioned subdirectory ensures there will not be any coinstallability issues with KF6 if it is Qt5-based. Using QPluginLoader to find the plugin makes for simpler, more reliable code. Diffs - src/CMakeLists.txt 3099d2d29e43e40ac761694019f06aec41e54147 src/klocalizedstring.cpp 4a4f6f8c1a79d4b101ae3df5e589cb629f4bd596 Diff: https://git.reviewboard.kde.org/r/118486/diff/ Testing --- Tests pass, but not sure how to test the installed location. Chusslove: do you have a standard way to test the loading and operation of the transcript plugin? Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118486: Put transcript plugin in kf5 subdir and simplify search logic
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118486/ --- (Updated June 4, 2014, 9:18 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n Description --- Put transcript plugin in kf5 subdir and simplify search logic Putting the plugin in a versioned subdirectory ensures there will not be any coinstallability issues with KF6 if it is Qt5-based. Using QPluginLoader to find the plugin makes for simpler, more reliable code. Diffs - src/CMakeLists.txt 3099d2d29e43e40ac761694019f06aec41e54147 src/klocalizedstring.cpp 4a4f6f8c1a79d4b101ae3df5e589cb629f4bd596 Diff: https://git.reviewboard.kde.org/r/118486/diff/ Testing --- Tests pass, but not sure how to test the installed location. Chusslove: do you have a standard way to test the loading and operation of the transcript plugin? Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118486: Put transcript plugin in kf5 subdir and simplify search logic
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118486/#review59138 --- This review has been submitted with commit 8bb821a959fa71c405a1e94bc73aa20920254122 by Alex Merry to branch master. - Commit Hook On June 2, 2014, 10:03 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118486/ --- (Updated June 2, 2014, 10:03 p.m.) Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n Description --- Put transcript plugin in kf5 subdir and simplify search logic Putting the plugin in a versioned subdirectory ensures there will not be any coinstallability issues with KF6 if it is Qt5-based. Using QPluginLoader to find the plugin makes for simpler, more reliable code. Diffs - src/CMakeLists.txt 3099d2d29e43e40ac761694019f06aec41e54147 src/klocalizedstring.cpp 4a4f6f8c1a79d4b101ae3df5e589cb629f4bd596 Diff: https://git.reviewboard.kde.org/r/118486/diff/ Testing --- Tests pass, but not sure how to test the installed location. Chusslove: do you have a standard way to test the loading and operation of the transcript plugin? Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118486: Put transcript plugin in kf5 subdir and simplify search logic
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118486/#review59035 --- For KF5 I don't have anything other than tests at the moment. I should soon adapt some of the test programs I used earlier... Could you also check how this patch relates to the commit 06fdfea5? - Chusslove Illich On June 3, 2014, 12:03 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118486/ --- (Updated June 3, 2014, 12:03 a.m.) Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n Description --- Put transcript plugin in kf5 subdir and simplify search logic Putting the plugin in a versioned subdirectory ensures there will not be any coinstallability issues with KF6 if it is Qt5-based. Using QPluginLoader to find the plugin makes for simpler, more reliable code. Diffs - src/CMakeLists.txt 3099d2d29e43e40ac761694019f06aec41e54147 src/klocalizedstring.cpp 4a4f6f8c1a79d4b101ae3df5e589cb629f4bd596 Diff: https://git.reviewboard.kde.org/r/118486/diff/ Testing --- Tests pass, but not sure how to test the installed location. Chusslove: do you have a standard way to test the loading and operation of the transcript plugin? Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118486: Put transcript plugin in kf5 subdir and simplify search logic
On June 3, 2014, 7:11 a.m., Chusslove Illich wrote: For KF5 I don't have anything other than tests at the moment. I should soon adapt some of the test programs I used earlier... Could you also check how this patch relates to the commit 06fdfea5? It does the opposite to that commit. Rather than removing the kf5 namespace from the search code, it changes the install location of the plugin to include it. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118486/#review59035 --- On June 2, 2014, 10:03 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118486/ --- (Updated June 2, 2014, 10:03 p.m.) Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n Description --- Put transcript plugin in kf5 subdir and simplify search logic Putting the plugin in a versioned subdirectory ensures there will not be any coinstallability issues with KF6 if it is Qt5-based. Using QPluginLoader to find the plugin makes for simpler, more reliable code. Diffs - src/CMakeLists.txt 3099d2d29e43e40ac761694019f06aec41e54147 src/klocalizedstring.cpp 4a4f6f8c1a79d4b101ae3df5e589cb629f4bd596 Diff: https://git.reviewboard.kde.org/r/118486/diff/ Testing --- Tests pass, but not sure how to test the installed location. Chusslove: do you have a standard way to test the loading and operation of the transcript plugin? Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
