Re: Review Request 118680: Reorder Tests

2014-06-13 Thread Thomas Braxton 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118680/
---

(Updated June 13, 2014, 3:29 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Matthew Dawson.


Repository: kconfig


Description
---

Some tests are testing underlying components, these should be tested before 
testing the components that depend on them.


Diffs
-

  autotests/CMakeLists.txt 02885e7101bfd4239d3fb64f2940cb80933570b7 

Diff: https://git.reviewboard.kde.org/r/118680/diff/


Testing
---

All tests still pass


Thanks,

Thomas Braxton

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118680: Reorder Tests

2014-06-13 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118680/#review60020
---


This review has been submitted with commit 
d6bcd49943e56bd48b793b8774e88435bf741088 by Thomas Braxton to branch master.

- Commit Hook


On June 13, 2014, 3:03 p.m., Thomas Braxton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118680/
> ---
> 
> (Updated June 13, 2014, 3:03 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Some tests are testing underlying components, these should be tested before 
> testing the components that depend on them.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 02885e7101bfd4239d3fb64f2940cb80933570b7 
> 
> Diff: https://git.reviewboard.kde.org/r/118680/diff/
> 
> 
> Testing
> ---
> 
> All tests still pass
> 
> 
> Thanks,
> 
> Thomas Braxton
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118680: Reorder Tests

2014-06-13 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118680/#review60014
---

Ship it!


Seems good to me.

- Aleix Pol Gonzalez


On June 13, 2014, 3:03 p.m., Thomas Braxton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118680/
> ---
> 
> (Updated June 13, 2014, 3:03 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Some tests are testing underlying components, these should be tested before 
> testing the components that depend on them.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 02885e7101bfd4239d3fb64f2940cb80933570b7 
> 
> Diff: https://git.reviewboard.kde.org/r/118680/diff/
> 
> 
> Testing
> ---
> 
> All tests still pass
> 
> 
> Thanks,
> 
> Thomas Braxton
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118680: Reorder Tests

2014-06-13 Thread Thomas Braxton 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118680/
---

(Updated June 13, 2014, 3:03 p.m.)


Review request for KDE Frameworks and Matthew Dawson.


Changes
---

moved test_kconfigutils behind kentrymaptest


Repository: kconfig


Description
---

Some tests are testing underlying components, these should be tested before 
testing the components that depend on them.


Diffs (updated)
-

  autotests/CMakeLists.txt 02885e7101bfd4239d3fb64f2940cb80933570b7 

Diff: https://git.reviewboard.kde.org/r/118680/diff/


Testing
---

All tests still pass


Thanks,

Thomas Braxton

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118680: Reorder Tests

2014-06-13 Thread Thomas Braxton 


> On June 12, 2014, 10:07 a.m., Aleix Pol Gonzalez wrote:
> > autotests/CMakeLists.txt, line 53
> > 
> >
> > Why did you need to create a separate call to ecm_add_test?
> > 
> > If it's for the target_include_directories, you can still do it to an 
> > ecm_add_tests created target.
> 
> Thomas Braxton wrote:
> No, because it depends on KConfigUtils, so it should be after 
> test_kconfigutils.
> 
> Aleix Pol Gonzalez wrote:
> Aren't ecm_add_tests being added consecutively?

Yes, but test_kconfigutils has different LINK_LIBRARIES than test_kconf_update. 
Actually, I could just move test_kcocnfigutils to behind kentrymaptest and it 
will be in the right order. I'll upload a new patch.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118680/#review59855
---


On June 11, 2014, 11:04 p.m., Thomas Braxton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118680/
> ---
> 
> (Updated June 11, 2014, 11:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Some tests are testing underlying components, these should be tested before 
> testing the components that depend on them.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 02885e7101bfd4239d3fb64f2940cb80933570b7 
> 
> Diff: https://git.reviewboard.kde.org/r/118680/diff/
> 
> 
> Testing
> ---
> 
> All tests still pass
> 
> 
> Thanks,
> 
> Thomas Braxton
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118680: Reorder Tests

2014-06-13 Thread Aleix Pol Gonzalez 


> On June 12, 2014, 10:07 a.m., Aleix Pol Gonzalez wrote:
> > autotests/CMakeLists.txt, line 53
> > 
> >
> > Why did you need to create a separate call to ecm_add_test?
> > 
> > If it's for the target_include_directories, you can still do it to an 
> > ecm_add_tests created target.
> 
> Thomas Braxton wrote:
> No, because it depends on KConfigUtils, so it should be after 
> test_kconfigutils.

Aren't ecm_add_tests being added consecutively?


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118680/#review59855
---


On June 11, 2014, 11:04 p.m., Thomas Braxton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118680/
> ---
> 
> (Updated June 11, 2014, 11:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Some tests are testing underlying components, these should be tested before 
> testing the components that depend on them.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 02885e7101bfd4239d3fb64f2940cb80933570b7 
> 
> Diff: https://git.reviewboard.kde.org/r/118680/diff/
> 
> 
> Testing
> ---
> 
> All tests still pass
> 
> 
> Thanks,
> 
> Thomas Braxton
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118680: Reorder Tests

2014-06-12 Thread Thomas Braxton 


> On June 12, 2014, 10:07 a.m., Aleix Pol Gonzalez wrote:
> > autotests/CMakeLists.txt, line 53
> > 
> >
> > Why did you need to create a separate call to ecm_add_test?
> > 
> > If it's for the target_include_directories, you can still do it to an 
> > ecm_add_tests created target.

No, because it depends on KConfigUtils, so it should be after test_kconfigutils.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118680/#review59855
---


On June 11, 2014, 11:04 p.m., Thomas Braxton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118680/
> ---
> 
> (Updated June 11, 2014, 11:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Some tests are testing underlying components, these should be tested before 
> testing the components that depend on them.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 02885e7101bfd4239d3fb64f2940cb80933570b7 
> 
> Diff: https://git.reviewboard.kde.org/r/118680/diff/
> 
> 
> Testing
> ---
> 
> All tests still pass
> 
> 
> Thanks,
> 
> Thomas Braxton
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118680: Reorder Tests

2014-06-12 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118680/#review59855
---



autotests/CMakeLists.txt


Why did you need to create a separate call to ecm_add_test?

If it's for the target_include_directories, you can still do it to an 
ecm_add_tests created target.


- Aleix Pol Gonzalez


On June 11, 2014, 11:04 p.m., Thomas Braxton wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118680/
> ---
> 
> (Updated June 11, 2014, 11:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Matthew Dawson.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> Some tests are testing underlying components, these should be tested before 
> testing the components that depend on them.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 02885e7101bfd4239d3fb64f2940cb80933570b7 
> 
> Diff: https://git.reviewboard.kde.org/r/118680/diff/
> 
> 
> Testing
> ---
> 
> All tests still pass
> 
> 
> Thanks,
> 
> Thomas Braxton
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel