Re: Review Request 119323: fix auth race condition
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/ --- (Updated July 21, 2014, 8:47 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Hrvoje Senjan, Luca Beltrame, and Martin Bříza. Repository: kauth Description --- pid based auth is racy because of pid reuse, don't use it. Diffs - src/backends/polkit-1/Polkit1Backend.cpp 165f7bb Diff: https://git.reviewboard.kde.org/r/119323/diff/ Testing --- it builds Thanks, Martin Tobias Holmedahl Sandsmark ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119323: fix auth race condition
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/#review62631 --- Ship it! I have been using this for 4.x and 5.x for a while without issues. Unit tests (no matter how little they are) also pass, so this should go in. IMO this should also be pushed for kdelibs, which is affected in the same manner. - Luca Beltrame On Lug. 17, 2014, 11:23 a.m., Martin Tobias Holmedahl Sandsmark wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/ --- (Updated Lug. 17, 2014, 11:23 a.m.) Review request for KDE Frameworks, Hrvoje Senjan, Luca Beltrame, and Martin Bříza. Repository: kauth Description --- pid based auth is racy because of pid reuse, don't use it. Diffs - src/backends/polkit-1/Polkit1Backend.cpp 165f7bb Diff: https://git.reviewboard.kde.org/r/119323/diff/ Testing --- it builds Thanks, Martin Tobias Holmedahl Sandsmark ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119323: fix auth race condition
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/ --- (Updated July 17, 2014, 11:23 a.m.) Review request for KDE Frameworks, Hrvoje Senjan, Luca Beltrame, and Martin Bříza. Changes --- fix the other place Repository: kauth Description --- pid based auth is racy because of pid reuse, don't use it. Diffs (updated) - src/backends/polkit-1/Polkit1Backend.cpp 165f7bb Diff: https://git.reviewboard.kde.org/r/119323/diff/ Testing --- it builds Thanks, Martin Tobias Holmedahl Sandsmark ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119323: fix auth race condition
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/ --- (Updated July 16, 2014, 4:05 p.m.) Review request for KDE Frameworks, Hrvoje Senjan, Luca Beltrame, and Martin Bříza. Repository: kauth Description --- pid based auth is racy because of pid reuse, don't use it. Diffs - src/backends/polkit-1/Polkit1Backend.cpp 165f7bb Diff: https://git.reviewboard.kde.org/r/119323/diff/ Testing --- it builds Thanks, Martin Tobias Holmedahl Sandsmark ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119323: fix auth race condition
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/#review62520 --- I ran the (few) autotests, and those also pass. I can't test it runtime, will do so later hopefully. - Luca Beltrame On Lug. 16, 2014, 4:05 p.m., Martin Tobias Holmedahl Sandsmark wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/ --- (Updated Lug. 16, 2014, 4:05 p.m.) Review request for KDE Frameworks, Hrvoje Senjan, Luca Beltrame, and Martin Bříza. Repository: kauth Description --- pid based auth is racy because of pid reuse, don't use it. Diffs - src/backends/polkit-1/Polkit1Backend.cpp 165f7bb Diff: https://git.reviewboard.kde.org/r/119323/diff/ Testing --- it builds Thanks, Martin Tobias Holmedahl Sandsmark ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119323: fix auth race condition
On July 16, 2014, 6:06 p.m., Luca Beltrame wrote: I ran the (few) autotests, and those also pass. I can't test it runtime, will do so later hopefully. a few runtime checks (e.g. org.kde.powerdevil.backlighthelper) seem to work =) also polkit reports system-bus-name is used - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/#review62520 --- On July 16, 2014, 6:05 p.m., Martin Tobias Holmedahl Sandsmark wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/ --- (Updated July 16, 2014, 6:05 p.m.) Review request for KDE Frameworks, Hrvoje Senjan, Luca Beltrame, and Martin Bříza. Repository: kauth Description --- pid based auth is racy because of pid reuse, don't use it. Diffs - src/backends/polkit-1/Polkit1Backend.cpp 165f7bb Diff: https://git.reviewboard.kde.org/r/119323/diff/ Testing --- it builds Thanks, Martin Tobias Holmedahl Sandsmark ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119323: fix auth race condition
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/#review62546 --- src/backends/polkit-1/Polkit1Backend.cpp https://git.reviewboard.kde.org/r/119323/#comment43392 i guess we can also have QDBusConnection::systemBus().baseService() here? - Hrvoje Senjan On July 16, 2014, 6:05 p.m., Martin Tobias Holmedahl Sandsmark wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/ --- (Updated July 16, 2014, 6:05 p.m.) Review request for KDE Frameworks, Hrvoje Senjan, Luca Beltrame, and Martin Bříza. Repository: kauth Description --- pid based auth is racy because of pid reuse, don't use it. Diffs - src/backends/polkit-1/Polkit1Backend.cpp 165f7bb Diff: https://git.reviewboard.kde.org/r/119323/diff/ Testing --- it builds Thanks, Martin Tobias Holmedahl Sandsmark ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119323: fix auth race condition
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/#review62547 --- FYI, this probably needs to go in kdelibs too as the issue is there too. I and Hrvoje are currently testing also a version for 4.x. - Luca Beltrame On Lug. 16, 2014, 4:05 p.m., Martin Tobias Holmedahl Sandsmark wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/ --- (Updated Lug. 16, 2014, 4:05 p.m.) Review request for KDE Frameworks, Hrvoje Senjan, Luca Beltrame, and Martin Bříza. Repository: kauth Description --- pid based auth is racy because of pid reuse, don't use it. Diffs - src/backends/polkit-1/Polkit1Backend.cpp 165f7bb Diff: https://git.reviewboard.kde.org/r/119323/diff/ Testing --- it builds Thanks, Martin Tobias Holmedahl Sandsmark ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
