Re: Review Request 122576: Introduce KMoreTools
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review77316 --- Moved to knewstuff: https://git.reviewboard.kde.org/r/122910/ - Gregor Mi On March 1, 2015, 2:28 p.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated March 1, 2015, 2:28 p.m.) Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta. Repository: kservice Description --- Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/ Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework If KMoreTools is considered useful it needs a home. I placed it in KService for now. Diffs - CMakeLists.txt 34ce792652415100c9a5f877f0516781eb4aec17 src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 src/kmoretools/kmoretools.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretools_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.cpp PRE-CREATION src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e tests/kmoretools/1/a.desktop PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION tests/kmoretools/kmoretoolstest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122576/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122576: Introduce KMoreTools
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated March 11, 2015, 11:08 p.m.) Status -- This change has been discarded. Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta. Repository: kservice Description --- Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/ Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework If KMoreTools is considered useful it needs a home. I placed it in KService for now. Diffs - CMakeLists.txt 34ce792652415100c9a5f877f0516781eb4aec17 src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 src/kmoretools/kmoretools.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretools_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.cpp PRE-CREATION src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e tests/kmoretools/1/a.desktop PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION tests/kmoretools/kmoretoolstest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122576/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122576: Introduce KMoreTools
On March 7, 2015, 9:04 a.m., David Faure wrote: KService is basically ksycoca. One day I hope we can move away from that, which means all of kservice could then be deprecated. So it still makes sense to *use* kservice where looking up desktop files is needed (it's our current implementation of that) but KMT itself isn't part of the ksycoca technology, it should be higher up in the stack. One idea would be to put it in KNewStuff. It's the same kind of thing, viewed from far away: offering the user to install more stuff. Regarding the lookup if an application is installed or not. Currently this is done by looking if the desktop file is installed. With respect to [Dolphin (frameworks branch) doesn’t find filelight](https://bugs.kde.org/show_bug.cgi?id=344614) and that you said it is better to move away from ksyscoca, I wonder how stable the detection of desktop files currently is? Is it maybe better to detect if the executable exists which is specified at the desktop file's Exec line? - Gregor --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review77147 --- On March 1, 2015, 2:28 p.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated March 1, 2015, 2:28 p.m.) Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta. Repository: kservice Description --- Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/ Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework If KMoreTools is considered useful it needs a home. I placed it in KService for now. Diffs - CMakeLists.txt 34ce792652415100c9a5f877f0516781eb4aec17 src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 src/kmoretools/kmoretools.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretools_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.cpp PRE-CREATION src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e tests/kmoretools/1/a.desktop PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION tests/kmoretools/kmoretoolstest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122576/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122576: Introduce KMoreTools
On March 7, 2015, 9:04 a.m., David Faure wrote: KService is basically ksycoca. One day I hope we can move away from that, which means all of kservice could then be deprecated. So it still makes sense to *use* kservice where looking up desktop files is needed (it's our current implementation of that) but KMT itself isn't part of the ksycoca technology, it should be higher up in the stack. One idea would be to put it in KNewStuff. It's the same kind of thing, viewed from far away: offering the user to install more stuff. Gregor Mi wrote: Regarding the lookup if an application is installed or not. Currently this is done by looking if the desktop file is installed. With respect to [Dolphin (frameworks branch) doesn’t find filelight](https://bugs.kde.org/show_bug.cgi?id=344614) and that you said it is better to move away from ksyscoca, I wonder how stable the detection of desktop files currently is? Is it maybe better to detect if the executable exists which is specified at the desktop file's Exec line? You misunderstood me. Right now the recommended solution *is* KService and ksycoca. It is supposed to work, and works for many cases. I didn't have time to look into this specific bug report, but unit tests pass and many people run a plasma 2 desktop based on KService and ksycoca. I'm just saying that in the long term I want to be able to replace this technology with something else, but that's just long-term architectural thinking. For now, use it and debug it ;-) - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review77147 --- On March 1, 2015, 2:28 p.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated March 1, 2015, 2:28 p.m.) Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta. Repository: kservice Description --- Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/ Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework If KMoreTools is considered useful it needs a home. I placed it in KService for now. Diffs - CMakeLists.txt 34ce792652415100c9a5f877f0516781eb4aec17 src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 src/kmoretools/kmoretools.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretools_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.cpp PRE-CREATION src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e tests/kmoretools/1/a.desktop PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION tests/kmoretools/kmoretoolstest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122576/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122576: Introduce KMoreTools
On March 7, 2015, 9:04 a.m., David Faure wrote: KService is basically ksycoca. One day I hope we can move away from that, which means all of kservice could then be deprecated. So it still makes sense to *use* kservice where looking up desktop files is needed (it's our current implementation of that) but KMT itself isn't part of the ksycoca technology, it should be higher up in the stack. One idea would be to put it in KNewStuff. It's the same kind of thing, viewed from far away: offering the user to install more stuff. Gregor Mi wrote: Regarding the lookup if an application is installed or not. Currently this is done by looking if the desktop file is installed. With respect to [Dolphin (frameworks branch) doesn’t find filelight](https://bugs.kde.org/show_bug.cgi?id=344614) and that you said it is better to move away from ksyscoca, I wonder how stable the detection of desktop files currently is? Is it maybe better to detect if the executable exists which is specified at the desktop file's Exec line? David Faure wrote: You misunderstood me. Right now the recommended solution *is* KService and ksycoca. It is supposed to work, and works for many cases. I didn't have time to look into this specific bug report, but unit tests pass and many people run a plasma 2 desktop based on KService and ksycoca. I'm just saying that in the long term I want to be able to replace this technology with something else, but that's just long-term architectural thinking. For now, use it and debug it ;-) Ok. So there is no way around the debugging part. ;-) - Gregor --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review77147 --- On March 1, 2015, 2:28 p.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated March 1, 2015, 2:28 p.m.) Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta. Repository: kservice Description --- Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/ Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework If KMoreTools is considered useful it needs a home. I placed it in KService for now. Diffs - CMakeLists.txt 34ce792652415100c9a5f877f0516781eb4aec17 src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 src/kmoretools/kmoretools.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretools_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.cpp PRE-CREATION src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e tests/kmoretools/1/a.desktop PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION tests/kmoretools/kmoretoolstest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122576/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122576: Introduce KMoreTools
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review77147 --- KService is basically ksycoca. One day I hope we can move away from that, which means all of kservice could then be deprecated. So it still makes sense to *use* kservice where looking up desktop files is needed (it's our current implementation of that) but KMT itself isn't part of the ksycoca technology, it should be higher up in the stack. One idea would be to put it in KNewStuff. It's the same kind of thing, viewed from far away: offering the user to install more stuff. - David Faure On March 1, 2015, 2:28 p.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated March 1, 2015, 2:28 p.m.) Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta. Repository: kservice Description --- Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/ Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework If KMoreTools is considered useful it needs a home. I placed it in KService for now. Diffs - CMakeLists.txt 34ce792652415100c9a5f877f0516781eb4aec17 src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 src/kmoretools/kmoretools.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretools_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.cpp PRE-CREATION src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e tests/kmoretools/1/a.desktop PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION tests/kmoretools/kmoretoolstest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122576/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122576: Introduce KMoreTools
On Feb. 16, 2015, 11:12 a.m., Aleix Pol Gonzalez wrote: src/CMakeLists.txt, line 81 https://git.reviewboard.kde.org/r/122576/diff/1/?file=349785#file349785line81 I don't think this class is enough reason to make KService depend on QtWidgets. I think so, too. Any other idea? - Gregor --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review76114 --- On March 1, 2015, 2:28 p.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated March 1, 2015, 2:28 p.m.) Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta. Repository: kservice Description --- Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/ Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework If KMoreTools is considered useful it needs a home. I placed it in KService for now. Diffs - CMakeLists.txt 34ce792652415100c9a5f877f0516781eb4aec17 src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 src/kmoretools/kmoretools.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretools_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.cpp PRE-CREATION src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e tests/kmoretools/1/a.desktop PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION tests/kmoretools/kmoretoolstest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122576/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122576: Introduce KMoreTools
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated March 1, 2015, 10:59 a.m.) Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta. Changes --- minor fixes Repository: kservice Description --- Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/ Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework If KMoreTools is considered useful it needs a home. I placed it in KService for now. Diffs (updated) - src/kmoretools/kmoretoolsconfigdialog_p.cpp PRE-CREATION src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e tests/kmoretools/1/a.desktop PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION tests/kmoretools/kmoretoolstest.cpp PRE-CREATION CMakeLists.txt 34ce792652415100c9a5f877f0516781eb4aec17 src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 src/kmoretools/kmoretools.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretools_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122576/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122576: Introduce KMoreTools
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated March 1, 2015, 2:28 p.m.) Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta. Changes --- API refactoring, fix mem handling issue, remove std::shared_ptr Repository: kservice Description --- Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/ Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework If KMoreTools is considered useful it needs a home. I placed it in KService for now. Diffs (updated) - CMakeLists.txt 34ce792652415100c9a5f877f0516781eb4aec17 src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 src/kmoretools/kmoretools.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretools_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.cpp PRE-CREATION src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e tests/kmoretools/1/a.desktop PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION tests/kmoretools/kmoretoolstest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122576/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122576: Introduce KMoreTools
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review76422 --- src/kmoretools/kmoretoolsconfigdialog.h https://git.reviewboard.kde.org/r/122576/#comment52639 Why is a non private header including a private header? - Albert Astals Cid On feb. 16, 2015, 11:05 p.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated feb. 16, 2015, 11:05 p.m.) Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta. Repository: kservice Description --- Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/ Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework If KMoreTools is considered useful it needs a home. I placed it in KService for now. Diffs - tests/kmoretools/kmoretoolstest.cpp PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION CMakeLists.txt e6f8577f193dceda951c25054a134eb5cd2e1cf2 src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 src/kmoretools/kmoretools.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretools_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog.cpp PRE-CREATION src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e tests/kmoretools/1/a.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122576/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122576: Introduce KMoreTools
On Feb. 22, 2015, 1:52 p.m., Albert Astals Cid wrote: src/kmoretools/kmoretoolsconfigdialog.h, line 27 https://git.reviewboard.kde.org/r/122576/diff/4/?file=350011#file350011line27 Why is a non private header including a private header? kmoretoolsconfigdialog.h should be private, too. How is this expressed? Also with adding a _p to the .h filename (and also to the .cpp filename?)? - Gregor --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review76422 --- On Feb. 16, 2015, 11:05 p.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated Feb. 16, 2015, 11:05 p.m.) Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta. Repository: kservice Description --- Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/ Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework If KMoreTools is considered useful it needs a home. I placed it in KService for now. Diffs - tests/kmoretools/kmoretoolstest.cpp PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION CMakeLists.txt e6f8577f193dceda951c25054a134eb5cd2e1cf2 src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 src/kmoretools/kmoretools.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretools_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog.cpp PRE-CREATION src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e tests/kmoretools/1/a.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122576/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122576: Introduce KMoreTools
On feb. 22, 2015, 1:52 p.m., Albert Astals Cid wrote: src/kmoretools/kmoretoolsconfigdialog.h, line 27 https://git.reviewboard.kde.org/r/122576/diff/4/?file=350011#file350011line27 Why is a non private header including a private header? Gregor Mi wrote: kmoretoolsconfigdialog.h should be private, too. How is this expressed? Also with adding a _p to the .h filename (and also to the .cpp filename?)? Well you have _p.h in the other private headers too, so it makes sense to be consistent. Also make sure you don't install it :) - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review76422 --- On feb. 16, 2015, 11:05 p.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated feb. 16, 2015, 11:05 p.m.) Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta. Repository: kservice Description --- Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/ Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework If KMoreTools is considered useful it needs a home. I placed it in KService for now. Diffs - tests/kmoretools/kmoretoolstest.cpp PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION CMakeLists.txt e6f8577f193dceda951c25054a134eb5cd2e1cf2 src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 src/kmoretools/kmoretools.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretools_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog.cpp PRE-CREATION src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e tests/kmoretools/1/a.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122576/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122576: Introduce KMoreTools
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated Feb. 22, 2015, 8:34 p.m.) Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta. Changes --- - consistent private file naming - UI draft for reordering items in main section and moving to/from more section (not persisted yet) Repository: kservice Description --- Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/ Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework If KMoreTools is considered useful it needs a home. I placed it in KService for now. Diffs (updated) - CMakeLists.txt e329e5d6823ad46009d01cd74b3fa2138db1ea53 src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 src/kmoretools/kmoretools.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretools_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.cpp PRE-CREATION src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e tests/kmoretools/1/a.desktop PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION tests/kmoretools/kmoretoolstest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122576/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122576: Introduce KMoreTools
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated Feb. 22, 2015, 11:24 p.m.) Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta. Changes --- - UI: basic editing works: re-order items within list, move items from one section to the other, reset to default - add KConfig (- next step: read/write menu structure using http://qjson.sourceforge.net/) Repository: kservice Description --- Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/ Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework If KMoreTools is considered useful it needs a home. I placed it in KService for now. Diffs (updated) - CMakeLists.txt e329e5d6823ad46009d01cd74b3fa2138db1ea53 src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 src/kmoretools/kmoretools.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretools_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog_p.cpp PRE-CREATION src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e tests/kmoretools/1/a.desktop PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION tests/kmoretools/kmoretoolstest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122576/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122576: Introduce KMoreTools
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated Feb. 16, 2015, 10:30 p.m.) Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta. Changes --- - refactorings - documentation - work on Config Dialolg (currently problems getting DND to work because of Trying to construct an instance of an invalid type, type id: 872443648 warnings and subsequent crashes) Repository: kservice Description --- Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/ Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework If KMoreTools is considered useful it needs a home. I placed it in KService for now. Diffs (updated) - src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e tests/kmoretools/1/a.desktop PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION CMakeLists.txt e6f8577f193dceda951c25054a134eb5cd2e1cf2 src/kmoretools/kmoretoolsconfigdialog.cpp PRE-CREATION src/kmoretools/kmoretoolsconfigdialog.h PRE-CREATION src/kmoretools/kmoretools_p.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretools.h PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION tests/kmoretools/kmoretoolstest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122576/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122576: Introduce KMoreTools
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated Feb. 16, 2015, 10:36 p.m.) Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta. Changes --- add const for getters Repository: kservice Description --- Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/ Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework If KMoreTools is considered useful it needs a home. I placed it in KService for now. Diffs (updated) - tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e tests/kmoretools/1/a.desktop PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION tests/kmoretools/kmoretoolstest.cpp PRE-CREATION CMakeLists.txt e6f8577f193dceda951c25054a134eb5cd2e1cf2 src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 src/kmoretools/kmoretools.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretools_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog.cpp PRE-CREATION src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122576/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122576: Introduce KMoreTools
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated Feb. 16, 2015, 11:05 p.m.) Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta. Changes --- use more const Repository: kservice Description --- Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/ Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework If KMoreTools is considered useful it needs a home. I placed it in KService for now. Diffs (updated) - tests/kmoretools/kmoretoolstest.cpp PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION CMakeLists.txt e6f8577f193dceda951c25054a134eb5cd2e1cf2 src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 src/kmoretools/kmoretools.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretools_p.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog.cpp PRE-CREATION src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e tests/kmoretools/1/a.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122576/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122576: Introduce KMoreTools
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review76158 --- You're missing lots of const in your getters and const in your params - Albert Astals Cid On feb. 15, 2015, 2:15 p.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated feb. 15, 2015, 2:15 p.m.) Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta. Repository: kservice Description --- Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/ Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework If KMoreTools is considered useful it needs a home. I placed it in KService for now. Diffs - CMakeLists.txt e6f8577f193dceda951c25054a134eb5cd2e1cf2 src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 src/kmoretools/kmoretools.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretoolsconfigdialog.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog.cpp PRE-CREATION src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e tests/kmoretools/1/a.desktop PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION tests/kmoretools/kmoretoolstest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122576/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122576: Introduce KMoreTools
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/#review76114 --- src/CMakeLists.txt https://git.reviewboard.kde.org/r/122576/#comment52515 I don't think this class is enough reason to make KService depend on QtWidgets. tests/kmoretools/kmoretoolstest.cpp https://git.reviewboard.kde.org/r/122576/#comment52516 // ...? I like the feature though, I'm sure we'll be able to find it the correct spot. - Aleix Pol Gonzalez On Feb. 15, 2015, 3:15 p.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122576/ --- (Updated Feb. 15, 2015, 3:15 p.m.) Review request for KDE Frameworks, Dominik Haumann and Emmanuel Pescosta. Repository: kservice Description --- Usage examples see https://git.reviewboard.kde.org/r/122352/ and https://git.reviewboard.kde.org/r/122374/ Description see class comments on KMoreTools and https://community.kde.org/Scratchpad/KMoreToolsFramework If KMoreTools is considered useful it needs a home. I placed it in KService for now. Diffs - CMakeLists.txt e6f8577f193dceda951c25054a134eb5cd2e1cf2 src/CMakeLists.txt 35154a597f55313847b8140962c0e2a4cf1c15a2 src/kmoretools/kmoretools.h PRE-CREATION src/kmoretools/kmoretools.cpp PRE-CREATION src/kmoretools/kmoretoolsconfigdialog.h PRE-CREATION src/kmoretools/kmoretoolsconfigdialog.cpp PRE-CREATION src/kmoretools/ui/kmoretoolsconfigwidget.ui PRE-CREATION tests/CMakeLists.txt cbb5ece6a3265612fa4640426b7025de8f0dc78e tests/kmoretools/1/a.desktop PRE-CREATION tests/kmoretools/1/b.desktop PRE-CREATION tests/kmoretools/1/c.desktop PRE-CREATION tests/kmoretools/2/kate.desktop PRE-CREATION tests/kmoretools/2/kate.png PRE-CREATION tests/kmoretools/2/mynotinstalledapp.desktop PRE-CREATION tests/kmoretools/2/mynotinstalledapp.png PRE-CREATION tests/kmoretools/kmoretoolstest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/122576/diff/ Testing --- Thanks, Gregor Mi ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
