Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-07 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/
---

(Updated May 7, 2015, 2:31 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit ea924b14691da3819ca17d876f63ffc686fcf840 by Marco Martin 
to branch master.


Repository: plasma-framework


Description
---

this ports most of libplasma away from sycoca, using instead a combination of 
KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
own little caches instead of the global sycoca cache)
a kservicetypetrader call is left in the loading of containmentactions since is 
the only way to make an older workspace still work, but is only a fallback, so 
containmentactions in plasma-workspace can be ported eventually as well


Diffs
-

  KF5PlasmaConfig.cmake.in dee79ca 
  src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43 
  src/plasma/applet.cpp 2dda381 
  src/plasma/containment.cpp 7eabbb8 
  src/plasma/containmentactions.cpp f24bdac 
  src/plasma/dataengine.cpp 4b3d671 
  src/plasma/package.cpp 4e0be88 
  src/plasma/packagestructure.cpp b2686b6 
  src/plasma/pluginloader.cpp 0ce349a 
  src/plasma/private/applet_p.cpp 2cbfd06 
  src/plasma/private/dataenginemanager.cpp b9c5d8e 
  src/plasma/scripting/appletscript.h 863d707 
  src/plasma/scripting/dataenginescript.h f7ad3c2 
  src/plasma/scripting/scriptengine.cpp cc407e7 
  src/plasma/service.h b5d9b5a 
  src/plasma/service.cpp 3e9d852 
  src/plasmapkg/plasmapkg.cpp d606365 
  src/scriptengines/CMakeLists.txt f566406 
  src/scriptengines/qml/CMakeLists.txt e7130db 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
  src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 

Diff: https://git.reviewboard.kde.org/r/123626/diff/


Testing
---

still needs a lot of testing, so far, with a master plasma-workspace notmal 
workspace functions seems fine

latest version still installs metadata files in kservices5. I would keep this 
for safety until Plasma 5.4 is released, then try to remove it again


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-07 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/
---

(Updated May 7, 2015, 1:15 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

this ports most of libplasma away from sycoca, using instead a combination of 
KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
own little caches instead of the global sycoca cache)
a kservicetypetrader call is left in the loading of containmentactions since is 
the only way to make an older workspace still work, but is only a fallback, so 
containmentactions in plasma-workspace can be ported eventually as well


Diffs (updated)
-

  KF5PlasmaConfig.cmake.in dee79ca 
  src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43 
  src/plasma/applet.cpp 2dda381 
  src/plasma/containment.cpp 7eabbb8 
  src/plasma/containmentactions.cpp f24bdac 
  src/plasma/dataengine.cpp 4b3d671 
  src/plasma/package.cpp 4e0be88 
  src/plasma/packagestructure.cpp b2686b6 
  src/plasma/pluginloader.cpp 0ce349a 
  src/plasma/private/applet_p.cpp 2cbfd06 
  src/plasma/private/dataenginemanager.cpp b9c5d8e 
  src/plasma/scripting/appletscript.h 863d707 
  src/plasma/scripting/dataenginescript.h f7ad3c2 
  src/plasma/scripting/scriptengine.cpp cc407e7 
  src/plasma/service.h b5d9b5a 
  src/plasma/service.cpp 3e9d852 
  src/plasmapkg/plasmapkg.cpp d606365 
  src/scriptengines/CMakeLists.txt f566406 
  src/scriptengines/qml/CMakeLists.txt e7130db 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
  src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 

Diff: https://git.reviewboard.kde.org/r/123626/diff/


Testing
---

still needs a lot of testing, so far, with a master plasma-workspace notmal 
workspace functions seems fine

latest version still installs metadata files in kservices5. I would keep this 
for safety until Plasma 5.4 is released, then try to remove it again


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-07 Thread Marco Martin 


> On May 7, 2015, 11:59 a.m., Sebastian Kügler wrote:
> > src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml, line 
> > 197
> > 
> >
> > This line may have slipped in?

ouch, i pushed a commit in the wrong branch :/


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/#review80030
---


On May 7, 2015, 9:06 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123626/
> ---
> 
> (Updated May 7, 2015, 9:06 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports most of libplasma away from sycoca, using instead a combination of 
> KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
> own little caches instead of the global sycoca cache)
> a kservicetypetrader call is left in the loading of containmentactions since 
> is the only way to make an older workspace still work, but is only a 
> fallback, so containmentactions in plasma-workspace can be ported eventually 
> as well
> 
> 
> Diffs
> -
> 
>   KF5PlasmaConfig.cmake.in dee79ca 
>   src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml 
> be76a43 
>   src/plasma/applet.cpp 2dda381 
>   src/plasma/containment.cpp 7eabbb8 
>   src/plasma/containmentactions.cpp f24bdac 
>   src/plasma/dataengine.cpp 4b3d671 
>   src/plasma/package.cpp 4e0be88 
>   src/plasma/packagestructure.cpp b2686b6 
>   src/plasma/pluginloader.cpp 0ce349a 
>   src/plasma/private/applet_p.cpp 2cbfd06 
>   src/plasma/private/dataenginemanager.cpp b9c5d8e 
>   src/plasma/scripting/appletscript.h 863d707 
>   src/plasma/scripting/dataenginescript.h f7ad3c2 
>   src/plasma/scripting/scriptengine.cpp cc407e7 
>   src/plasma/service.h b5d9b5a 
>   src/plasma/service.cpp 3e9d852 
>   src/plasmapkg/plasmapkg.cpp d606365 
>   src/scriptengines/CMakeLists.txt f566406 
>   src/scriptengines/qml/CMakeLists.txt e7130db 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
>   src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 
> 
> Diff: https://git.reviewboard.kde.org/r/123626/diff/
> 
> 
> Testing
> ---
> 
> still needs a lot of testing, so far, with a master plasma-workspace notmal 
> workspace functions seems fine
> 
> latest version still installs metadata files in kservices5. I would keep this 
> for safety until Plasma 5.4 is released, then try to remove it again
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-07 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/#review80030
---

Ship it!


Looks good.


src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml (line 197)


This line may have slipped in?


- Sebastian Kügler


On May 7, 2015, 9:06 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123626/
> ---
> 
> (Updated May 7, 2015, 9:06 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports most of libplasma away from sycoca, using instead a combination of 
> KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
> own little caches instead of the global sycoca cache)
> a kservicetypetrader call is left in the loading of containmentactions since 
> is the only way to make an older workspace still work, but is only a 
> fallback, so containmentactions in plasma-workspace can be ported eventually 
> as well
> 
> 
> Diffs
> -
> 
>   KF5PlasmaConfig.cmake.in dee79ca 
>   src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml 
> be76a43 
>   src/plasma/applet.cpp 2dda381 
>   src/plasma/containment.cpp 7eabbb8 
>   src/plasma/containmentactions.cpp f24bdac 
>   src/plasma/dataengine.cpp 4b3d671 
>   src/plasma/package.cpp 4e0be88 
>   src/plasma/packagestructure.cpp b2686b6 
>   src/plasma/pluginloader.cpp 0ce349a 
>   src/plasma/private/applet_p.cpp 2cbfd06 
>   src/plasma/private/dataenginemanager.cpp b9c5d8e 
>   src/plasma/scripting/appletscript.h 863d707 
>   src/plasma/scripting/dataenginescript.h f7ad3c2 
>   src/plasma/scripting/scriptengine.cpp cc407e7 
>   src/plasma/service.h b5d9b5a 
>   src/plasma/service.cpp 3e9d852 
>   src/plasmapkg/plasmapkg.cpp d606365 
>   src/scriptengines/CMakeLists.txt f566406 
>   src/scriptengines/qml/CMakeLists.txt e7130db 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
>   src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 
> 
> Diff: https://git.reviewboard.kde.org/r/123626/diff/
> 
> 
> Testing
> ---
> 
> still needs a lot of testing, so far, with a master plasma-workspace notmal 
> workspace functions seems fine
> 
> latest version still installs metadata files in kservices5. I would keep this 
> for safety until Plasma 5.4 is released, then try to remove it again
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-07 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/#review80025
---


solved issues, still there the magic self() call, for that, an api addition in 
KPackage may be needed.

- Marco Martin


On May 7, 2015, 9:06 a.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123626/
> ---
> 
> (Updated May 7, 2015, 9:06 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports most of libplasma away from sycoca, using instead a combination of 
> KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
> own little caches instead of the global sycoca cache)
> a kservicetypetrader call is left in the loading of containmentactions since 
> is the only way to make an older workspace still work, but is only a 
> fallback, so containmentactions in plasma-workspace can be ported eventually 
> as well
> 
> 
> Diffs
> -
> 
>   KF5PlasmaConfig.cmake.in dee79ca 
>   src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml 
> be76a43 
>   src/plasma/applet.cpp 2dda381 
>   src/plasma/containment.cpp 7eabbb8 
>   src/plasma/containmentactions.cpp f24bdac 
>   src/plasma/dataengine.cpp 4b3d671 
>   src/plasma/package.cpp 4e0be88 
>   src/plasma/packagestructure.cpp b2686b6 
>   src/plasma/pluginloader.cpp 0ce349a 
>   src/plasma/private/applet_p.cpp 2cbfd06 
>   src/plasma/private/dataenginemanager.cpp b9c5d8e 
>   src/plasma/scripting/appletscript.h 863d707 
>   src/plasma/scripting/dataenginescript.h f7ad3c2 
>   src/plasma/scripting/scriptengine.cpp cc407e7 
>   src/plasma/service.h b5d9b5a 
>   src/plasma/service.cpp 3e9d852 
>   src/plasmapkg/plasmapkg.cpp d606365 
>   src/scriptengines/CMakeLists.txt f566406 
>   src/scriptengines/qml/CMakeLists.txt e7130db 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
>   src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 
> 
> Diff: https://git.reviewboard.kde.org/r/123626/diff/
> 
> 
> Testing
> ---
> 
> still needs a lot of testing, so far, with a master plasma-workspace notmal 
> workspace functions seems fine
> 
> latest version still installs metadata files in kservices5. I would keep this 
> for safety until Plasma 5.4 is released, then try to remove it again
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-07 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/
---

(Updated May 7, 2015, 9:06 a.m.)


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

this ports most of libplasma away from sycoca, using instead a combination of 
KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
own little caches instead of the global sycoca cache)
a kservicetypetrader call is left in the loading of containmentactions since is 
the only way to make an older workspace still work, but is only a fallback, so 
containmentactions in plasma-workspace can be ported eventually as well


Diffs (updated)
-

  KF5PlasmaConfig.cmake.in dee79ca 
  src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43 
  src/plasma/applet.cpp 2dda381 
  src/plasma/containment.cpp 7eabbb8 
  src/plasma/containmentactions.cpp f24bdac 
  src/plasma/dataengine.cpp 4b3d671 
  src/plasma/package.cpp 4e0be88 
  src/plasma/packagestructure.cpp b2686b6 
  src/plasma/pluginloader.cpp 0ce349a 
  src/plasma/private/applet_p.cpp 2cbfd06 
  src/plasma/private/dataenginemanager.cpp b9c5d8e 
  src/plasma/scripting/appletscript.h 863d707 
  src/plasma/scripting/dataenginescript.h f7ad3c2 
  src/plasma/scripting/scriptengine.cpp cc407e7 
  src/plasma/service.h b5d9b5a 
  src/plasma/service.cpp 3e9d852 
  src/plasmapkg/plasmapkg.cpp d606365 
  src/scriptengines/CMakeLists.txt f566406 
  src/scriptengines/qml/CMakeLists.txt e7130db 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
  src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 

Diff: https://git.reviewboard.kde.org/r/123626/diff/


Testing
---

still needs a lot of testing, so far, with a master plasma-workspace notmal 
workspace functions seems fine

latest version still installs metadata files in kservices5. I would keep this 
for safety until Plasma 5.4 is released, then try to remove it again


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-07 Thread Marco Martin 


> On May 6, 2015, 10:54 p.m., Sebastian Kügler wrote:
> > src/plasma/pluginloader.cpp, line 892
> > 
> >
> > Can this lead to containmentactions being listed twice? (I haven't seen 
> > it in the UI, but seems plausible as a corner case.)

this lists the plugins that are in plasma/containmentactions (of which at the 
moment there aren't any)
and then adds the ones fetched with sycoca.
in our case, the plugins are all from plasma-workspace and they would get moved 
from one version to the other. If one reinstalls without cleaning then yup, it 
would duplicate entries.
On a clean installation this should never happen, but i can add a check on the 
plugin name to not add it two times, may be slower but shouldn't have a big 
impact.


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/#review7
---


On May 6, 2015, 5:21 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123626/
> ---
> 
> (Updated May 6, 2015, 5:21 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports most of libplasma away from sycoca, using instead a combination of 
> KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
> own little caches instead of the global sycoca cache)
> a kservicetypetrader call is left in the loading of containmentactions since 
> is the only way to make an older workspace still work, but is only a 
> fallback, so containmentactions in plasma-workspace can be ported eventually 
> as well
> 
> 
> Diffs
> -
> 
>   KF5PlasmaConfig.cmake.in dee79ca 
>   src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml 
> be76a43 
>   src/plasma/applet.cpp 2dda381 
>   src/plasma/containment.cpp 7eabbb8 
>   src/plasma/containmentactions.cpp f24bdac 
>   src/plasma/dataengine.cpp 4b3d671 
>   src/plasma/package.cpp 4e0be88 
>   src/plasma/packagestructure.cpp b2686b6 
>   src/plasma/pluginloader.cpp 0ce349a 
>   src/plasma/private/applet_p.cpp 2cbfd06 
>   src/plasma/private/dataenginemanager.cpp b9c5d8e 
>   src/plasma/scripting/appletscript.h 863d707 
>   src/plasma/scripting/dataenginescript.h f7ad3c2 
>   src/plasma/scripting/scriptengine.cpp cc407e7 
>   src/plasma/service.h b5d9b5a 
>   src/plasma/service.cpp 3e9d852 
>   src/plasmapkg/plasmapkg.cpp d606365 
>   src/scriptengines/CMakeLists.txt f566406 
>   src/scriptengines/qml/CMakeLists.txt e7130db 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
>   src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 
> 
> Diff: https://git.reviewboard.kde.org/r/123626/diff/
> 
> 
> Testing
> ---
> 
> still needs a lot of testing, so far, with a master plasma-workspace notmal 
> workspace functions seems fine
> 
> latest version still installs metadata files in kservices5. I would keep this 
> for safety until Plasma 5.4 is released, then try to remove it again
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-07 Thread Marco Martin 


> On May 6, 2015, 10:54 p.m., Sebastian Kügler wrote:
> > src/plasma/pluginloader.cpp, line 826
> > 
> >
> > Why? This remark makes it kinda magical and doesn't provide any other 
> > information than "rather don't touch this" which is counter-productive to 
> > actually fixing it.

yeah, basically it's due to the 
KPackage::PackageLoader::self()->addKnownPackageStructure("Plasma/Applet", new 
PlasmoidPackage());
in the constructor. otherwise it doesn't know what a plasmoid package is. As i 
said in the addKnownPackageStructure, the solutions for this are either making 
sure addKnownPackageStructure has been called or making those structures 
plugins as well.

another solution that would be a bit more clear would be perhaps an accessor 
for known package structures in kpackageloader, so those self() would become:

if (!KPackage::PackageLoader::self()->packageStructureFor("Plasma/Applet")) {
KPackage::PackageLoader::self()->addKnownPackageStructure("Plasma/Applet", 
new PlasmoidPackage());
}

other/better api suggestions are welcome


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/#review7
---


On May 6, 2015, 5:21 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123626/
> ---
> 
> (Updated May 6, 2015, 5:21 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports most of libplasma away from sycoca, using instead a combination of 
> KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
> own little caches instead of the global sycoca cache)
> a kservicetypetrader call is left in the loading of containmentactions since 
> is the only way to make an older workspace still work, but is only a 
> fallback, so containmentactions in plasma-workspace can be ported eventually 
> as well
> 
> 
> Diffs
> -
> 
>   KF5PlasmaConfig.cmake.in dee79ca 
>   src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml 
> be76a43 
>   src/plasma/applet.cpp 2dda381 
>   src/plasma/containment.cpp 7eabbb8 
>   src/plasma/containmentactions.cpp f24bdac 
>   src/plasma/dataengine.cpp 4b3d671 
>   src/plasma/package.cpp 4e0be88 
>   src/plasma/packagestructure.cpp b2686b6 
>   src/plasma/pluginloader.cpp 0ce349a 
>   src/plasma/private/applet_p.cpp 2cbfd06 
>   src/plasma/private/dataenginemanager.cpp b9c5d8e 
>   src/plasma/scripting/appletscript.h 863d707 
>   src/plasma/scripting/dataenginescript.h f7ad3c2 
>   src/plasma/scripting/scriptengine.cpp cc407e7 
>   src/plasma/service.h b5d9b5a 
>   src/plasma/service.cpp 3e9d852 
>   src/plasmapkg/plasmapkg.cpp d606365 
>   src/scriptengines/CMakeLists.txt f566406 
>   src/scriptengines/qml/CMakeLists.txt e7130db 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
>   src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 
> 
> Diff: https://git.reviewboard.kde.org/r/123626/diff/
> 
> 
> Testing
> ---
> 
> still needs a lot of testing, so far, with a master plasma-workspace notmal 
> workspace functions seems fine
> 
> latest version still installs metadata files in kservices5. I would keep this 
> for safety until Plasma 5.4 is released, then try to remove it again
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-06 Thread Sebastian Kügler 


> On May 6, 2015, 10:54 p.m., Sebastian Kügler wrote:
> > I've read and tested it, everything still works nicely. Good job!
> > 
> > I like how the patch moves much of the query language into simple C++, 
> > avoids a lot of query parsing and moves some of the error paths to compile 
> > time.

https://git.reviewboard.kde.org/r/123669/

This moves the filtering by id, which is quite common, into KPluginLoader to 
save us a bit of churn.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/#review7
---


On May 6, 2015, 5:21 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123626/
> ---
> 
> (Updated May 6, 2015, 5:21 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports most of libplasma away from sycoca, using instead a combination of 
> KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
> own little caches instead of the global sycoca cache)
> a kservicetypetrader call is left in the loading of containmentactions since 
> is the only way to make an older workspace still work, but is only a 
> fallback, so containmentactions in plasma-workspace can be ported eventually 
> as well
> 
> 
> Diffs
> -
> 
>   KF5PlasmaConfig.cmake.in dee79ca 
>   src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml 
> be76a43 
>   src/plasma/applet.cpp 2dda381 
>   src/plasma/containment.cpp 7eabbb8 
>   src/plasma/containmentactions.cpp f24bdac 
>   src/plasma/dataengine.cpp 4b3d671 
>   src/plasma/package.cpp 4e0be88 
>   src/plasma/packagestructure.cpp b2686b6 
>   src/plasma/pluginloader.cpp 0ce349a 
>   src/plasma/private/applet_p.cpp 2cbfd06 
>   src/plasma/private/dataenginemanager.cpp b9c5d8e 
>   src/plasma/scripting/appletscript.h 863d707 
>   src/plasma/scripting/dataenginescript.h f7ad3c2 
>   src/plasma/scripting/scriptengine.cpp cc407e7 
>   src/plasma/service.h b5d9b5a 
>   src/plasma/service.cpp 3e9d852 
>   src/plasmapkg/plasmapkg.cpp d606365 
>   src/scriptengines/CMakeLists.txt f566406 
>   src/scriptengines/qml/CMakeLists.txt e7130db 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
>   src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 
> 
> Diff: https://git.reviewboard.kde.org/r/123626/diff/
> 
> 
> Testing
> ---
> 
> still needs a lot of testing, so far, with a master plasma-workspace notmal 
> workspace functions seems fine
> 
> latest version still installs metadata files in kservices5. I would keep this 
> for safety until Plasma 5.4 is released, then try to remove it again
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-06 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/#review7
---

Ship it!


I've read and tested it, everything still works nicely. Good job!

I like how the patch moves much of the query language into simple C++, avoids a 
lot of query parsing and moves some of the error paths to compile time.


src/plasma/pluginloader.cpp 


Why did you remove this, seems unrelated? (I'd keep the sorting in, just to 
assure backwards compat.)



src/plasma/pluginloader.cpp (line 730)


Why? This remark makes it kinda magical and doesn't provide any other 
information than "rather don't touch this" which is counter-productive to 
actually fixing it.



src/plasma/pluginloader.cpp (line 796)


Can this lead to containmentactions being listed twice? (I haven't seen it 
in the UI, but seems plausible as a corner case.)



src/plasma/private/applet_p.cpp (line 182)


I think this may end up calling the non-const version, rather use 
foreach(const QString &..).



src/plasma/private/applet_p.cpp (line 461)


redundant. Forgot to delete a row?



src/plasmapkg/plasmapkg.cpp (line 581)


This can now be const


- Sebastian Kügler


On May 6, 2015, 5:21 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123626/
> ---
> 
> (Updated May 6, 2015, 5:21 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports most of libplasma away from sycoca, using instead a combination of 
> KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
> own little caches instead of the global sycoca cache)
> a kservicetypetrader call is left in the loading of containmentactions since 
> is the only way to make an older workspace still work, but is only a 
> fallback, so containmentactions in plasma-workspace can be ported eventually 
> as well
> 
> 
> Diffs
> -
> 
>   KF5PlasmaConfig.cmake.in dee79ca 
>   src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml 
> be76a43 
>   src/plasma/applet.cpp 2dda381 
>   src/plasma/containment.cpp 7eabbb8 
>   src/plasma/containmentactions.cpp f24bdac 
>   src/plasma/dataengine.cpp 4b3d671 
>   src/plasma/package.cpp 4e0be88 
>   src/plasma/packagestructure.cpp b2686b6 
>   src/plasma/pluginloader.cpp 0ce349a 
>   src/plasma/private/applet_p.cpp 2cbfd06 
>   src/plasma/private/dataenginemanager.cpp b9c5d8e 
>   src/plasma/scripting/appletscript.h 863d707 
>   src/plasma/scripting/dataenginescript.h f7ad3c2 
>   src/plasma/scripting/scriptengine.cpp cc407e7 
>   src/plasma/service.h b5d9b5a 
>   src/plasma/service.cpp 3e9d852 
>   src/plasmapkg/plasmapkg.cpp d606365 
>   src/scriptengines/CMakeLists.txt f566406 
>   src/scriptengines/qml/CMakeLists.txt e7130db 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
>   src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 
> 
> Diff: https://git.reviewboard.kde.org/r/123626/diff/
> 
> 
> Testing
> ---
> 
> still needs a lot of testing, so far, with a master plasma-workspace notmal 
> workspace functions seems fine
> 
> latest version still installs metadata files in kservices5. I would keep this 
> for safety until Plasma 5.4 is released, then try to remove it again
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-06 Thread Sebastian Kügler 


> On May 6, 2015, 5:38 p.m., Hrvoje Senjan wrote:
> > >I would keep this for safety until Plasma 5.4 is released, then try to 
> > >remove it again
> > 
> > First, sorry for being the bad cop, i'd just like to avoid any future 
> > (irreversible) problems, and that distros delivering monthly KF5 updates 
> > continue doing so in the future ;-)
> > 
> > Please don't remove anything ever, KF5 promises backward compatibility 
> > forever, not until $someotherproductversion...
> > Distros where assured over and over again in the famous thread that 
> > no-bugfix-only KF5 releases will be a good thing for everyone, and they 
> > should be treated as bugfix releases (same as we can update kdelibs to 
> > 4.14.99 with kde-workspace 4.11.99).
> > 
> > If a distro would release with $someotherproductversion-1, and update KF5 
> > monthly they would get nice reports about broken desktops - and in 
> > principle all non-rolling distros won't deliver new feature releases for 
> > desktop and applications.
> 
> Marco Martin wrote:
> the thing is the systray that would not show plasmoids anymore. all the 
> rest should be 100% compatible.
> but yeah, we can leave the desktop files in kservices5 for the time being.
> we may eventually port the applets to a new install macro to have that 
> file not installed

Well, the .desktop files won't need to be installed anymore since we don't use 
them at runtime (the metadata is baked into the plugin), so we're in fact not 
breaking backwards compatibility, but we're reducing the installation footprint 
while keeping the functionality.

I agree, though, for safety to keep them around for a bit and remove them from 
the install in a later release.


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/#review79977
---


On May 6, 2015, 5:21 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123626/
> ---
> 
> (Updated May 6, 2015, 5:21 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports most of libplasma away from sycoca, using instead a combination of 
> KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
> own little caches instead of the global sycoca cache)
> a kservicetypetrader call is left in the loading of containmentactions since 
> is the only way to make an older workspace still work, but is only a 
> fallback, so containmentactions in plasma-workspace can be ported eventually 
> as well
> 
> 
> Diffs
> -
> 
>   KF5PlasmaConfig.cmake.in dee79ca 
>   src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml 
> be76a43 
>   src/plasma/applet.cpp 2dda381 
>   src/plasma/containment.cpp 7eabbb8 
>   src/plasma/containmentactions.cpp f24bdac 
>   src/plasma/dataengine.cpp 4b3d671 
>   src/plasma/package.cpp 4e0be88 
>   src/plasma/packagestructure.cpp b2686b6 
>   src/plasma/pluginloader.cpp 0ce349a 
>   src/plasma/private/applet_p.cpp 2cbfd06 
>   src/plasma/private/dataenginemanager.cpp b9c5d8e 
>   src/plasma/scripting/appletscript.h 863d707 
>   src/plasma/scripting/dataenginescript.h f7ad3c2 
>   src/plasma/scripting/scriptengine.cpp cc407e7 
>   src/plasma/service.h b5d9b5a 
>   src/plasma/service.cpp 3e9d852 
>   src/plasmapkg/plasmapkg.cpp d606365 
>   src/scriptengines/CMakeLists.txt f566406 
>   src/scriptengines/qml/CMakeLists.txt e7130db 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
>   src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 
> 
> Diff: https://git.reviewboard.kde.org/r/123626/diff/
> 
> 
> Testing
> ---
> 
> still needs a lot of testing, so far, with a master plasma-workspace notmal 
> workspace functions seems fine
> 
> latest version still installs metadata files in kservices5. I would keep this 
> for safety until Plasma 5.4 is released, then try to remove it again
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-06 Thread Marco Martin 


> On May 6, 2015, 5:38 p.m., Hrvoje Senjan wrote:
> > >I would keep this for safety until Plasma 5.4 is released, then try to 
> > >remove it again
> > 
> > First, sorry for being the bad cop, i'd just like to avoid any future 
> > (irreversible) problems, and that distros delivering monthly KF5 updates 
> > continue doing so in the future ;-)
> > 
> > Please don't remove anything ever, KF5 promises backward compatibility 
> > forever, not until $someotherproductversion...
> > Distros where assured over and over again in the famous thread that 
> > no-bugfix-only KF5 releases will be a good thing for everyone, and they 
> > should be treated as bugfix releases (same as we can update kdelibs to 
> > 4.14.99 with kde-workspace 4.11.99).
> > 
> > If a distro would release with $someotherproductversion-1, and update KF5 
> > monthly they would get nice reports about broken desktops - and in 
> > principle all non-rolling distros won't deliver new feature releases for 
> > desktop and applications.

the thing is the systray that would not show plasmoids anymore. all the rest 
should be 100% compatible.
but yeah, we can leave the desktop files in kservices5 for the time being.
we may eventually port the applets to a new install macro to have that file not 
installed


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/#review79977
---


On May 6, 2015, 5:21 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123626/
> ---
> 
> (Updated May 6, 2015, 5:21 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports most of libplasma away from sycoca, using instead a combination of 
> KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
> own little caches instead of the global sycoca cache)
> a kservicetypetrader call is left in the loading of containmentactions since 
> is the only way to make an older workspace still work, but is only a 
> fallback, so containmentactions in plasma-workspace can be ported eventually 
> as well
> 
> 
> Diffs
> -
> 
>   KF5PlasmaConfig.cmake.in dee79ca 
>   src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml 
> be76a43 
>   src/plasma/applet.cpp 2dda381 
>   src/plasma/containment.cpp 7eabbb8 
>   src/plasma/containmentactions.cpp f24bdac 
>   src/plasma/dataengine.cpp 4b3d671 
>   src/plasma/package.cpp 4e0be88 
>   src/plasma/packagestructure.cpp b2686b6 
>   src/plasma/pluginloader.cpp 0ce349a 
>   src/plasma/private/applet_p.cpp 2cbfd06 
>   src/plasma/private/dataenginemanager.cpp b9c5d8e 
>   src/plasma/scripting/appletscript.h 863d707 
>   src/plasma/scripting/dataenginescript.h f7ad3c2 
>   src/plasma/scripting/scriptengine.cpp cc407e7 
>   src/plasma/service.h b5d9b5a 
>   src/plasma/service.cpp 3e9d852 
>   src/plasmapkg/plasmapkg.cpp d606365 
>   src/scriptengines/CMakeLists.txt f566406 
>   src/scriptengines/qml/CMakeLists.txt e7130db 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
>   src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 
> 
> Diff: https://git.reviewboard.kde.org/r/123626/diff/
> 
> 
> Testing
> ---
> 
> still needs a lot of testing, so far, with a master plasma-workspace notmal 
> workspace functions seems fine
> 
> latest version still installs metadata files in kservices5. I would keep this 
> for safety until Plasma 5.4 is released, then try to remove it again
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-06 Thread Hrvoje Senjan 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/#review79977
---


>I would keep this for safety until Plasma 5.4 is released, then try to remove 
>it again

First, sorry for being the bad cop, i'd just like to avoid any future 
(irreversible) problems, and that distros delivering monthly KF5 updates 
continue doing so in the future ;-)

Please don't remove anything ever, KF5 promises backward compatibility forever, 
not until $someotherproductversion...
Distros where assured over and over again in the famous thread that 
no-bugfix-only KF5 releases will be a good thing for everyone, and they should 
be treated as bugfix releases (same as we can update kdelibs to 4.14.99 with 
kde-workspace 4.11.99).

If a distro would release with $someotherproductversion-1, and update KF5 
monthly they would get nice reports about broken desktops - and in principle 
all non-rolling distros won't deliver new feature releases for desktop and 
applications.

- Hrvoje Senjan


On May 6, 2015, 7:21 p.m., Marco Martin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123626/
> ---
> 
> (Updated May 6, 2015, 7:21 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> this ports most of libplasma away from sycoca, using instead a combination of 
> KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
> own little caches instead of the global sycoca cache)
> a kservicetypetrader call is left in the loading of containmentactions since 
> is the only way to make an older workspace still work, but is only a 
> fallback, so containmentactions in plasma-workspace can be ported eventually 
> as well
> 
> 
> Diffs
> -
> 
>   KF5PlasmaConfig.cmake.in dee79ca 
>   src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml 
> be76a43 
>   src/plasma/applet.cpp 2dda381 
>   src/plasma/containment.cpp 7eabbb8 
>   src/plasma/containmentactions.cpp f24bdac 
>   src/plasma/dataengine.cpp 4b3d671 
>   src/plasma/package.cpp 4e0be88 
>   src/plasma/packagestructure.cpp b2686b6 
>   src/plasma/pluginloader.cpp 0ce349a 
>   src/plasma/private/applet_p.cpp 2cbfd06 
>   src/plasma/private/dataenginemanager.cpp b9c5d8e 
>   src/plasma/scripting/appletscript.h 863d707 
>   src/plasma/scripting/dataenginescript.h f7ad3c2 
>   src/plasma/scripting/scriptengine.cpp cc407e7 
>   src/plasma/service.h b5d9b5a 
>   src/plasma/service.cpp 3e9d852 
>   src/plasmapkg/plasmapkg.cpp d606365 
>   src/scriptengines/CMakeLists.txt f566406 
>   src/scriptengines/qml/CMakeLists.txt e7130db 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
>   src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
>   src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 
> 
> Diff: https://git.reviewboard.kde.org/r/123626/diff/
> 
> 
> Testing
> ---
> 
> still needs a lot of testing, so far, with a master plasma-workspace notmal 
> workspace functions seems fine
> 
> latest version still installs metadata files in kservices5. I would keep this 
> for safety until Plasma 5.4 is released, then try to remove it again
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-06 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/
---

(Updated May 6, 2015, 5:21 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

this ports most of libplasma away from sycoca, using instead a combination of 
KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
own little caches instead of the global sycoca cache)
a kservicetypetrader call is left in the loading of containmentactions since is 
the only way to make an older workspace still work, but is only a fallback, so 
containmentactions in plasma-workspace can be ported eventually as well


Diffs
-

  KF5PlasmaConfig.cmake.in dee79ca 
  src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43 
  src/plasma/applet.cpp 2dda381 
  src/plasma/containment.cpp 7eabbb8 
  src/plasma/containmentactions.cpp f24bdac 
  src/plasma/dataengine.cpp 4b3d671 
  src/plasma/package.cpp 4e0be88 
  src/plasma/packagestructure.cpp b2686b6 
  src/plasma/pluginloader.cpp 0ce349a 
  src/plasma/private/applet_p.cpp 2cbfd06 
  src/plasma/private/dataenginemanager.cpp b9c5d8e 
  src/plasma/scripting/appletscript.h 863d707 
  src/plasma/scripting/dataenginescript.h f7ad3c2 
  src/plasma/scripting/scriptengine.cpp cc407e7 
  src/plasma/service.h b5d9b5a 
  src/plasma/service.cpp 3e9d852 
  src/plasmapkg/plasmapkg.cpp d606365 
  src/scriptengines/CMakeLists.txt f566406 
  src/scriptengines/qml/CMakeLists.txt e7130db 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
  src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 

Diff: https://git.reviewboard.kde.org/r/123626/diff/


Testing (updated)
---

still needs a lot of testing, so far, with a master plasma-workspace notmal 
workspace functions seems fine

latest version still installs metadata files in kservices5. I would keep this 
for safety until Plasma 5.4 is released, then try to remove it again


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-06 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/
---

(Updated May 6, 2015, 5:20 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

this ports most of libplasma away from sycoca, using instead a combination of 
KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
own little caches instead of the global sycoca cache)
a kservicetypetrader call is left in the loading of containmentactions since is 
the only way to make an older workspace still work, but is only a fallback, so 
containmentactions in plasma-workspace can be ported eventually as well


Diffs (updated)
-

  KF5PlasmaConfig.cmake.in dee79ca 
  src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43 
  src/plasma/applet.cpp 2dda381 
  src/plasma/containment.cpp 7eabbb8 
  src/plasma/containmentactions.cpp f24bdac 
  src/plasma/dataengine.cpp 4b3d671 
  src/plasma/package.cpp 4e0be88 
  src/plasma/packagestructure.cpp b2686b6 
  src/plasma/pluginloader.cpp 0ce349a 
  src/plasma/private/applet_p.cpp 2cbfd06 
  src/plasma/private/dataenginemanager.cpp b9c5d8e 
  src/plasma/scripting/appletscript.h 863d707 
  src/plasma/scripting/dataenginescript.h f7ad3c2 
  src/plasma/scripting/scriptengine.cpp cc407e7 
  src/plasma/service.h b5d9b5a 
  src/plasma/service.cpp 3e9d852 
  src/plasmapkg/plasmapkg.cpp d606365 
  src/scriptengines/CMakeLists.txt f566406 
  src/scriptengines/qml/CMakeLists.txt e7130db 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
  src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 

Diff: https://git.reviewboard.kde.org/r/123626/diff/


Testing
---

still needs a lot of testing, so far, with a master plasma-workspace notmal 
workspace functions seems fine


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-06 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/
---

(Updated May 6, 2015, 2:35 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

this ports most of libplasma away from sycoca, using instead a combination of 
KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
own little caches instead of the global sycoca cache)
a kservicetypetrader call is left in the loading of containmentactions since is 
the only way to make an older workspace still work, but is only a fallback, so 
containmentactions in plasma-workspace can be ported eventually as well


Diffs (updated)
-

  KF5PlasmaConfig.cmake.in dee79ca 
  KF5PlasmaMacros.cmake 24bebb4 
  src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43 
  src/plasma/applet.cpp 2dda381 
  src/plasma/containment.cpp 7eabbb8 
  src/plasma/containmentactions.cpp f24bdac 
  src/plasma/dataengine.cpp 4b3d671 
  src/plasma/package.cpp 4e0be88 
  src/plasma/packagestructure.cpp b2686b6 
  src/plasma/pluginloader.cpp 0ce349a 
  src/plasma/private/applet_p.cpp 2cbfd06 
  src/plasma/private/dataenginemanager.cpp b9c5d8e 
  src/plasma/scripting/appletscript.h 863d707 
  src/plasma/scripting/dataenginescript.h f7ad3c2 
  src/plasma/scripting/scriptengine.cpp cc407e7 
  src/plasma/service.h b5d9b5a 
  src/plasma/service.cpp 3e9d852 
  src/plasmapkg/plasmapkg.cpp d606365 
  src/scriptengines/CMakeLists.txt f566406 
  src/scriptengines/qml/CMakeLists.txt e7130db 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
  src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 

Diff: https://git.reviewboard.kde.org/r/123626/diff/


Testing
---

still needs a lot of testing, so far, with a master plasma-workspace notmal 
workspace functions seems fine


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-04 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/
---

(Updated May 4, 2015, 5:44 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

this ports most of libplasma away from sycoca, using instead a combination of 
KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
own little caches instead of the global sycoca cache)
a kservicetypetrader call is left in the loading of containmentactions since is 
the only way to make an older workspace still work, but is only a fallback, so 
containmentactions in plasma-workspace can be ported eventually as well


Diffs (updated)
-

  KF5PlasmaConfig.cmake.in dee79ca 
  KF5PlasmaMacros.cmake 24bebb4 
  src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43 
  src/plasma/applet.cpp 2dda381 
  src/plasma/containment.cpp 7eabbb8 
  src/plasma/containmentactions.cpp f24bdac 
  src/plasma/dataengine.cpp 4b3d671 
  src/plasma/package.cpp 4e0be88 
  src/plasma/packagestructure.cpp b2686b6 
  src/plasma/pluginloader.cpp 0ce349a 
  src/plasma/private/applet_p.cpp 2cbfd06 
  src/plasma/private/dataenginemanager.cpp b9c5d8e 
  src/plasma/scripting/appletscript.h 863d707 
  src/plasma/scripting/dataenginescript.h f7ad3c2 
  src/plasma/scripting/scriptengine.cpp cc407e7 
  src/plasma/service.h b5d9b5a 
  src/plasma/service.cpp 3e9d852 
  src/plasmapkg/plasmapkg.cpp d606365 
  src/scriptengines/CMakeLists.txt f566406 
  src/scriptengines/qml/CMakeLists.txt e7130db 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
  src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 

Diff: https://git.reviewboard.kde.org/r/123626/diff/


Testing
---

still needs a lot of testing, so far, with a master plasma-workspace notmal 
workspace functions seems fine


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-04 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123626/
---

(Updated May 4, 2015, 1:03 p.m.)


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

this ports most of libplasma away from sycoca, using instead a combination of 
KPluginLoader and KPackage::PackageLoader instead (so eventually using their 
own little caches instead of the global sycoca cache)
a kservicetypetrader call is left in the loading of containmentactions since is 
the only way to make an older workspace still work, but is only a fallback, so 
containmentactions in plasma-workspace can be ported eventually as well


Diffs
-

  KF5PlasmaConfig.cmake.in dee79ca 
  KF5PlasmaMacros.cmake 24bebb4 
  src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml be76a43 
  src/plasma/applet.cpp 2dda381 
  src/plasma/containment.cpp 7eabbb8 
  src/plasma/containmentactions.cpp f24bdac 
  src/plasma/dataengine.cpp 4b3d671 
  src/plasma/package.cpp 4e0be88 
  src/plasma/packagestructure.cpp b2686b6 
  src/plasma/pluginloader.cpp 0ce349a 
  src/plasma/private/applet_p.cpp 2cbfd06 
  src/plasma/private/dataenginemanager.cpp b9c5d8e 
  src/plasma/scripting/appletscript.h 863d707 
  src/plasma/scripting/dataenginescript.h f7ad3c2 
  src/plasma/scripting/scriptengine.cpp cc407e7 
  src/plasma/service.h b5d9b5a 
  src/plasma/service.cpp 3e9d852 
  src/plasmapkg/plasmapkg.cpp d606365 
  src/scriptengines/CMakeLists.txt f566406 
  src/scriptengines/qml/CMakeLists.txt e7130db 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 07ecb3d 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp c6986f2 
  src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 24c39dd 
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp a406d45 

Diff: https://git.reviewboard.kde.org/r/123626/diff/


Testing (updated)
---

still needs a lot of testing, so far, with a master plasma-workspace notmal 
workspace functions seems fine


Thanks,

Marco Martin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel