Re: Review Request 125145: Restore the disabling of auto-rebuild-on-error in kbuildsycoca.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125145/#review85136 --- What about removing s_autoRebuild and making KSycoca::disableAutoRebuild output a warning just in case someone weird out there is using it so they can get ready for KF6? - Albert Astals Cid On set. 10, 2015, 8:31 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125145/ > --- > > (Updated set. 10, 2015, 8:31 p.m.) > > > Review request for KDE Frameworks and Albert Astals Cid. > > > Repository: kservice > > > Description > --- > > 77a998e37 removed the call to KSycoca::disableAutoRebuild(), > we can just check that we are in kbuildsycoca using qAppName > like two other places in ksycoca.cpp already do. > And this way get rid of more unnecessary "public" API for ksycoca. > > > Diffs > - > > src/sycoca/ksycoca.h 5e762fddffa03c4e25218ed608d483dcd4b35bf4 > src/sycoca/ksycoca.cpp 2048c84660bc36e9a56b747eaee27757089363b4 > > Diff: https://git.reviewboard.kde.org/r/125145/diff/ > > > Testing > --- > > compiles. > > we don't have a unittest for a corrupt ksycoca file ;) > > > Thanks, > > David Faure > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125145: Restore the disabling of auto-rebuild-on-error in kbuildsycoca.
> On Sept. 10, 2015, 8:39 p.m., Albert Astals Cid wrote: > > What about removing s_autoRebuild and making KSycoca::disableAutoRebuild > > output a warning just in case someone weird out there is using it so they > > can get ready for KF6? Good point, that's indeed the alternative. It's less behaviour-compatible, but for something marked as @internal and which only ever makes any difference on a corrupt database... nobody had any reason to call this indeed. Will do, thanks. And I should use the DEPRECATED macro too. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125145/#review85136 --- On Sept. 10, 2015, 8:31 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125145/ > --- > > (Updated Sept. 10, 2015, 8:31 p.m.) > > > Review request for KDE Frameworks and Albert Astals Cid. > > > Repository: kservice > > > Description > --- > > 77a998e37 removed the call to KSycoca::disableAutoRebuild(), > we can just check that we are in kbuildsycoca using qAppName > like two other places in ksycoca.cpp already do. > And this way get rid of more unnecessary "public" API for ksycoca. > > > Diffs > - > > src/sycoca/ksycoca.h 5e762fddffa03c4e25218ed608d483dcd4b35bf4 > src/sycoca/ksycoca.cpp 2048c84660bc36e9a56b747eaee27757089363b4 > > Diff: https://git.reviewboard.kde.org/r/125145/diff/ > > > Testing > --- > > compiles. > > we don't have a unittest for a corrupt ksycoca file ;) > > > Thanks, > > David Faure > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125145: Restore the disabling of auto-rebuild-on-error in kbuildsycoca.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125145/ --- (Updated Sept. 10, 2015, 8:51 p.m.) Review request for KDE Frameworks and Albert Astals Cid. Changes --- remove the static bool Repository: kservice Description (updated) --- 77a998e37 removed the call to KSycoca::disableAutoRebuild(), we can just check that we are in kbuildsycoca using qAppName like two other places in ksycoca.cpp already do. And this way get rid of more unnecessary "public" API for ksycoca. REVIEW: 125145 Diffs (updated) - src/sycoca/ksycoca.h 5e762fddffa03c4e25218ed608d483dcd4b35bf4 src/sycoca/ksycoca.cpp 2048c84660bc36e9a56b747eaee27757089363b4 Diff: https://git.reviewboard.kde.org/r/125145/diff/ Testing --- compiles. we don't have a unittest for a corrupt ksycoca file ;) Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125145: Restore the disabling of auto-rebuild-on-error in kbuildsycoca.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125145/#review85142 --- Ship it! Ship It! - Albert Astals Cid On set. 10, 2015, 8:51 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125145/ > --- > > (Updated set. 10, 2015, 8:51 p.m.) > > > Review request for KDE Frameworks and Albert Astals Cid. > > > Repository: kservice > > > Description > --- > > 77a998e37 removed the call to KSycoca::disableAutoRebuild(), > we can just check that we are in kbuildsycoca using qAppName > like two other places in ksycoca.cpp already do. > And this way get rid of more unnecessary "public" API for ksycoca. > > REVIEW: 125145 > > > Diffs > - > > src/sycoca/ksycoca.h 5e762fddffa03c4e25218ed608d483dcd4b35bf4 > src/sycoca/ksycoca.cpp 2048c84660bc36e9a56b747eaee27757089363b4 > > Diff: https://git.reviewboard.kde.org/r/125145/diff/ > > > Testing > --- > > compiles. > > we don't have a unittest for a corrupt ksycoca file ;) > > > Thanks, > > David Faure > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125145: Restore the disabling of auto-rebuild-on-error in kbuildsycoca.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125145/ --- (Updated Sept. 10, 2015, 9:17 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Albert Astals Cid. Changes --- Submitted with commit 40d8500ab639a151b1655f6770493218bb2bf5ef by David Faure to branch master. Repository: kservice Description --- 77a998e37 removed the call to KSycoca::disableAutoRebuild(), we can just check that we are in kbuildsycoca using qAppName like two other places in ksycoca.cpp already do. And this way get rid of more unnecessary "public" API for ksycoca. REVIEW: 125145 Diffs - src/sycoca/ksycoca.h 5e762fddffa03c4e25218ed608d483dcd4b35bf4 src/sycoca/ksycoca.cpp 2048c84660bc36e9a56b747eaee27757089363b4 Diff: https://git.reviewboard.kde.org/r/125145/diff/ Testing --- compiles. we don't have a unittest for a corrupt ksycoca file ;) Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
