Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/#review85682 --- What happens on file systems that doesn't support hardlinks ? - Sune Vuorela On Sept. 19, 2015, 11:29 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125279/ > --- > > (Updated Sept. 19, 2015, 11:29 p.m.) > > > Review request for KDE Frameworks and Albert Astals Cid. > > > Repository: kservice > > > Description > --- > > This will prevent sycoca-rebuild ping-pong if two apps with different settings > would share the same file (and keep finding that it's wrong for them), > and it fixes Albert's bug that "LANG=de kcmshell5 --list" doesn't show German > translations for the strings coming from desktop files. > > To avoid migration issues, the old filename ksycoca5 is still provided, as a > hardlink > so that mmap works. > > REVIEW: 125279 > BUG: 340731 > FIXED-IN: 5.15 > > > Diffs > - > > autotests/ksycocatest.cpp 7c2d91e056726540b8a3a5c679d9b2a93f023c50 > docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook > d7f85813b1956b578600b4fbd147b3ac649b470c > src/sycoca/kbuildsycoca.cpp d3328f05bf761979bdffaa19f771e949759d6b76 > src/sycoca/ksycoca.h 34a2f6375148440aa6dc130395ed0e13b11d16e0 > src/sycoca/ksycoca.cpp a2b70407db3778196216969932c995c11f44fcf6 > > Diff: https://git.reviewboard.kde.org/r/125279/diff/ > > > Testing > --- > > unittests, after adjusting ksycocatest which was checking for the old > behavior (same file). > > Albert: there we are, finally ;) Your bug should be fixed (I don't have > translations installed to test it, though). Thanks for all the reviews! > > > Thanks, > > David Faure > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/ --- (Updated Sept. 20, 2015, 10:27 a.m.) Review request for KDE Frameworks and Albert Astals Cid. Changes --- fallback to copy if hardlink fails Repository: kservice Description (updated) --- This will prevent sycoca-rebuild ping-pong if two apps with different settings would share the same file (and keep finding that it's wrong for them), and it fixes Albert's bug that "LANG=de kcmshell5 --list" doesn't show German translations for the strings coming from desktop files. To avoid migration issues, the old filename ksycoca5 is still provided, as a hardlink so that mmap works. REVIEW: 125279 BUGS: 340731, 335780 FIXED-IN: 5.15 Diffs (updated) - autotests/ksycocatest.cpp 7c2d91e056726540b8a3a5c679d9b2a93f023c50 docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook d7f85813b1956b578600b4fbd147b3ac649b470c src/sycoca/kbuildsycoca.cpp d3328f05bf761979bdffaa19f771e949759d6b76 src/sycoca/ksycoca.h 34a2f6375148440aa6dc130395ed0e13b11d16e0 src/sycoca/ksycoca.cpp a2b70407db3778196216969932c995c11f44fcf6 Diff: https://git.reviewboard.kde.org/r/125279/diff/ Testing --- unittests, after adjusting ksycocatest which was checking for the old behavior (same file). Albert: there we are, finally ;) Your bug should be fixed (I don't have translations installed to test it, though). Thanks for all the reviews! Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/ --- (Updated Sept. 20, 2015, 5:15 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Albert Astals Cid. Changes --- Submitted with commit f1bdf30501b87cb79806362a68c7515ba755275a by David Faure to branch master. Repository: kservice Description --- This will prevent sycoca-rebuild ping-pong if two apps with different settings would share the same file (and keep finding that it's wrong for them), and it fixes Albert's bug that "LANG=de kcmshell5 --list" doesn't show German translations for the strings coming from desktop files. To avoid migration issues, the old filename ksycoca5 is still provided, as a hardlink so that mmap works. REVIEW: 125279 BUGS: 340731, 335780 FIXED-IN: 5.15 Diffs - autotests/ksycocatest.cpp 7c2d91e056726540b8a3a5c679d9b2a93f023c50 docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook d7f85813b1956b578600b4fbd147b3ac649b470c src/sycoca/kbuildsycoca.cpp d3328f05bf761979bdffaa19f771e949759d6b76 src/sycoca/ksycoca.h 34a2f6375148440aa6dc130395ed0e13b11d16e0 src/sycoca/ksycoca.cpp a2b70407db3778196216969932c995c11f44fcf6 Diff: https://git.reviewboard.kde.org/r/125279/diff/ Testing --- unittests, after adjusting ksycocatest which was checking for the old behavior (same file). Albert: there we are, finally ;) Your bug should be fixed (I don't have translations installed to test it, though). Thanks for all the reviews! Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/#review85693 --- Ship it! Ship It! - Albert Astals Cid On set. 20, 2015, 10:27 a.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125279/ > --- > > (Updated set. 20, 2015, 10:27 a.m.) > > > Review request for KDE Frameworks and Albert Astals Cid. > > > Repository: kservice > > > Description > --- > > This will prevent sycoca-rebuild ping-pong if two apps with different settings > would share the same file (and keep finding that it's wrong for them), > and it fixes Albert's bug that "LANG=de kcmshell5 --list" doesn't show German > translations for the strings coming from desktop files. > > To avoid migration issues, the old filename ksycoca5 is still provided, as a > hardlink > so that mmap works. > > REVIEW: 125279 > BUGS: 340731, 335780 > FIXED-IN: 5.15 > > > Diffs > - > > autotests/ksycocatest.cpp 7c2d91e056726540b8a3a5c679d9b2a93f023c50 > docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook > d7f85813b1956b578600b4fbd147b3ac649b470c > src/sycoca/kbuildsycoca.cpp d3328f05bf761979bdffaa19f771e949759d6b76 > src/sycoca/ksycoca.h 34a2f6375148440aa6dc130395ed0e13b11d16e0 > src/sycoca/ksycoca.cpp a2b70407db3778196216969932c995c11f44fcf6 > > Diff: https://git.reviewboard.kde.org/r/125279/diff/ > > > Testing > --- > > unittests, after adjusting ksycocatest which was checking for the old > behavior (same file). > > Albert: there we are, finally ;) Your bug should be fixed (I don't have > translations installed to test it, though). Thanks for all the reviews! > > > Thanks, > > David Faure > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/ --- (Updated Sept. 19, 2015, 7:34 p.m.) Review request for KDE Frameworks and Albert Astals Cid. Changes --- use hardlink on unix, copy on windows Repository: kservice Description (updated) --- This will prevent sycoca-rebuild ping-pong if two apps with different settings would share the same file (and keep finding that it's wrong for them), and it fixes Albert's bug that "LANG=de kcmshell5 --list" doesn't show German translations for the strings coming from desktop files. To avoid migration issues, the old filename ksycoca5 is still provided, as a hardlink so that mmap works. REVIEW: 125279 Diffs (updated) - autotests/ksycocatest.cpp 7c2d91e056726540b8a3a5c679d9b2a93f023c50 docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook d7f85813b1956b578600b4fbd147b3ac649b470c src/sycoca/kbuildsycoca.cpp d3328f05bf761979bdffaa19f771e949759d6b76 src/sycoca/ksycoca.h a78e90876ed758093070989ab166959e0ea6c0e3 src/sycoca/ksycoca.cpp a2b70407db3778196216969932c995c11f44fcf6 Diff: https://git.reviewboard.kde.org/r/125279/diff/ Testing --- unittests, after adjusting ksycocatest which was checking for the old behavior (same file). Albert: there we are, finally ;) Your bug should be fixed (I don't have translations installed to test it, though). Thanks for all the reviews! Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.
> On Sept. 19, 2015, 3:47 p.m., David Faure wrote: > > Hmmm... and then old-kded crashed. You can't mmap a symlink? > > > > #10 0x7f6b0c76d6d4 in qt_assert(char const*, char const*, int) > > (assertion=0x7f6b0d69fbbf [...] "canRead", file=[...] > > "/d/kde/src/5/frameworks/kservice/src/sycoca/ksycoca.cpp", line=125) at > > global/qglobal.cpp:2966 > > #11 0x7f6b0d6607d7 in KSycocaPrivate::tryMmap() (this=0x1a5d840) at > > /d/kde/src/5/frameworks/kservice/src/sycoca/ksycoca.cpp:120 > > Albert Astals Cid wrote: > Does a hardlink instaead of a symlink work? Great idea, thanks. Seems to work. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/#review85670 --- On Sept. 19, 2015, 3:43 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125279/ > --- > > (Updated Sept. 19, 2015, 3:43 p.m.) > > > Review request for KDE Frameworks and Albert Astals Cid. > > > Repository: kservice > > > Description > --- > > This will prevent sycoca-rebuild ping-pong if two apps with different settings > would share the same file (and keep finding that it's wrong for them), > and it fixes Albert's bug that "LANG=de kcmshell5 --list" doesn't show German > translations for the strings coming from desktop files. > > REVIEW: 125279 > > > Diffs > - > > src/sycoca/kbuildsycoca.cpp d3328f05bf761979bdffaa19f771e949759d6b76 > autotests/ksycocatest.cpp 7c2d91e056726540b8a3a5c679d9b2a93f023c50 > docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook > d7f85813b1956b578600b4fbd147b3ac649b470c > src/sycoca/ksycoca.h a78e90876ed758093070989ab166959e0ea6c0e3 > src/sycoca/ksycoca.cpp a2b70407db3778196216969932c995c11f44fcf6 > > Diff: https://git.reviewboard.kde.org/r/125279/diff/ > > > Testing > --- > > unittests, after adjusting ksycocatest which was checking for the old > behavior (same file). > > Albert: there we are, finally ;) Your bug should be fixed (I don't have > translations installed to test it, though). Thanks for all the reviews! > > > Thanks, > > David Faure > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.
> On Sept. 18, 2015, 8:37 p.m., Albert Astals Cid wrote: > > Ship It! I just realized that there is a possible migration problem with this patch. If you upgrade kservice in a running plasma5 session, and then install some app, it will never show up in the K menu (or be launched when clicking on a file, etc.) because the running apps will be looking at the old ksycoca5 while kbuildsycoca will update ksycoca5-lang-dirs. Is this acceptable? If not, I don't really want to "also write out ksycoca5" because that sounds slow and in theory we'd have to keep that code until KF6... Maybe kbuildsycoca5 could turn ksycoca5 into a symlink? - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/#review85643 --- On Sept. 16, 2015, 11:30 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125279/ > --- > > (Updated Sept. 16, 2015, 11:30 p.m.) > > > Review request for KDE Frameworks and Albert Astals Cid. > > > Repository: kservice > > > Description > --- > > This will prevent sycoca-rebuild ping-pong if two apps with different settings > would share the same file (and keep finding that it's wrong for them), > and it fixes Albert's bug that "LANG=de kcmshell5 --list" doesn't show German > translations for the strings coming from desktop files. > > > Diffs > - > > autotests/ksycocatest.cpp 7c2d91e056726540b8a3a5c679d9b2a93f023c50 > docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook > 3419e42cb29c6699bc17e6dd46bbc523139c59eb > src/sycoca/kbuildsycoca.cpp 3685211e9da68f14516ec2b3d9a7e6b4f559b6f3 > src/sycoca/ksycoca.h c561dfd1550fd28e73144af6d3b2fa9008b17f59 > src/sycoca/ksycoca.cpp c5465a828da615e87220304e3f8b160d471edbc7 > > Diff: https://git.reviewboard.kde.org/r/125279/diff/ > > > Testing > --- > > unittests, after adjusting ksycocatest which was checking for the old > behavior (same file). > > Albert: there we are, finally ;) Your bug should be fixed (I don't have > translations installed to test it, though). Thanks for all the reviews! > > > Thanks, > > David Faure > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.
> On set. 18, 2015, 8:37 p.m., Albert Astals Cid wrote: > > Ship It! > > David Faure wrote: > I just realized that there is a possible migration problem with this > patch. > If you upgrade kservice in a running plasma5 session, and then install > some app, it will never show up in the K menu (or be launched when clicking > on a file, etc.) because the running apps will be looking at the old ksycoca5 > while kbuildsycoca will update ksycoca5-lang-dirs. > Is this acceptable? > > If not, I don't really want to "also write out ksycoca5" because that > sounds slow and in theory we'd have to keep that code until KF6... > > Maybe kbuildsycoca5 could turn ksycoca5 into a symlink? Right, old code would call the new binary whose output would mean nothing to the old code, good catch. I agree writing twice seems unnecessary, the symlink seems an ok solution since it should not be that slow. - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/#review85643 --- On set. 16, 2015, 11:30 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125279/ > --- > > (Updated set. 16, 2015, 11:30 p.m.) > > > Review request for KDE Frameworks and Albert Astals Cid. > > > Repository: kservice > > > Description > --- > > This will prevent sycoca-rebuild ping-pong if two apps with different settings > would share the same file (and keep finding that it's wrong for them), > and it fixes Albert's bug that "LANG=de kcmshell5 --list" doesn't show German > translations for the strings coming from desktop files. > > > Diffs > - > > autotests/ksycocatest.cpp 7c2d91e056726540b8a3a5c679d9b2a93f023c50 > docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook > 3419e42cb29c6699bc17e6dd46bbc523139c59eb > src/sycoca/kbuildsycoca.cpp 3685211e9da68f14516ec2b3d9a7e6b4f559b6f3 > src/sycoca/ksycoca.h c561dfd1550fd28e73144af6d3b2fa9008b17f59 > src/sycoca/ksycoca.cpp c5465a828da615e87220304e3f8b160d471edbc7 > > Diff: https://git.reviewboard.kde.org/r/125279/diff/ > > > Testing > --- > > unittests, after adjusting ksycocatest which was checking for the old > behavior (same file). > > Albert: there we are, finally ;) Your bug should be fixed (I don't have > translations installed to test it, though). Thanks for all the reviews! > > > Thanks, > > David Faure > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/ --- (Updated Sept. 19, 2015, 11:29 p.m.) Review request for KDE Frameworks and Albert Astals Cid. Changes --- don't include the sha1-of-dirs in the global sycoca, /home/dfaure/.local/share/applications would make it unusable for other users Repository: kservice Description (updated) --- This will prevent sycoca-rebuild ping-pong if two apps with different settings would share the same file (and keep finding that it's wrong for them), and it fixes Albert's bug that "LANG=de kcmshell5 --list" doesn't show German translations for the strings coming from desktop files. To avoid migration issues, the old filename ksycoca5 is still provided, as a hardlink so that mmap works. REVIEW: 125279 BUG: 340731 FIXED-IN: 5.15 Diffs (updated) - autotests/ksycocatest.cpp 7c2d91e056726540b8a3a5c679d9b2a93f023c50 docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook d7f85813b1956b578600b4fbd147b3ac649b470c src/sycoca/kbuildsycoca.cpp d3328f05bf761979bdffaa19f771e949759d6b76 src/sycoca/ksycoca.h 34a2f6375148440aa6dc130395ed0e13b11d16e0 src/sycoca/ksycoca.cpp a2b70407db3778196216969932c995c11f44fcf6 Diff: https://git.reviewboard.kde.org/r/125279/diff/ Testing --- unittests, after adjusting ksycocatest which was checking for the old behavior (same file). Albert: there we are, finally ;) Your bug should be fixed (I don't have translations installed to test it, though). Thanks for all the reviews! Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/ --- (Updated Sept. 19, 2015, 3:43 p.m.) Review request for KDE Frameworks and Albert Astals Cid. Changes --- added symlink creation (tested) replace '/' (and ':' in windows) with '_' Repository: kservice Description (updated) --- This will prevent sycoca-rebuild ping-pong if two apps with different settings would share the same file (and keep finding that it's wrong for them), and it fixes Albert's bug that "LANG=de kcmshell5 --list" doesn't show German translations for the strings coming from desktop files. REVIEW: 125279 Diffs (updated) - src/sycoca/kbuildsycoca.cpp d3328f05bf761979bdffaa19f771e949759d6b76 autotests/ksycocatest.cpp 7c2d91e056726540b8a3a5c679d9b2a93f023c50 docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook d7f85813b1956b578600b4fbd147b3ac649b470c src/sycoca/ksycoca.h a78e90876ed758093070989ab166959e0ea6c0e3 src/sycoca/ksycoca.cpp a2b70407db3778196216969932c995c11f44fcf6 Diff: https://git.reviewboard.kde.org/r/125279/diff/ Testing --- unittests, after adjusting ksycocatest which was checking for the old behavior (same file). Albert: there we are, finally ;) Your bug should be fixed (I don't have translations installed to test it, though). Thanks for all the reviews! Thanks, David Faure ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/#review85670 --- Hmmm... and then old-kded crashed. You can't mmap a symlink? #10 0x7f6b0c76d6d4 in qt_assert(char const*, char const*, int) (assertion=0x7f6b0d69fbbf [...] "canRead", file=[...] "/d/kde/src/5/frameworks/kservice/src/sycoca/ksycoca.cpp", line=125) at global/qglobal.cpp:2966 #11 0x7f6b0d6607d7 in KSycocaPrivate::tryMmap() (this=0x1a5d840) at /d/kde/src/5/frameworks/kservice/src/sycoca/ksycoca.cpp:120 - David Faure On Sept. 19, 2015, 3:43 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125279/ > --- > > (Updated Sept. 19, 2015, 3:43 p.m.) > > > Review request for KDE Frameworks and Albert Astals Cid. > > > Repository: kservice > > > Description > --- > > This will prevent sycoca-rebuild ping-pong if two apps with different settings > would share the same file (and keep finding that it's wrong for them), > and it fixes Albert's bug that "LANG=de kcmshell5 --list" doesn't show German > translations for the strings coming from desktop files. > > REVIEW: 125279 > > > Diffs > - > > src/sycoca/kbuildsycoca.cpp d3328f05bf761979bdffaa19f771e949759d6b76 > autotests/ksycocatest.cpp 7c2d91e056726540b8a3a5c679d9b2a93f023c50 > docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook > d7f85813b1956b578600b4fbd147b3ac649b470c > src/sycoca/ksycoca.h a78e90876ed758093070989ab166959e0ea6c0e3 > src/sycoca/ksycoca.cpp a2b70407db3778196216969932c995c11f44fcf6 > > Diff: https://git.reviewboard.kde.org/r/125279/diff/ > > > Testing > --- > > unittests, after adjusting ksycocatest which was checking for the old > behavior (same file). > > Albert: there we are, finally ;) Your bug should be fixed (I don't have > translations installed to test it, though). Thanks for all the reviews! > > > Thanks, > > David Faure > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.
> On set. 19, 2015, 3:47 p.m., David Faure wrote: > > Hmmm... and then old-kded crashed. You can't mmap a symlink? > > > > #10 0x7f6b0c76d6d4 in qt_assert(char const*, char const*, int) > > (assertion=0x7f6b0d69fbbf [...] "canRead", file=[...] > > "/d/kde/src/5/frameworks/kservice/src/sycoca/ksycoca.cpp", line=125) at > > global/qglobal.cpp:2966 > > #11 0x7f6b0d6607d7 in KSycocaPrivate::tryMmap() (this=0x1a5d840) at > > /d/kde/src/5/frameworks/kservice/src/sycoca/ksycoca.cpp:120 Does a hardlink instaead of a symlink work? - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/#review85670 --- On set. 19, 2015, 3:43 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125279/ > --- > > (Updated set. 19, 2015, 3:43 p.m.) > > > Review request for KDE Frameworks and Albert Astals Cid. > > > Repository: kservice > > > Description > --- > > This will prevent sycoca-rebuild ping-pong if two apps with different settings > would share the same file (and keep finding that it's wrong for them), > and it fixes Albert's bug that "LANG=de kcmshell5 --list" doesn't show German > translations for the strings coming from desktop files. > > REVIEW: 125279 > > > Diffs > - > > src/sycoca/kbuildsycoca.cpp d3328f05bf761979bdffaa19f771e949759d6b76 > autotests/ksycocatest.cpp 7c2d91e056726540b8a3a5c679d9b2a93f023c50 > docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook > d7f85813b1956b578600b4fbd147b3ac649b470c > src/sycoca/ksycoca.h a78e90876ed758093070989ab166959e0ea6c0e3 > src/sycoca/ksycoca.cpp a2b70407db3778196216969932c995c11f44fcf6 > > Diff: https://git.reviewboard.kde.org/r/125279/diff/ > > > Testing > --- > > unittests, after adjusting ksycocatest which was checking for the old > behavior (same file). > > Albert: there we are, finally ;) Your bug should be fixed (I don't have > translations installed to test it, though). Thanks for all the reviews! > > > Thanks, > > David Faure > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/#review85643 --- Ship it! Ship It! - Albert Astals Cid On set. 16, 2015, 11:30 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125279/ > --- > > (Updated set. 16, 2015, 11:30 p.m.) > > > Review request for KDE Frameworks and Albert Astals Cid. > > > Repository: kservice > > > Description > --- > > This will prevent sycoca-rebuild ping-pong if two apps with different settings > would share the same file (and keep finding that it's wrong for them), > and it fixes Albert's bug that "LANG=de kcmshell5 --list" doesn't show German > translations for the strings coming from desktop files. > > > Diffs > - > > autotests/ksycocatest.cpp 7c2d91e056726540b8a3a5c679d9b2a93f023c50 > docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook > 3419e42cb29c6699bc17e6dd46bbc523139c59eb > src/sycoca/kbuildsycoca.cpp 3685211e9da68f14516ec2b3d9a7e6b4f559b6f3 > src/sycoca/ksycoca.h c561dfd1550fd28e73144af6d3b2fa9008b17f59 > src/sycoca/ksycoca.cpp c5465a828da615e87220304e3f8b160d471edbc7 > > Diff: https://git.reviewboard.kde.org/r/125279/diff/ > > > Testing > --- > > unittests, after adjusting ksycocatest which was checking for the old > behavior (same file). > > Albert: there we are, finally ;) Your bug should be fixed (I don't have > translations installed to test it, though). Thanks for all the reviews! > > > Thanks, > > David Faure > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125279: KSycoca: change DB filename to include language and sha1 of the dirs it's built from.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125279/#review85532 --- +1 - Aleix Pol Gonzalez On Sept. 17, 2015, 1:30 a.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125279/ > --- > > (Updated Sept. 17, 2015, 1:30 a.m.) > > > Review request for KDE Frameworks and Albert Astals Cid. > > > Repository: kservice > > > Description > --- > > This will prevent sycoca-rebuild ping-pong if two apps with different settings > would share the same file (and keep finding that it's wrong for them), > and it fixes Albert's bug that "LANG=de kcmshell5 --list" doesn't show German > translations for the strings coming from desktop files. > > > Diffs > - > > autotests/ksycocatest.cpp 7c2d91e056726540b8a3a5c679d9b2a93f023c50 > docs/kbuildsycoca5/man-kbuildsycoca5.8.docbook > 3419e42cb29c6699bc17e6dd46bbc523139c59eb > src/sycoca/kbuildsycoca.cpp 3685211e9da68f14516ec2b3d9a7e6b4f559b6f3 > src/sycoca/ksycoca.h c561dfd1550fd28e73144af6d3b2fa9008b17f59 > src/sycoca/ksycoca.cpp c5465a828da615e87220304e3f8b160d471edbc7 > > Diff: https://git.reviewboard.kde.org/r/125279/diff/ > > > Testing > --- > > unittests, after adjusting ksycocatest which was checking for the old > behavior (same file). > > Albert: there we are, finally ;) Your bug should be fixed (I don't have > translations installed to test it, though). Thanks for all the reviews! > > > Thanks, > > David Faure > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
