Re: Review Request 125658: Do not treat the context menu button as modifier

2015-10-19 Thread Thomas Lübking

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125658/
---

(Updated Oct. 19, 2015, 7:21 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Christoph Feck and Hans Chen.


Changes
---

Submitted with commit 3b690ae01b31faaddaa38ca6ef5425ef68f7546c by Thomas 
Lübking to branch master.


Bugs: 165542
https://bugs.kde.org/show_bug.cgi?id=165542


Repository: kxmlgui


Description
---

It's not and not treated as such by Qt either.

In addition suck context events while recording
(so it doesn't activate, rather cosmetic)

BUG: 165542
FIXED-IN: 5.16
CHANGELOG: Allow to bind the contextmenu key (lower right) to shortcuts


Diffs
-

  src/kkeysequencewidget.cpp 2385f20 

Diff: https://git.reviewboard.kde.org/r/125658/diff/


Testing
---

yupp.


Thanks,

Thomas Lübking

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 125658: Do not treat the context menu button as modifier

2015-10-18 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125658/#review87034
---

Ship it!


Makes sense to me.

- Aleix Pol Gonzalez


On Oct. 18, 2015, 4:45 p.m., Thomas Lübking wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125658/
> ---
> 
> (Updated Oct. 18, 2015, 4:45 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Feck and Hans Chen.
> 
> 
> Bugs: 165542
> https://bugs.kde.org/show_bug.cgi?id=165542
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> ---
> 
> It's not and not treated as such by Qt either.
> 
> In addition suck context events while recording
> (so it doesn't activate, rather cosmetic)
> 
> BUG: 165542
> FIXED-IN: 5.16
> CHANGELOG: Allow to bind the contextmenu key (lower right) to shortcuts
> 
> 
> Diffs
> -
> 
>   src/kkeysequencewidget.cpp 2385f20 
> 
> Diff: https://git.reviewboard.kde.org/r/125658/diff/
> 
> 
> Testing
> ---
> 
> yupp.
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 125658: Do not treat the context menu button as modifier

2015-10-18 Thread Thomas Lübking

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125658/
---

(Updated Okt. 18, 2015, 2:45 nachm.)


Review request for KDE Frameworks, Christoph Feck and Hans Chen.


Changes
---

getting a bit more audience for comments ;-)


Bugs: 165542
https://bugs.kde.org/show_bug.cgi?id=165542


Repository: kxmlgui


Description
---

It's not and not treated as such by Qt either.

In addition suck context events while recording
(so it doesn't activate, rather cosmetic)

BUG: 165542
FIXED-IN: 5.16
CHANGELOG: Allow to bind the contextmenu key (lower right) to shortcuts


Diffs
-

  src/kkeysequencewidget.cpp 2385f20 

Diff: https://git.reviewboard.kde.org/r/125658/diff/


Testing
---

yupp.


Thanks,

Thomas Lübking

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel