Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126091/ --- (Updated Nov. 24, 2015, 11:53 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Plasma and David Edmundson. Changes --- Submitted with commit a8c177911dea1e099bfb499f199ee7039c756cde by Boudhayan Gupta to branch master. Repository: khotkeys Description --- After moving KSnapshot to Extragear I've modified it to install its own khotkeys file (which it does correctly). Spectacle already installs its own KHotkeys file, so there's no reason anymore for KHotkeys to include its own PrintScreen hotkey file. I'll push out a special release of KSnapshot for distributions to use once the Plasma 5.5 version of KHotkeys is pushed out, so printscreen functionality won't be broken on the desktop (assuming, that is, distros push out the updates together). Diffs - data/CMakeLists.txt f3bcb57 data/printscreen.khotkeys e583311 Diff: https://git.reviewboard.kde.org/r/126091/diff/ Testing --- Doesn't install the printscreen.khotkeys file anymore Thanks, Boudhayan Gupta ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126091/#review88756 --- Since there has been no negative comments from the kde-distro-packagers mailing list posting (in fact, no comments at all), I'm committing this to Plasma/5.5 and merging to master. Reference to posting: https://mail.kde.org/pipermail/kde-distro-packagers/2015-November/000107.html - Boudhayan Gupta On Nov. 16, 2015, 10:36 p.m., Boudhayan Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126091/ > --- > > (Updated Nov. 16, 2015, 10:36 p.m.) > > > Review request for KDE Frameworks, Plasma and David Edmundson. > > > Repository: khotkeys > > > Description > --- > > After moving KSnapshot to Extragear I've modified it to install its own > khotkeys file (which it does correctly). Spectacle already installs its own > KHotkeys file, so there's no reason anymore for KHotkeys to include its own > PrintScreen hotkey file. > > I'll push out a special release of KSnapshot for distributions to use once > the Plasma 5.5 version of KHotkeys is pushed out, so printscreen > functionality won't be broken on the desktop (assuming, that is, distros push > out the updates together). > > > Diffs > - > > data/CMakeLists.txt f3bcb57 > data/printscreen.khotkeys e583311 > > Diff: https://git.reviewboard.kde.org/r/126091/diff/ > > > Testing > --- > > Doesn't install the printscreen.khotkeys file anymore > > > Thanks, > > Boudhayan Gupta > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126091/#review88757 --- You commited it to wrong branch.. should be Plasma/5.5 then master. - Bhushan Shah On Nov. 24, 2015, 5:23 p.m., Boudhayan Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126091/ > --- > > (Updated Nov. 24, 2015, 5:23 p.m.) > > > Review request for KDE Frameworks, Plasma and David Edmundson. > > > Repository: khotkeys > > > Description > --- > > After moving KSnapshot to Extragear I've modified it to install its own > khotkeys file (which it does correctly). Spectacle already installs its own > KHotkeys file, so there's no reason anymore for KHotkeys to include its own > PrintScreen hotkey file. > > I'll push out a special release of KSnapshot for distributions to use once > the Plasma 5.5 version of KHotkeys is pushed out, so printscreen > functionality won't be broken on the desktop (assuming, that is, distros push > out the updates together). > > > Diffs > - > > data/CMakeLists.txt f3bcb57 > data/printscreen.khotkeys e583311 > > Diff: https://git.reviewboard.kde.org/r/126091/diff/ > > > Testing > --- > > Doesn't install the printscreen.khotkeys file anymore > > > Thanks, > > Boudhayan Gupta > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package
> On Nov. 24, 2015, 5:32 p.m., Bhushan Shah wrote: > > You commited it to wrong branch.. should be Plasma/5.5 then master. Pushed master first, sorry :-D - Boudhayan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126091/#review88757 --- On Nov. 24, 2015, 5:23 p.m., Boudhayan Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126091/ > --- > > (Updated Nov. 24, 2015, 5:23 p.m.) > > > Review request for KDE Frameworks, Plasma and David Edmundson. > > > Repository: khotkeys > > > Description > --- > > After moving KSnapshot to Extragear I've modified it to install its own > khotkeys file (which it does correctly). Spectacle already installs its own > KHotkeys file, so there's no reason anymore for KHotkeys to include its own > PrintScreen hotkey file. > > I'll push out a special release of KSnapshot for distributions to use once > the Plasma 5.5 version of KHotkeys is pushed out, so printscreen > functionality won't be broken on the desktop (assuming, that is, distros push > out the updates together). > > > Diffs > - > > data/CMakeLists.txt f3bcb57 > data/printscreen.khotkeys e583311 > > Diff: https://git.reviewboard.kde.org/r/126091/diff/ > > > Testing > --- > > Doesn't install the printscreen.khotkeys file anymore > > > Thanks, > > Boudhayan Gupta > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package
> On Nov. 16, 2015, 10:46 p.m., Hrvoje Senjan wrote: > > >assuming, that is, distros push out the updates together > > > > don't assume this ;-) at least send a mail to kde-distro-packagers about > > the sideeffects if those 3 are pushed asynchronously > > Boudhayan Gupta wrote: > 'course, I'll post there as well as add a big fat notice to the > kde-apps-announce posting that announces this special release of KSnapshot. > > So ship it? > > David Edmundson wrote: > Lets email them first. Check they're ok with it, before we do it. Haven't had any negative comments (or any comments at all) on the thread yet. Should I commit it now (and generate the KSnapshot tarballs)? The Plasma release is just days away. - Boudhayan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126091/#review88438 --- On Nov. 16, 2015, 10:36 p.m., Boudhayan Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126091/ > --- > > (Updated Nov. 16, 2015, 10:36 p.m.) > > > Review request for KDE Frameworks, Plasma and David Edmundson. > > > Repository: khotkeys > > > Description > --- > > After moving KSnapshot to Extragear I've modified it to install its own > khotkeys file (which it does correctly). Spectacle already installs its own > KHotkeys file, so there's no reason anymore for KHotkeys to include its own > PrintScreen hotkey file. > > I'll push out a special release of KSnapshot for distributions to use once > the Plasma 5.5 version of KHotkeys is pushed out, so printscreen > functionality won't be broken on the desktop (assuming, that is, distros push > out the updates together). > > > Diffs > - > > data/CMakeLists.txt f3bcb57 > data/printscreen.khotkeys e583311 > > Diff: https://git.reviewboard.kde.org/r/126091/diff/ > > > Testing > --- > > Doesn't install the printscreen.khotkeys file anymore > > > Thanks, > > Boudhayan Gupta > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package
> On Nov. 16, 2015, 5:16 p.m., Hrvoje Senjan wrote: > > >assuming, that is, distros push out the updates together > > > > don't assume this ;-) at least send a mail to kde-distro-packagers about > > the sideeffects if those 3 are pushed asynchronously > > Boudhayan Gupta wrote: > 'course, I'll post there as well as add a big fat notice to the > kde-apps-announce posting that announces this special release of KSnapshot. > > So ship it? Lets email them first. Check they're ok with it, before we do it. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126091/#review88438 --- On Nov. 16, 2015, 5:06 p.m., Boudhayan Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126091/ > --- > > (Updated Nov. 16, 2015, 5:06 p.m.) > > > Review request for KDE Frameworks, Plasma and David Edmundson. > > > Repository: khotkeys > > > Description > --- > > After moving KSnapshot to Extragear I've modified it to install its own > khotkeys file (which it does correctly). Spectacle already installs its own > KHotkeys file, so there's no reason anymore for KHotkeys to include its own > PrintScreen hotkey file. > > I'll push out a special release of KSnapshot for distributions to use once > the Plasma 5.5 version of KHotkeys is pushed out, so printscreen > functionality won't be broken on the desktop (assuming, that is, distros push > out the updates together). > > > Diffs > - > > data/CMakeLists.txt f3bcb57 > data/printscreen.khotkeys e583311 > > Diff: https://git.reviewboard.kde.org/r/126091/diff/ > > > Testing > --- > > Doesn't install the printscreen.khotkeys file anymore > > > Thanks, > > Boudhayan Gupta > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package
> On Nov. 17, 2015, 12:51 p.m., Martin Gräßlin wrote:
> > should the file be added to ksnapshot?
Already done, installs to both {CMAKE_INSTALL_PREFIX}/share/khotkeys and
{CMAKE_INSTALL_PREFIX}/share/apps/khotkeys (for kde4 compatibility)
- Boudhayan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126091/#review88456
---
On Nov. 16, 2015, 10:36 p.m., Boudhayan Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126091/
> ---
>
> (Updated Nov. 16, 2015, 10:36 p.m.)
>
>
> Review request for KDE Frameworks, Plasma and David Edmundson.
>
>
> Repository: khotkeys
>
>
> Description
> ---
>
> After moving KSnapshot to Extragear I've modified it to install its own
> khotkeys file (which it does correctly). Spectacle already installs its own
> KHotkeys file, so there's no reason anymore for KHotkeys to include its own
> PrintScreen hotkey file.
>
> I'll push out a special release of KSnapshot for distributions to use once
> the Plasma 5.5 version of KHotkeys is pushed out, so printscreen
> functionality won't be broken on the desktop (assuming, that is, distros push
> out the updates together).
>
>
> Diffs
> -
>
> data/CMakeLists.txt f3bcb57
> data/printscreen.khotkeys e583311
>
> Diff: https://git.reviewboard.kde.org/r/126091/diff/
>
>
> Testing
> ---
>
> Doesn't install the printscreen.khotkeys file anymore
>
>
> Thanks,
>
> Boudhayan Gupta
>
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126091/#review88438 --- >assuming, that is, distros push out the updates together don't assume this ;-) at least send a mail to kde-distro-packagers about the sideeffects if those 3 are pushed asynchronously - Hrvoje Senjan On Nov. 16, 2015, 6:06 p.m., Boudhayan Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126091/ > --- > > (Updated Nov. 16, 2015, 6:06 p.m.) > > > Review request for KDE Frameworks, Plasma and David Edmundson. > > > Repository: khotkeys > > > Description > --- > > After moving KSnapshot to Extragear I've modified it to install its own > khotkeys file (which it does correctly). Spectacle already installs its own > KHotkeys file, so there's no reason anymore for KHotkeys to include its own > PrintScreen hotkey file. > > I'll push out a special release of KSnapshot for distributions to use once > the Plasma 5.5 version of KHotkeys is pushed out, so printscreen > functionality won't be broken on the desktop (assuming, that is, distros push > out the updates together). > > > Diffs > - > > data/CMakeLists.txt f3bcb57 > data/printscreen.khotkeys e583311 > > Diff: https://git.reviewboard.kde.org/r/126091/diff/ > > > Testing > --- > > Doesn't install the printscreen.khotkeys file anymore > > > Thanks, > > Boudhayan Gupta > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package
> On Nov. 16, 2015, 10:46 p.m., Hrvoje Senjan wrote: > > >assuming, that is, distros push out the updates together > > > > don't assume this ;-) at least send a mail to kde-distro-packagers about > > the sideeffects if those 3 are pushed asynchronously 'course, I'll post there as well as add a big fat notice to the kde-apps-announce posting that announces this special release of KSnapshot. So ship it? - Boudhayan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126091/#review88438 --- On Nov. 16, 2015, 10:36 p.m., Boudhayan Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126091/ > --- > > (Updated Nov. 16, 2015, 10:36 p.m.) > > > Review request for KDE Frameworks, Plasma and David Edmundson. > > > Repository: khotkeys > > > Description > --- > > After moving KSnapshot to Extragear I've modified it to install its own > khotkeys file (which it does correctly). Spectacle already installs its own > KHotkeys file, so there's no reason anymore for KHotkeys to include its own > PrintScreen hotkey file. > > I'll push out a special release of KSnapshot for distributions to use once > the Plasma 5.5 version of KHotkeys is pushed out, so printscreen > functionality won't be broken on the desktop (assuming, that is, distros push > out the updates together). > > > Diffs > - > > data/CMakeLists.txt f3bcb57 > data/printscreen.khotkeys e583311 > > Diff: https://git.reviewboard.kde.org/r/126091/diff/ > > > Testing > --- > > Doesn't install the printscreen.khotkeys file anymore > > > Thanks, > > Boudhayan Gupta > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126091/#review88456 --- should the file be added to ksnapshot? - Martin Gräßlin On Nov. 16, 2015, 6:06 p.m., Boudhayan Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126091/ > --- > > (Updated Nov. 16, 2015, 6:06 p.m.) > > > Review request for KDE Frameworks, Plasma and David Edmundson. > > > Repository: khotkeys > > > Description > --- > > After moving KSnapshot to Extragear I've modified it to install its own > khotkeys file (which it does correctly). Spectacle already installs its own > KHotkeys file, so there's no reason anymore for KHotkeys to include its own > PrintScreen hotkey file. > > I'll push out a special release of KSnapshot for distributions to use once > the Plasma 5.5 version of KHotkeys is pushed out, so printscreen > functionality won't be broken on the desktop (assuming, that is, distros push > out the updates together). > > > Diffs > - > > data/CMakeLists.txt f3bcb57 > data/printscreen.khotkeys e583311 > > Diff: https://git.reviewboard.kde.org/r/126091/diff/ > > > Testing > --- > > Doesn't install the printscreen.khotkeys file anymore > > > Thanks, > > Boudhayan Gupta > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
