Re: Review Request 126675: Add .kra and .ora qimagio plugins

2016-01-31 Thread Boudewijn Rempt 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126675/
---

(Updated Jan. 31, 2016, 3:01 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Alex Merry.


Changes
---

Submitted with commit 6934d5441778a09d157836a590236e3dc8d5a492 by Boudewijn 
Rempt to branch master.


Repository: kimageformats


Description
---

These qimageio plugins originally come from krita, but people who haven't got 
krita installed might want to view Krita or OpenRaster images as well. Both 
formats are really simple, just zip files with a png inside that represents the 
merged image. This patch does add a KF5::Archive dependency to kimageformats.


Diffs
-

  CMakeLists.txt 1e7e703 
  autotests/CMakeLists.txt 853607e 
  autotests/read/kra/src.kra PRE-CREATION 
  autotests/read/kra/src.png PRE-CREATION 
  autotests/read/ora/src.ora PRE-CREATION 
  autotests/read/ora/src.png PRE-CREATION 
  src/imageformats/CMakeLists.txt 8cf8d54 
  src/imageformats/kra.cpp PRE-CREATION 
  src/imageformats/kra.desktop PRE-CREATION 
  src/imageformats/kra.h PRE-CREATION 
  src/imageformats/kra.json PRE-CREATION 
  src/imageformats/ora.cpp PRE-CREATION 
  src/imageformats/ora.desktop PRE-CREATION 
  src/imageformats/ora.h PRE-CREATION 
  src/imageformats/ora.json PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126675/diff/


Testing
---


Thanks,

Boudewijn Rempt

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126675: Add .kra and .ora qimagio plugins

2016-01-31 Thread Boudewijn Rempt 


> On Jan. 31, 2016, 1:03 p.m., Alex Merry wrote:
> > CMakeLists.txt, line 22
> > 
> >
> > What about making this optional (and only building those two plugins if 
> > it is found)?

Fine with me.


- Boudewijn


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126675/#review91821
---


On Jan. 27, 2016, 9:48 a.m., Boudewijn Rempt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126675/
> ---
> 
> (Updated Jan. 27, 2016, 9:48 a.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> ---
> 
> These qimageio plugins originally come from krita, but people who haven't got 
> krita installed might want to view Krita or OpenRaster images as well. Both 
> formats are really simple, just zip files with a png inside that represents 
> the merged image. This patch does add a KF5::Archive dependency to 
> kimageformats.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 1e7e703 
>   autotests/CMakeLists.txt 853607e 
>   autotests/read/kra/src.kra PRE-CREATION 
>   autotests/read/kra/src.png PRE-CREATION 
>   autotests/read/ora/src.ora PRE-CREATION 
>   autotests/read/ora/src.png PRE-CREATION 
>   src/imageformats/CMakeLists.txt 8cf8d54 
>   src/imageformats/kra.cpp PRE-CREATION 
>   src/imageformats/kra.desktop PRE-CREATION 
>   src/imageformats/kra.h PRE-CREATION 
>   src/imageformats/kra.json PRE-CREATION 
>   src/imageformats/ora.cpp PRE-CREATION 
>   src/imageformats/ora.desktop PRE-CREATION 
>   src/imageformats/ora.h PRE-CREATION 
>   src/imageformats/ora.json PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126675/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Boudewijn Rempt
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126675: Add .kra and .ora qimagio plugins

2016-01-31 Thread Boudewijn Rempt 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126675/
---

(Updated Jan. 31, 2016, 1:21 p.m.)


Review request for KDE Frameworks and Alex Merry.


Changes
---

Made karchive an optional dependency (don't let Martin Graesslin see it!)


Repository: kimageformats


Description
---

These qimageio plugins originally come from krita, but people who haven't got 
krita installed might want to view Krita or OpenRaster images as well. Both 
formats are really simple, just zip files with a png inside that represents the 
merged image. This patch does add a KF5::Archive dependency to kimageformats.


Diffs (updated)
-

  CMakeLists.txt 1e7e703 
  autotests/CMakeLists.txt 853607e 
  autotests/read/kra/src.kra PRE-CREATION 
  autotests/read/kra/src.png PRE-CREATION 
  autotests/read/ora/src.ora PRE-CREATION 
  autotests/read/ora/src.png PRE-CREATION 
  src/imageformats/CMakeLists.txt 8cf8d54 
  src/imageformats/kra.cpp PRE-CREATION 
  src/imageformats/kra.desktop PRE-CREATION 
  src/imageformats/kra.h PRE-CREATION 
  src/imageformats/kra.json PRE-CREATION 
  src/imageformats/ora.cpp PRE-CREATION 
  src/imageformats/ora.desktop PRE-CREATION 
  src/imageformats/ora.h PRE-CREATION 
  src/imageformats/ora.json PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126675/diff/


Testing
---


Thanks,

Boudewijn Rempt

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126675: Add .kra and .ora qimagio plugins

2016-01-31 Thread Alex Merry 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126675/#review91821
---




CMakeLists.txt (line 22)


What about making this optional (and only building those two plugins if it 
is found)?


- Alex Merry


On Jan. 27, 2016, 9:48 a.m., Boudewijn Rempt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126675/
> ---
> 
> (Updated Jan. 27, 2016, 9:48 a.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> ---
> 
> These qimageio plugins originally come from krita, but people who haven't got 
> krita installed might want to view Krita or OpenRaster images as well. Both 
> formats are really simple, just zip files with a png inside that represents 
> the merged image. This patch does add a KF5::Archive dependency to 
> kimageformats.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 1e7e703 
>   autotests/CMakeLists.txt 853607e 
>   autotests/read/kra/src.kra PRE-CREATION 
>   autotests/read/kra/src.png PRE-CREATION 
>   autotests/read/ora/src.ora PRE-CREATION 
>   autotests/read/ora/src.png PRE-CREATION 
>   src/imageformats/CMakeLists.txt 8cf8d54 
>   src/imageformats/kra.cpp PRE-CREATION 
>   src/imageformats/kra.desktop PRE-CREATION 
>   src/imageformats/kra.h PRE-CREATION 
>   src/imageformats/kra.json PRE-CREATION 
>   src/imageformats/ora.cpp PRE-CREATION 
>   src/imageformats/ora.desktop PRE-CREATION 
>   src/imageformats/ora.h PRE-CREATION 
>   src/imageformats/ora.json PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126675/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Boudewijn Rempt
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126675: Add .kra and .ora qimagio plugins

2016-01-31 Thread Alex Merry 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126675/#review91823
---


Ship it!




Ship It!

- Alex Merry


On Jan. 31, 2016, 1:21 p.m., Boudewijn Rempt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126675/
> ---
> 
> (Updated Jan. 31, 2016, 1:21 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> ---
> 
> These qimageio plugins originally come from krita, but people who haven't got 
> krita installed might want to view Krita or OpenRaster images as well. Both 
> formats are really simple, just zip files with a png inside that represents 
> the merged image. This patch does add a KF5::Archive dependency to 
> kimageformats.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 1e7e703 
>   autotests/CMakeLists.txt 853607e 
>   autotests/read/kra/src.kra PRE-CREATION 
>   autotests/read/kra/src.png PRE-CREATION 
>   autotests/read/ora/src.ora PRE-CREATION 
>   autotests/read/ora/src.png PRE-CREATION 
>   src/imageformats/CMakeLists.txt 8cf8d54 
>   src/imageformats/kra.cpp PRE-CREATION 
>   src/imageformats/kra.desktop PRE-CREATION 
>   src/imageformats/kra.h PRE-CREATION 
>   src/imageformats/kra.json PRE-CREATION 
>   src/imageformats/ora.cpp PRE-CREATION 
>   src/imageformats/ora.desktop PRE-CREATION 
>   src/imageformats/ora.h PRE-CREATION 
>   src/imageformats/ora.json PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126675/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Boudewijn Rempt
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126675: Add .kra and .ora qimagio plugins

2016-01-27 Thread Boudewijn Rempt 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126675/
---

(Updated Jan. 27, 2016, 9:48 a.m.)


Review request for KDE Frameworks and Alex Merry.


Changes
---

Added tests


Repository: kimageformats


Description
---

These qimageio plugins originally come from krita, but people who haven't got 
krita installed might want to view Krita or OpenRaster images as well. Both 
formats are really simple, just zip files with a png inside that represents the 
merged image. This patch does add a KF5::Archive dependency to kimageformats.


Diffs (updated)
-

  CMakeLists.txt 1e7e703 
  autotests/CMakeLists.txt 853607e 
  autotests/read/kra/src.kra PRE-CREATION 
  autotests/read/kra/src.png PRE-CREATION 
  autotests/read/ora/src.ora PRE-CREATION 
  autotests/read/ora/src.png PRE-CREATION 
  src/imageformats/CMakeLists.txt 8cf8d54 
  src/imageformats/kra.cpp PRE-CREATION 
  src/imageformats/kra.desktop PRE-CREATION 
  src/imageformats/kra.h PRE-CREATION 
  src/imageformats/kra.json PRE-CREATION 
  src/imageformats/ora.cpp PRE-CREATION 
  src/imageformats/ora.desktop PRE-CREATION 
  src/imageformats/ora.h PRE-CREATION 
  src/imageformats/ora.json PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126675/diff/


Testing
---


Thanks,

Boudewijn Rempt

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126675: Add .kra and .ora qimagio plugins

2016-01-18 Thread Boudewijn Rempt 


> On Jan. 16, 2016, 1:46 p.m., Alex Merry wrote:
> > I think the diff uploaded wrong, because reviewboard thinks all the new 
> > files are empty.
> > 
> > Also, could you please add test cases to the autotests directory? It 
> > shouldn't be too complicated, just an example file or two and the PNG 
> > equivalents.

Okay, will do -- I need my other laptop for that, so it needs to wait until I'm 
home, though.


- Boudewijn


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126675/#review91179
---


On Jan. 16, 2016, 9:55 a.m., Boudewijn Rempt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126675/
> ---
> 
> (Updated Jan. 16, 2016, 9:55 a.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> ---
> 
> These qimageio plugins originally come from krita, but people who haven't got 
> krita installed might want to view Krita or OpenRaster images as well. Both 
> formats are really simple, just zip files with a png inside that represents 
> the merged image. This patch does add a KF5::Archive dependency to 
> kimageformats.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 1e7e703 
>   src/imageformats/CMakeLists.txt 8cf8d54 
>   src/imageformats/kra.cpp PRE-CREATION 
>   src/imageformats/kra.desktop PRE-CREATION 
>   src/imageformats/kra.h PRE-CREATION 
>   src/imageformats/kra.json PRE-CREATION 
>   src/imageformats/ora.cpp PRE-CREATION 
>   src/imageformats/ora.desktop PRE-CREATION 
>   src/imageformats/ora.h PRE-CREATION 
>   src/imageformats/ora.json PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126675/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Boudewijn Rempt
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126675: Add .kra and .ora qimagio plugins

2016-01-16 Thread Alex Merry 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126675/#review91179
---



I think the diff uploaded wrong, because reviewboard thinks all the new files 
are empty.

Also, could you please add test cases to the autotests directory? It shouldn't 
be too complicated, just an example file or two and the PNG equivalents.

- Alex Merry


On Jan. 16, 2016, 9:55 a.m., Boudewijn Rempt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126675/
> ---
> 
> (Updated Jan. 16, 2016, 9:55 a.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kimageformats
> 
> 
> Description
> ---
> 
> These qimageio plugins originally come from krita, but people who haven't got 
> krita installed might want to view Krita or OpenRaster images as well. Both 
> formats are really simple, just zip files with a png inside that represents 
> the merged image. This patch does add a KF5::Archive dependency to 
> kimageformats.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 1e7e703 
>   src/imageformats/CMakeLists.txt 8cf8d54 
>   src/imageformats/kra.cpp PRE-CREATION 
>   src/imageformats/kra.desktop PRE-CREATION 
>   src/imageformats/kra.h PRE-CREATION 
>   src/imageformats/kra.json PRE-CREATION 
>   src/imageformats/ora.cpp PRE-CREATION 
>   src/imageformats/ora.desktop PRE-CREATION 
>   src/imageformats/ora.h PRE-CREATION 
>   src/imageformats/ora.json PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126675/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Boudewijn Rempt
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel