Re: Review Request 127060: Potentially fix 347962

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127060/
---

(Updated Feb. 16, 2016, 1:17 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 24d27b9cb733f727431c64e0a7845c39152c1104 by Aleix Pol to 
branch master.


Bugs: 347962
https://bugs.kde.org/show_bug.cgi?id=347962


Repository: kdeclarative


Description
---

I couldn't reproduce, but that's what it looks like from the backtraces.


Diffs
-

  src/kdeclarative/qmlobject.cpp f3cee66 

Diff: https://git.reviewboard.kde.org/r/127060/diff/


Testing
---

Tests still pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127060: Potentially fix 347962

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127060/#review92418
---


Ship it!




see comment


src/kdeclarative/qmlobject.cpp (line 115)


You must be getting in here.

someone  probably has
setSource(findFile(pathThatDoesntExist));

I'd upgrade that to a warning, 
and you don't want your QPointer<> change.


- David Edmundson


On Feb. 13, 2016, 2:01 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127060/
> ---
> 
> (Updated Feb. 13, 2016, 2:01 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Bugs: 347962
> https://bugs.kde.org/show_bug.cgi?id=347962
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> I couldn't reproduce, but that's what it looks like from the backtraces.
> 
> 
> Diffs
> -
> 
>   src/kdeclarative/qmlobject.cpp f3cee66 
> 
> Diff: https://git.reviewboard.kde.org/r/127060/diff/
> 
> 
> Testing
> ---
> 
> Tests still pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127060: Potentially fix 347962

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127060/
---

(Updated Feb. 13, 2016, 3:01 a.m.)


Review request for KDE Frameworks.


Changes
---

Use correct bug number


Summary (updated)
-

Potentially fix 347962


Bugs: 347962
https://bugs.kde.org/show_bug.cgi?id=347962


Repository: kdeclarative


Description
---

I couldn't reproduce, but that's what it looks like from the backtraces.


Diffs
-

  src/kdeclarative/qmlobject.cpp f3cee66 

Diff: https://git.reviewboard.kde.org/r/127060/diff/


Testing
---

Tests still pass.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel