Re: Review Request 127159: Make the KPeople qml example slightly more usable

2016-02-24 Thread Martin Klapetek

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127159/
---

(Updated Feb. 24, 2016, 6:08 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, KDEPIM and Plasma.


Changes
---

Submitted with commit 6ef69a8a17985926ad89543ba932f835d455cec8 by Martin 
Klapetek to branch master.


Repository: kpeople


Description
---

I've done this quite some time ago but noticed only just now that I still have 
it locally
* makes it less aggressive removing the red color
* removes the other two colorful rectangles serving seemingly no purpose
* moves the selected contact photo above the data
* makes the contact grid delegates nicer
* makes the default window size bigger


Diffs
-

  examples/qml/Main.qml 8d3a100 

Diff: https://git.reviewboard.kde.org/r/127159/diff/


Testing
---

Functionality is kept, for looks see screenshots


File Attachments


Before
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/23/cfcc2a9e-bc54-4031-85a6-9368f70f8056__snapshot96.png
After
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/23/e87bd7e0-9420-4ac4-919a-8a78cd7abc26__snapshot95.png


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127159: Make the KPeople qml example slightly more usable

2016-02-23 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127159/#review92699
---


Ship it!




Everybody hates red backgrounds /o\.

Thanks!

- Aleix Pol Gonzalez


On Feb. 23, 2016, 10:50 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127159/
> ---
> 
> (Updated Feb. 23, 2016, 10:50 p.m.)
> 
> 
> Review request for KDE Frameworks, KDEPIM and Plasma.
> 
> 
> Repository: kpeople
> 
> 
> Description
> ---
> 
> I've done this quite some time ago but noticed only just now that I still 
> have it locally
> * makes it less aggressive removing the red color
> * removes the other two colorful rectangles serving seemingly no purpose
> * moves the selected contact photo above the data
> * makes the contact grid delegates nicer
> * makes the default window size bigger
> 
> 
> Diffs
> -
> 
>   examples/qml/Main.qml 8d3a100 
> 
> Diff: https://git.reviewboard.kde.org/r/127159/diff/
> 
> 
> Testing
> ---
> 
> Functionality is kept, for looks see screenshots
> 
> 
> File Attachments
> 
> 
> Before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/23/cfcc2a9e-bc54-4031-85a6-9368f70f8056__snapshot96.png
> After
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/02/23/e87bd7e0-9420-4ac4-919a-8a78cd7abc26__snapshot95.png
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel