Re: Review Request 129351: Only search for a avatar if loginName isn't empty
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129351/ --- (Updated Nov. 6, 2016, 7:06 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, David Edmundson and Michael Pyne. Changes --- Submitted with commit d922477fc2ca03cc0a2e9ee2470f3cb4b37e0c2e by Heiko Becker to branch master. Repository: kcoreaddons Description --- 70c745d6147e465ce1e34b6037eb7dedb8e77f27 introduced fetching user avatars via AccountsService. It's seems pointless to search for an avatar with an empty user name, e.g. an invalid user, though. Furthermore it makes kusertest fail with the following message if ACCOUNTS_SERVICE_ICON_DIR exists: 'Actual (invalidKUser.faceIconPath()): "/var/lib/AccountsService/icons/" Expected (QString())' Diffs - src/lib/util/kuser_unix.cpp d45d0a1ff20b0b93c720d4320b44f4f5e57045a6 Diff: https://git.reviewboard.kde.org/r/129351/diff/ Testing --- kusertest doesn't fail anymore. Thanks, Heiko Becker
Re: Review Request 129351: Only search for a avatar if loginName isn't empty
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129351/#review100656 --- Ship it! Ship It! - David Edmundson On Nov. 6, 2016, 6:43 p.m., Heiko Becker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129351/ > --- > > (Updated Nov. 6, 2016, 6:43 p.m.) > > > Review request for KDE Frameworks, David Edmundson and Michael Pyne. > > > Repository: kcoreaddons > > > Description > --- > > 70c745d6147e465ce1e34b6037eb7dedb8e77f27 introduced fetching user > avatars via AccountsService. It's seems pointless to search for an > avatar with an empty user name, e.g. an invalid user, though. > Furthermore it makes kusertest fail with the following message if > ACCOUNTS_SERVICE_ICON_DIR exists: > 'Actual (invalidKUser.faceIconPath()): "/var/lib/AccountsService/icons/" > Expected (QString())' > > > Diffs > - > > src/lib/util/kuser_unix.cpp d45d0a1ff20b0b93c720d4320b44f4f5e57045a6 > > Diff: https://git.reviewboard.kde.org/r/129351/diff/ > > > Testing > --- > > kusertest doesn't fail anymore. > > > Thanks, > > Heiko Becker > >
