Re: Review Request 129381: kconfig fix kconfigskeletontest

[Allen Winter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129381/
---

(Updated Aug. 30, 2017, 4:08 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks.


Repository: kconfig


Description
---

some kconfigskeletontest tests were failing. this patch fixes:

1) rename init() and cleanup() to initTestCase() and cleanupTestCase() by 
convention and to make sure they happen in the correct order
2) testRemoveItem() must come after testKConfigDirty() becuase it removes the 
item we test for dirtyness
3) fix testSaveRead()


Diffs
-

  autotests/kconfigskeletontest.h 5cdcc9d 
  autotests/kconfigskeletontest.cpp 898366c 

Diff: https://git.reviewboard.kde.org/r/129381/diff/


Testing
---

before some of the tests fail and now they all pass.


Thanks,

Allen Winter

Re: Review Request 129381: kconfig fix kconfigskeletontest

[Allen Winter]

> On Nov. 11, 2016, 11:37 p.m., Aleix Pol Gonzalez wrote:
> > autotests/kconfigskeletontest.cpp, line 145
> > 
> >
> > I'm guessing that this was trying to make sure mMyBool is changed upon 
> > `s->read()`?

right, so could keep the mMyBool = true and change the last compare to 
QCOMPARE(mMyBool, true);


- Allen


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129381/#review100796
---


On Nov. 11, 2016, 10:14 p.m., Allen Winter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129381/
> ---
> 
> (Updated Nov. 11, 2016, 10:14 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> some kconfigskeletontest tests were failing. this patch fixes:
> 
> 1) rename init() and cleanup() to initTestCase() and cleanupTestCase() by 
> convention and to make sure they happen in the correct order
> 2) testRemoveItem() must come after testKConfigDirty() becuase it removes the 
> item we test for dirtyness
> 3) fix testSaveRead()
> 
> 
> Diffs
> -
> 
>   autotests/kconfigskeletontest.h 5cdcc9d 
>   autotests/kconfigskeletontest.cpp 898366c 
> 
> Diff: https://git.reviewboard.kde.org/r/129381/diff/
> 
> 
> Testing
> ---
> 
> before some of the tests fail and now they all pass.
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

Re: Review Request 129381: kconfig fix kconfigskeletontest

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129381/#review100796
---




autotests/kconfigskeletontest.cpp 


I'm guessing that this was trying to make sure mMyBool is changed upon 
`s->read()`?


- Aleix Pol Gonzalez


On Nov. 11, 2016, 11:14 p.m., Allen Winter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129381/
> ---
> 
> (Updated Nov. 11, 2016, 11:14 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> some kconfigskeletontest tests were failing. this patch fixes:
> 
> 1) rename init() and cleanup() to initTestCase() and cleanupTestCase() by 
> convention and to make sure they happen in the correct order
> 2) testRemoveItem() must come after testKConfigDirty() becuase it removes the 
> item we test for dirtyness
> 3) fix testSaveRead()
> 
> 
> Diffs
> -
> 
>   autotests/kconfigskeletontest.h 5cdcc9d 
>   autotests/kconfigskeletontest.cpp 898366c 
> 
> Diff: https://git.reviewboard.kde.org/r/129381/diff/
> 
> 
> Testing
> ---
> 
> before some of the tests fail and now they all pass.
> 
> 
> Thanks,
> 
> Allen Winter
> 
>