Re: Recent breakage in kwallet
here's my understanding of the problem: firstly, this is likely only a problem on debian-derived systems. and also only with blowfish debian has this patch [1] which on *actual* little endian systems (x86,arm64...) would run the conditional branches. the thing to note is that not only QBO is defined but also the ifs get changed. so, on LE systems that original patch was behaving the same as the QBO==QBE check (with both undefined) in kwallet proper. on BE systems however the conditional aren't run and so the output is different between us (kf5) and them (debian-derived system). so far so messy. what I think was the trouble Marco mentioned is that the original debian patch was badly merged with the change David made. specifically because of the changed conditionals, QBO must not be hardcoded with that patch as that'd make QBO!=QLE and fail the conditionals below thus change behavior. in short: I don't think David's commit broke anything. I've also made a potential fix for the actual bug in neon just now. also about [2] I'm sure that's not quite right because it breaks things the other way around (i.e. for it to work it'd also have to change the conditionals from QBO==QBE to QBO==QLE, same as the debian patch). and that would technically break wallets on big endian architectures (not that I'm sure we have many users on those). the way I see it kwallet can never be properly endian aware as it'd break legacy compatibility. equally debian can never not have the patch because it'd then no longer be properly endian aware and break its legacy compatibility well, of course either could decide that big endian isn't important enough and either become endian aware, or endian unaware ;) [1] https://packaging.neon.kde.org/kde/kwallet.git/commit/debian/patches/blowfish_endianess.diff?id=188ca124c69902e4fba01d2af6b419e1aac71177 [2] https://invent.kde.org/frameworks/kwallet/-/merge_requests/1
Re: Recent breakage in kwallet
Thanks for the pointer. Pretty sure it's wrong, but I'll reply there. On mardi 26 mai 2020 09:31:26 CEST Marco Martin wrote: > would the recent patch > https://invent.kde.org/frameworks/kwallet/-/merge_requests/1 > fix anything? > > On Sat, May 16, 2020 at 10:40 AM David Faure wrote: > > On vendredi 15 mai 2020 12:43:37 CEST Marco Martin wrote: > > > Hi all, > > > Recently, the package of KWallet framework for neon (devel unstable, > > > package built out of current master state) seems to be broken: kwallet > > > now can't open anymore wallets previously created (it works if the > > > local kwallet data is deleted and recreated) > > > the weird thing is that it seems that with a manual build it works > > > instead. > > > The only kinda suspicious commit is > > > 850219f83e7d746 fix compilation with -Werror=undef > > > which seems to fix.. big endian for everyone? > > > > It was supposed to only fix compiler warnings without changing behaviour > > at > > all. > > > > #if Q_BYTE_ORDER == Q_BIG_ENDIAN > > when neither is defined, evaluates to #if 0 == 0 (and warns) > > > > I defined both to 1, for the same result, but so that -Wundef doesn't > > warn. > > > > > still no idea why is broken only the distro-built package > > > > Any neon-specific patches to kwallet? > > > > -- > > David Faure, fa...@kde.org, http://www.davidfaure.fr > > Working on KDE Frameworks 5 -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
Re: Recent breakage in kwallet
would the recent patch https://invent.kde.org/frameworks/kwallet/-/merge_requests/1 fix anything? On Sat, May 16, 2020 at 10:40 AM David Faure wrote: > > On vendredi 15 mai 2020 12:43:37 CEST Marco Martin wrote: > > Hi all, > > Recently, the package of KWallet framework for neon (devel unstable, > > package built out of current master state) seems to be broken: kwallet > > now can't open anymore wallets previously created (it works if the > > local kwallet data is deleted and recreated) > > the weird thing is that it seems that with a manual build it works instead. > > The only kinda suspicious commit is > > 850219f83e7d746 fix compilation with -Werror=undef > > which seems to fix.. big endian for everyone? > > It was supposed to only fix compiler warnings without changing behaviour at > all. > > #if Q_BYTE_ORDER == Q_BIG_ENDIAN > when neither is defined, evaluates to #if 0 == 0 (and warns) > > I defined both to 1, for the same result, but so that -Wundef doesn't warn. > > > still no idea why is broken only the distro-built package > > Any neon-specific patches to kwallet? > > -- > David Faure, fa...@kde.org, http://www.davidfaure.fr > Working on KDE Frameworks 5 > > >
Re: Recent breakage in kwallet
On vendredi 15 mai 2020 12:43:37 CEST Marco Martin wrote: > Hi all, > Recently, the package of KWallet framework for neon (devel unstable, > package built out of current master state) seems to be broken: kwallet > now can't open anymore wallets previously created (it works if the > local kwallet data is deleted and recreated) > the weird thing is that it seems that with a manual build it works instead. > The only kinda suspicious commit is > 850219f83e7d746 fix compilation with -Werror=undef > which seems to fix.. big endian for everyone? It was supposed to only fix compiler warnings without changing behaviour at all. #if Q_BYTE_ORDER == Q_BIG_ENDIAN when neither is defined, evaluates to #if 0 == 0 (and warns) I defined both to 1, for the same result, but so that -Wundef doesn't warn. > still no idea why is broken only the distro-built package Any neon-specific patches to kwallet? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
Re: Recent breakage in kwallet
On Fri, May 15, 2020 at 3:53 PM Roman Gilg wrote: > > On Fri, May 15, 2020 at 12:44 PM Marco Martin wrote: > > > > Hi all, > > Recently, the package of KWallet framework for neon (devel unstable, > > package built out of current master state) seems to be broken: kwallet > > now can't open anymore wallets previously created (it works if the > > local kwallet data is deleted and recreated) > > the weird thing is that it seems that with a manual build it works instead. > > I build it manually and it's broken there too. > > > The only kinda suspicious commit is > > 850219f83e7d746 fix compilation with -Werror=undef > > which seems to fix.. big endian for everyone? > > still no idea why is broken only the distro-built package > > > > -- > > Marco Martin > > Just in case you're on Neon Dev Unstable: I just realized that on one > of the last updates the whole plasma-desktop and plasma-workspace > packages were uninstalled from my machine and now they can't be > installed anymore because of some conflict with libksysguard. > > I didn't notice it at first because I have a self-compiled version but > it would be not far fetched that even a separate compilation of > KWallet breaks in some ways when the Plasma installation in /usr is > ripped out, especially when only a subset of KDE packages is compiled. > So my plan at the moment is to wait until I can install Plasma back > into /usr and then try again. Package plasma-desktop can be installed again, so I did. But problem with KWallet sadly persists.
Re: Recent breakage in kwallet
On Fri, May 15, 2020 at 12:44 PM Marco Martin wrote: > > Hi all, > Recently, the package of KWallet framework for neon (devel unstable, > package built out of current master state) seems to be broken: kwallet > now can't open anymore wallets previously created (it works if the > local kwallet data is deleted and recreated) > the weird thing is that it seems that with a manual build it works instead. I build it manually and it's broken there too. > The only kinda suspicious commit is > 850219f83e7d746 fix compilation with -Werror=undef > which seems to fix.. big endian for everyone? > still no idea why is broken only the distro-built package > > -- > Marco Martin Just in case you're on Neon Dev Unstable: I just realized that on one of the last updates the whole plasma-desktop and plasma-workspace packages were uninstalled from my machine and now they can't be installed anymore because of some conflict with libksysguard. I didn't notice it at first because I have a self-compiled version but it would be not far fetched that even a separate compilation of KWallet breaks in some ways when the Plasma installation in /usr is ripped out, especially when only a subset of KDE packages is compiled. So my plan at the moment is to wait until I can install Plasma back into /usr and then try again.
Recent breakage in kwallet
Hi all, Recently, the package of KWallet framework for neon (devel unstable, package built out of current master state) seems to be broken: kwallet now can't open anymore wallets previously created (it works if the local kwallet data is deleted and recreated) the weird thing is that it seems that with a manual build it works instead. The only kinda suspicious commit is 850219f83e7d746 fix compilation with -Werror=undef which seems to fix.. big endian for everyone? still no idea why is broken only the distro-built package -- Marco Martin
