Re: Review Request 111905: Actually emit iconChanged
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111905/ --- (Updated Aug. 6, 2013, 9:58 a.m.) Status -- This change has been discarded. Review request for KDE Frameworks and Aleix Pol Gonzalez. Description --- The signal doesn't seem to be ever emitted, emit it when KIconLoaderGlobalData does Diffs - staging/kiconthemes/src/kiconloader.cpp 31e013e Diff: http://git.reviewboard.kde.org/r/111905/diff/ Testing --- Tested it on KdePLatformTheme, it worked nice. Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111905: Actually emit iconChanged
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111905/#review37197 --- Ship it! Ship It! - Aleix Pol Gonzalez On Aug. 6, 2013, 9:16 a.m., Àlex Fiestas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111905/ > --- > > (Updated Aug. 6, 2013, 9:16 a.m.) > > > Review request for KDE Frameworks and Aleix Pol Gonzalez. > > > Description > --- > > The signal doesn't seem to be ever emitted, emit it when > KIconLoaderGlobalData does > > > Diffs > - > > staging/kiconthemes/src/kiconloader.cpp 31e013e > > Diff: http://git.reviewboard.kde.org/r/111905/diff/ > > > Testing > --- > > Tested it on KdePLatformTheme, it worked nice. > > > Thanks, > > Àlex Fiestas > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 111905: Actually emit iconChanged
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111905/ --- Review request for KDE Frameworks and Aleix Pol Gonzalez. Description --- The signal doesn't seem to be ever emitted, emit it when KIconLoaderGlobalData does Diffs - staging/kiconthemes/src/kiconloader.cpp 31e013e Diff: http://git.reviewboard.kde.org/r/111905/diff/ Testing --- Tested it on KdePLatformTheme, it worked nice. Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
